Skip to contentSkip to conversation

Disable e4defrag in host-e2fsprogs

PATCH New Hollis Blanchard 2 participants 2 messages Jul 29, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Disable e4defrag in host-e2fsprogs

e4defrag from e2fsprogs 1.42.13 encounters these build errors on RHEL5.8 hosts:
e4defrag.c:197:2: error: #error sync_file_range not available! e4defrag.c:201:2: error: #error fallocate64 not available!

It's possible to fix these problems, but we don't use it on the host anyways, so just disable it.

---
 package/e2fsprogs/e2fsprogs.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/e2fsprogs/e2fsprogs.mk +4 -0
index c863f70..2f043ca 100644
@@ -12,6 +12,10 @@ E2FSPROGS_LICENSE_FILES = COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h l
 E2FSPROGS_INSTALL_STAGING = YES
 E2FSPROGS_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-libs
 
+# e4defrag doesn't build on older systems like RHEL5.x, and we don't need it
+# on the host anyways.
+HOST_E2FSPROGS_CONF_OPTS += --disable-defrag
+
 E2FSPROGS_CONF_OPTS = \
 	$(if $(BR2_STATIC_LIBS),,--enable-elf-shlibs) \
 	$(if $(BR2_PACKAGE_E2FSPROGS_DEBUGFS),,--disable-debugfs) \
Signature · 1 line
2.3.2
#1 lore raw

PATCH 1/1 Disable e4defrag in host-e2fsprogs

Dear Hollis Blanchard,

Quoted 11 lines · Hollis Blanchard

e4defrag from e2fsprogs 1.42.13 encounters these build errors on RHEL5.8 hosts:
e4defrag.c:197:2: error: #error sync_file_range not available! e4defrag.c:201:2: error: #error fallocate64 not available!

It's possible to fix these problems, but we don't use it on the host anyways, so just disable it.

---
 package/e2fsprogs/e2fsprogs.mk | 4 ++++
 1 file changed, 4 insertions(+)

Commit titles must follow the convention:

<package>: <description>

so I changed the title of your commit to:

e2fsprogs: disable e4defrag in host variant

and applied.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com