freerdp: Add support for tz package

Fixes error message while freerdp connected the remote desktop:
Unable to detect time zone

Signed-off-by Scott Fan <[email protected]>

Dear Scott Fan,

Quoted 4 lines · Scott Fan

Fixes error message while freerdp connected the remote desktop:
Unable to detect time zone

Signed-off-by Scott Fan <[email protected]>

You have already sent this patch numerous times, but you never include a changelog between the versions, so we don't understand why you're sending it again and again.

Can you at least put a cover letter in your patch series, which explains why you are sending the patches again?

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Sorry, my emails always been blocked by GFW in China, so i'm not sure whether mails sent successfully. Just now, i've got a stable VPN connection. I promise i won't repeat again.

THIS patch should be independent from the patch series, which fixes the error
message 'Unable to detect time zone' while the freerdp command connected a remote desktop.

Dear Scott Fan,

Quoted 2 lines · Scott Fan

Sorry, my emails always been blocked by GFW in China, so i'm not sure whether mails sent successfully. Just now, i've got a stable VPN

connection.

Quoted 1 line

I promise i won't repeat again.

Ok, I understand. You can check whether your e-mail arrived to the list by checking the list archives:

http://lists.busybox.net/pipermail/buildroot/

Note that it takes some time for the e-mails to get archived. I'm not sure how much, but maybe up to a few hours.

Quoted 3 lines

THIS patch should be independent from the patch series, which fixes the error
message 'Unable to detect time zone' while the freerdp command connected

a

Quoted 1 line

remote desktop.

Right, but it was part of your earlier patch series nonetheless.

Could you have a look at
http://patchwork.ozlabs.org/project/buildroot/list/, and tell us which of your patches are the latest ones and should still be considered for merging, and which ones are no longer current?

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

you can merge the patch 501074, 501261 now,

pls abort the previous patch 501049, 501050

Dear Scott Fan,

Quoted 1 line · Scott Fan

you can merge the patch 501074, 501261 now,

Well, they need some review and testing first.

Quoted 1 line

pls abort the previous patch 501049, 501050

Thanks, those ones marked as "Superseded".

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Fixes error message while freerdp connected the remote desktop:
Unable to detect time zone

Signed-off-by Scott Fan <[email protected]>

---
 .../freerdp/0004-add-support-for-tz-package.patch  | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch

package/freerdp/0004-add-support-for-tz-package.patch new file +30 -0

new file mode 100644
index 0000000..93e4afd
@@ -0,0 +1,30 @@
+From 605d0a85183d2f9d5b0da5629cbadf01173bbb2f Mon Sep 17 00:00:00 2001
+From: Scott Fan <[email protected]>
+Date: Mon, 13 Jul 2015 15:01:17 +0800
+Subject: [PATCH] Add support for tz package
+
+Fixes error message while freerdp connected the remote desktop:
+Unable to detect time zone
+
+Signed-off-by: Scott Fan <[email protected]>
+---
+ libfreerdp/locale/timezone.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/libfreerdp/locale/timezone.c b/libfreerdp/locale/timezone.c
+index 3070f1f..4a06786 100644
+--- a/libfreerdp/locale/timezone.c
++++ b/libfreerdp/locale/timezone.c
+@@ -1539,7 +1539,8 @@ char* freerdp_get_unix_timezone_identifier()
+ 	 * America/Montreal for example.
+ 	 */
+ 	
+-	if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1)
++	if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1 ||
++	    (len = readlink("/etc/TZ", buf, sizeof(buf) - 1)) != -1)
+ 	{
+ 		int num = 0;
+ 		int pos = len;
+-- 
+2.4.5
+

Signature · 6 lines

2.4.6

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Fixes error message while freerdp connected the remote desktop:
Unable to detect time zone

Signed-off-by Scott Fan <[email protected]>

---
 .../freerdp/0004-add-support-for-tz-package.patch  | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch

Can you please submit the patch to the freerdp project?

Dear Scott Fan,

Quoted 6 lines · Scott Fan

Fixes error message while freerdp connected the remote desktop:
Unable to detect time zone

Signed-off-by Scott Fan <[email protected]>

---
 .../freerdp/0004-add-support-for-tz-package.patch  | 30

++++++++++++++++++++++

Quoted 2 lines

 1 file changed, 30 insertions(+)
 create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch

Applied, thanks. Can you please submit the patch to the freerdp project?

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com