Skip to contentSkip to conversation

Build failures in 3.{10,14}-stable-queue

DISCUSSION Guenter Roeck 3 participants 8 messages Jul 30, 2015 – Jul 31, 2015 Stable branch

lore
Share & tools
lore
#0 lore raw

Various builds are affected.

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared

Guenter

#1 lore raw
Quoted 5 lines · Guenter Roeck

Various builds are affected.

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared

Ugh, my .config was not building that driver, sorry about that, now fixed and pushed out.

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg Kroah-Hartman
Quoted 5 lines · Guenter Roeck

Various builds are affected.

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared

Ugh, my .config was not building that driver, sorry about that, now fixed and pushed out.

Hi Greg,

there is another failure, 3.14 only as far as I can see.

Building i386:allyesconfig ... failed
--------------
Error log:
security/integrity/evm/evm_main.c: In function 'evm_protect_xattr':
security/integrity/evm/evm_main.c:280:41: error: 'TMPFS_MAGIC' undeclared security/integrity/evm/evm_main.c:281:44: error: 'SYSFS_MAGIC' undeclared

Guenter

#3 lore raw
Quoted 12 lines · Guenter Roeck
Quoted 9 lines · Greg Kroah-Hartman
Quoted 5 lines · Guenter Roeck

Various builds are affected.

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared

Ugh, my .config was not building that driver, sorry about that, now fixed and pushed out.

Hi Greg,

Quoted 8 lines

there is another failure, 3.14 only as far as I can see.

Building i386:allyesconfig ... failed
--------------
Error log:
security/integrity/evm/evm_main.c: In function 'evm_protect_xattr':
security/integrity/evm/evm_main.c:280:41: error: 'TMPFS_MAGIC' undeclared security/integrity/evm/evm_main.c:281:44: error: 'SYSFS_MAGIC' undeclared

Ugh, I thought I had test-built these properly.

Mimi, what did I get wrong with this set for 3.14-stable?

thanks,

greg k-h

#4 lore raw
Quoted 22 lines · Greg Kroah-Hartman
Quoted 12 lines · Guenter Roeck
Quoted 9 lines · Greg Kroah-Hartman
Quoted 5 lines · Guenter Roeck

Various builds are affected.

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared

Ugh, my .config was not building that driver, sorry about that, now fixed and pushed out.

Hi Greg,

Quoted 8 lines

there is another failure, 3.14 only as far as I can see.

Building i386:allyesconfig ... failed
--------------
Error log:
security/integrity/evm/evm_main.c: In function 'evm_protect_xattr':
security/integrity/evm/evm_main.c:280:41: error: 'TMPFS_MAGIC' undeclared security/integrity/evm/evm_main.c:281:44: error: 'SYSFS_MAGIC' undeclared

Quoted 3 lines

Ugh, I thought I had test-built these properly.

Mimi, what did I get wrong with this set for 3.14-stable?

Sorry, I should have included magic.h in this patch instead of relying on it to be included by some other include. Easy to forget when there are no warnings.

Looks like magic.h was added to sched.h in d4311ff "init/main.c: Give init_task a canary", but hasn't been backported to 3.14. evm_main.c includes audit.h, which includes sched.h.

Mimi

#5 lore raw
Quoted 27 lines · Mimi Zohar
Quoted 22 lines · Greg Kroah-Hartman
Quoted 12 lines · Guenter Roeck
Quoted 9 lines · Greg Kroah-Hartman
Quoted 5 lines · Guenter Roeck

Various builds are affected.

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared

Ugh, my .config was not building that driver, sorry about that, now fixed and pushed out.

Hi Greg,

Quoted 8 lines

there is another failure, 3.14 only as far as I can see.

Building i386:allyesconfig ... failed
--------------
Error log:
security/integrity/evm/evm_main.c: In function 'evm_protect_xattr':
security/integrity/evm/evm_main.c:280:41: error: 'TMPFS_MAGIC' undeclared security/integrity/evm/evm_main.c:281:44: error: 'SYSFS_MAGIC' undeclared

Quoted 3 lines

Ugh, I thought I had test-built these properly.

Mimi, what did I get wrong with this set for 3.14-stable?

Quoted 7 lines

Sorry, I should have included magic.h in this patch instead of relying on it to be included by some other include. Easy to forget when there are no warnings.

Looks like magic.h was added to sched.h in d4311ff "init/main.c: Give init_task a canary", but hasn't been backported to 3.14. evm_main.c includes audit.h, which includes sched.h.

So which patch should be changed to resolve this issue, and what should be changed? Can you send me a patch to merge together with another one?

thanks,

greg k-h

#6 lore raw
Quoted 32 lines · Greg Kroah-Hartman
Quoted 31 lines · Mimi Zohar
Quoted 22 lines · Greg Kroah-Hartman
Quoted 12 lines · Guenter Roeck
Quoted 9 lines · Greg Kroah-Hartman
Quoted 5 lines · Guenter Roeck

Various builds are affected.

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared

Ugh, my .config was not building that driver, sorry about that, now fixed and pushed out.

Hi Greg,

Quoted 8 lines

there is another failure, 3.14 only as far as I can see.

Building i386:allyesconfig ... failed
--------------
Error log:
security/integrity/evm/evm_main.c: In function 'evm_protect_xattr':
security/integrity/evm/evm_main.c:280:41: error: 'TMPFS_MAGIC' undeclared security/integrity/evm/evm_main.c:281:44: error: 'SYSFS_MAGIC' undeclared

Quoted 3 lines

Ugh, I thought I had test-built these properly.

Mimi, what did I get wrong with this set for 3.14-stable?

Sorry, I should have included magic.h in this patch instead of relying on it to be included by some other include. Easy to forget when there are no warnings.

Quoted 6 lines
Quoted 3 lines

Looks like magic.h was added to sched.h in d4311ff "init/main.c: Give init_task a canary", but hasn't been backported to 3.14. evm_main.c includes audit.h, which includes sched.h.

So which patch should be changed to resolve this issue, and what should be changed? Can you send me a patch to merge together with another one?

Oh, "evm: labeling pseudo filesystems exception" has been added to the 3.14-stable tree" needs to include magic.h.

Mimi

#7 lore raw
Quoted 37 lines · Mimi Zohar
Quoted 36 lines · Greg Kroah-Hartman
Quoted 34 lines · Mimi Zohar
Quoted 22 lines · Greg Kroah-Hartman
Quoted 12 lines · Guenter Roeck
Quoted 9 lines · Greg Kroah-Hartman
Quoted 5 lines · Guenter Roeck

Various builds are affected.

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared

Ugh, my .config was not building that driver, sorry about that, now fixed and pushed out.

Hi Greg,

Quoted 8 lines

there is another failure, 3.14 only as far as I can see.

Building i386:allyesconfig ... failed
--------------
Error log:
security/integrity/evm/evm_main.c: In function 'evm_protect_xattr':
security/integrity/evm/evm_main.c:280:41: error: 'TMPFS_MAGIC' undeclared security/integrity/evm/evm_main.c:281:44: error: 'SYSFS_MAGIC' undeclared

Quoted 3 lines

Ugh, I thought I had test-built these properly.

Mimi, what did I get wrong with this set for 3.14-stable?

Sorry, I should have included magic.h in this patch instead of relying on it to be included by some other include. Easy to forget when there are no warnings.

Looks like magic.h was added to sched.h in d4311ff "init/main.c: Give init_task a canary", but hasn't been backported to 3.14. evm_main.c includes audit.h, which includes sched.h.

Quoted 5 lines
Quoted 2 lines

So which patch should be changed to resolve this issue, and what should be changed? Can you send me a patch to merge together with another one?

Oh, "evm: labeling pseudo filesystems exception" has been added to the 3.14-stable tree" needs to include magic.h.

Ok, thanks, now fixed up.

greg k-h