Skip to contentSkip to conversation

b43: fix extpa_gain check for 2GHz

PATCH Applied Hauke Mehrtens 3 participants 7 messages Jul 29, 2015 – Jul 31, 2015 Networking drivers (wireless)

lore
Share & tools
lore

Hauke Mehrtens

author
#0 lore raw

PATCH 1/1 b43: fix extpa_gain check for 2GHz

On the 2GHz and and on the 5GHZ band only the extpa_gain setting from the 5GHz band was checked. this patch makes it check the property from the correct band.

Signed-off-by Hauke Mehrtens <[email protected]>
---
 drivers/net/wireless/b43/tables_nphy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/b43/tables_nphy.c +1 -1
index 25d1cbd..b2f0d24 100644
@@ -3728,7 +3728,7 @@ const u32 *b43_nphy_get_tx_gain_table(struct b43_wldev *dev)
 		switch (phy->rev) {
 		case 6:
 		case 5:
-			if (sprom->fem.ghz5.extpa_gain == 3)
+			if (sprom->fem.ghz2.extpa_gain == 3)
 				return b43_ntab_tx_gain_epa_rev3_hi_pwr_2g;
 			/* fall through */
 		case 4:
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 b43: fix extpa_gain check for 2GHz

Quoted 3 lines · Hauke Mehrtens

On the 2GHz and and on the 5GHZ band only the extpa_gain setting from the 5GHz band was checked. this patch makes it check the property from the correct band.

Looks OK, thanks.

#2 lore raw

PATCH 1/1 b43: fix extpa_gain check for 2GHz

In reply to Hauke Mehrtens
Quoted 5 lines · Hauke Mehrtens

On the 2GHz and and on the 5GHZ band only the extpa_gain setting from the 5GHz band was checked. this patch makes it check the property from the correct band.

Signed-off-by Hauke Mehrtens <[email protected]>

Is this a regression? If yes, please add a Fixes line.

Should this go to 4.2?

Signature · 1 line
Kalle Valo
#3 lore raw

PATCH 1/1 b43: fix extpa_gain check for 2GHz

Quoted 11 lines · Kalle Valo
Quoted 5 lines · Hauke Mehrtens

On the 2GHz and and on the 5GHZ band only the extpa_gain setting from the 5GHz band was checked. this patch makes it check the property from the correct band.

Signed-off-by Hauke Mehrtens <[email protected]>

Is this a regression? If yes, please add a Fixes line.

Should this go to 4.2?

Not a regression. It's like this for a loooong time.

AFAIK PCI(e) cards don't have external power amplifier, so this code is most likely used for some fancy SoCs only. There are 3 known SoCs with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.

So we may consider taking it for 4.2 without any "Fixes: " line but I wouldn't care too much about Cc-ing stable.

Hauke: do you agree?

Signature · 1 line
Rafa?
author
#4 lore raw

PATCH 1/1 b43: fix extpa_gain check for 2GHz

Quoted 15 lines · Rafa? Mi?ecki
Quoted 11 lines · Kalle Valo
Quoted 5 lines · Hauke Mehrtens

On the 2GHz and and on the 5GHZ band only the extpa_gain setting from the 5GHz band was checked. this patch makes it check the property from the correct band.

Signed-off-by Hauke Mehrtens <[email protected]>

Is this a regression? If yes, please add a Fixes line.

Should this go to 4.2?

Not a regression. It's like this for a loooong time.

Quoted 9 lines

AFAIK PCI(e) cards don't have external power amplifier, so this code is most likely used for some fancy SoCs only. There are 3 known SoCs with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.

So we may consider taking it for 4.2 without any "Fixes: " line but I wouldn't care too much about Cc-ing stable.

Hauke: do you agree?

Yes, I do not have a device I know of which is affected by this error, I just saw this while looking at code close by. Just put this into the next Linux version and not to stable.

Hauke

#5 lore raw

PATCH 1/1 b43: fix extpa_gain check for 2GHz

Quoted 20 lines · Hauke Mehrtens
Quoted 19 lines · Rafa? Mi?ecki
Quoted 11 lines · Kalle Valo
Quoted 5 lines · Hauke Mehrtens

On the 2GHz and and on the 5GHZ band only the extpa_gain setting from the 5GHz band was checked. this patch makes it check the property from the correct band.

Signed-off-by Hauke Mehrtens <[email protected]>

Is this a regression? If yes, please add a Fixes line.

Should this go to 4.2?

Not a regression. It's like this for a loooong time.

AFAIK PCI(e) cards don't have external power amplifier, so this code is most likely used for some fancy SoCs only. There are 3 known SoCs with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.

Quoted 8 lines
Quoted 4 lines

So we may consider taking it for 4.2 without any "Fixes: " line but I wouldn't care too much about Cc-ing stable.

Hauke: do you agree?

Yes, I do not have a device I know of which is affected by this error, I just saw this while looking at code close by. Just put this into the next Linux version and not to stable.

Ok, I'll send this to 4.2.

Signature · 1 line
Kalle Valo