Skip to contentSkip to conversation

dm: core: Allow simple-bus driver in SPL

PATCH New Marek Vasut 2 participants 3 messages Jul 27, 2015 – Aug 2, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm: core: Allow simple-bus driver in SPL

There's no reason why simple-bus driver can not be used in SPL, in fact it is necessary to get SoCFPGA SPL probe the cadence SPI driver. So drop the restriction.

---
 drivers/core/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/core/Makefile +0 -2
index 5c2ead8..87b7c98 100644
@@ -5,9 +5,7 @@
 #
 
 obj-y	+= device.o lists.o root.o uclass.o util.o
-ifndef CONFIG_SPL_BUILD
 obj-$(CONFIG_OF_CONTROL) += simple-bus.o
-endif
 obj-$(CONFIG_DM_DEVICE_REMOVE)	+= device-remove.o
 obj-$(CONFIG_DM)	+= dump.o
 obj-$(CONFIG_OF_CONTROL)	+= regmap.o
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 dm: core: Allow simple-bus driver in SPL

Hi Marek,

Quoted 25 lines · Marek Vasut

There's no reason why simple-bus driver can not be used in SPL, in fact it is necessary to get SoCFPGA SPL probe the cadence SPI driver. So drop the restriction.

---
 drivers/core/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/core/Makefile +0 -3
index 5c2ead8..87b7c98 100644
@@ -5,9 +5,7 @@
 #
 
 obj-y  += device.o lists.o root.o uclass.o util.o
-ifndef CONFIG_SPL_BUILD
 obj-$(CONFIG_OF_CONTROL) += simple-bus.o
-endif
 obj-$(CONFIG_DM_DEVICE_REMOVE) += device-remove.o
 obj-$(CONFIG_DM)       += dump.o
 obj-$(CONFIG_OF_CONTROL)       += regmap.o
--
Quoted 2 lines

2.1.4

Can you please instead add a new Kconfigs CONFIG_SIMPLE_BUS and CONFIG_SPL_SIMPLE_BUS? They can be default on. If we force all SPLs to have this, it does add bloat.

Regards,
Simon

#2 lore raw

PATCH 1/1 dm: core: Allow simple-bus driver in SPL

Quoted 34 lines · Simon Glass

Hi Marek,

Quoted 31 lines · Marek Vasut

There's no reason why simple-bus driver can not be used in SPL, in fact it is necessary to get SoCFPGA SPL probe the cadence SPI driver. So drop the restriction.

---

 drivers/core/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/core/Makefile +0 -2
index 5c2ead8..87b7c98 100644
@@ -5,9 +5,7 @@
 
 #
 
 obj-y  += device.o lists.o root.o uclass.o util.o
 
-ifndef CONFIG_SPL_BUILD
 
 obj-$(CONFIG_OF_CONTROL) += simple-bus.o
 
-endif
 
 obj-$(CONFIG_DM_DEVICE_REMOVE) += device-remove.o
 obj-$(CONFIG_DM)       += dump.o
 obj-$(CONFIG_OF_CONTROL)       += regmap.o
Quoted 6 lines
Quoted 2 lines

--
2.1.4

Can you please instead add a new Kconfigs CONFIG_SIMPLE_BUS and CONFIG_SPL_SIMPLE_BUS? They can be default on. If we force all SPLs to have this, it does add bloat.

Done

Best regards,
Marek Vasut