Skip to contentSkip to conversation

rapidxml: new package

PATCH Superseded Jonathan Ben-Avraham 2 participants 4 messages Aug 3, 2015 – Aug 4, 2015

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jonathan Ben-Avraham

author
#0 lore raw

PATCH 1/1 rapidxml: new package

From: Jonathan Ben Avraham <[email protected]>

Signed-off-by Jonathan Ben Avraham <[email protected]>
---
 package/Config.in              |    1 +
 package/rapidxml/Config.in     |   10 ++++++++++
 package/rapidxml/rapidxml.hash |    1 +
 package/rapidxml/rapidxml.mk   |   25 +++++++++++++++++++++++++
 4 files changed, 37 insertions(+)
 create mode 100644 package/rapidxml/Config.in
 create mode 100644 package/rapidxml/rapidxml.hash
 create mode 100644 package/rapidxml/rapidxml.mk
package/Config.in +1 -0
index ae00758..0a3386a 100644
@@ -915,6 +915,7 @@ menu "JSON/XML"
 	source "package/libyaml/Config.in"
 	source "package/mxml/Config.in"
 	source "package/rapidjson/Config.in"
+	source "package/rapidxml/Config.in"
 	source "package/tinyxml/Config.in"
 	source "package/tinyxml2/Config.in"
 	source "package/xerces/Config.in"
package/rapidxml/Config.in new file +10 -0
new file mode 100644
index 0000000..d17d838
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_RAPIDXML
+	bool "rapidxml"
+	help
+	  RapidXml is an attempt to create the fastest XML parser
+	  possible, while retaining useability, portability and
+	  reasonable W3C compatibility. It is an in-situ parser
+	  with parsing speed approaching speed of strlen function
+	  executed on the same data.
+
+	  http://sourceforge.net/projects/rapidxml/
package/rapidxml/rapidxml.hash new file +1 -0
new file mode 100644
index 0000000..8c7366c
@@ -0,0 +1 @@
+sha256	c3f0b886374981bb20fabcf323d755db4be6dba42064599481da64a85f5b3571  rapidxml-1.13.zip
package/rapidxml/rapidxml.mk new file +25 -0
new file mode 100644
index 0000000..af6b374
@@ -0,0 +1,25 @@
+################################################################################
+#
+# rapidxml
+#
+################################################################################
+
+RAPIDXML_VERSION = 1.13
+RAPIDXML_SOURCE = rapidxml-$(RAPIDXML_VERSION).zip
+
+#RAPIDXML_SITE = http://sourceforge.net/projects/rapidxml/files/latest/download
+RAPIDXML_SITE = http://garr.dl.sourceforge.net/project/rapidxml/rapidxml/rapidxml%201.13/
+RAPIDXML_LICENSE = MIT
+RAPIDXML_LICENSE_FILES = license.txt
+RAPIDXML_INSTALL_TARGET = NO
+RAPIDXML_INSTALL_STAGING = YES
+
+define RAPIDXML_EXTRACT_CMDS
+	$(UNZIP) -d $(@D) $(DL_DIR)/$(RAPIDXML_SOURCE)
+endef
+
+define RAPIDXML_INSTALL_STAGING_CMDS
+	cp -dpfr $(@D)/rapidxml-$(RAPIDXML_VERSION)/*hpp $(STAGING_DIR)/usr/include
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 rapidxml: new package

Hi Yonatan,

package/rapidxml/rapidxml.mk line 10

Quoted 4 lines · Jonathan Ben-Avraham
package/rapidxml/rapidxml.mk new file +4 -0
+RAPIDXML_VERSION = 1.13
+RAPIDXML_SOURCE = rapidxml-$(RAPIDXML_VERSION).zip
+
+#RAPIDXML_SITE = http://sourceforge.net/projects/rapidxml/files/latest/download

Please remove.

Quoted 1 line

+RAPIDXML_SITE = http://garr.dl.sourceforge.net/project/rapidxml/rapidxml/rapidxml%201.13/

Does

RAPIDXML_SITE = http://sourceforge.net/project/rapidxml/rapidxml/rapidxml%20$(RAPIDXML_VERSION)/

work?

package/rapidxml/rapidxml.mk line 14

Quoted 3 lines
package/rapidxml/rapidxml.mk new file +3 -0
+RAPIDXML_LICENSE = MIT
+RAPIDXML_LICENSE_FILES = license.txt
+RAPIDXML_INSTALL_TARGET = NO

This needs an explanation comment. Is this a header only package?

package/rapidxml/rapidxml.mk line 25

Quoted 11 lines
package/rapidxml/rapidxml.mk new file +11 -0
+RAPIDXML_INSTALL_STAGING = YES
+
+define RAPIDXML_EXTRACT_CMDS
+	$(UNZIP) -d $(@D) $(DL_DIR)/$(RAPIDXML_SOURCE)
+endef
+
+define RAPIDXML_INSTALL_STAGING_CMDS
+	cp -dpfr $(@D)/rapidxml-$(RAPIDXML_VERSION)/*hpp $(STAGING_DIR)/usr/include
+endef
+
+$(eval $(generic-package))

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#2 lore raw

PATCH 1/1 rapidxml: new package

Hi Baruch,

Quoted 30 lines · Baruch Siach

Date: Mon, 3 Aug 2015 22:57:42 +0300
From: Baruch Siach <[email protected]>
To: Jonathan Ben-Avraham <[email protected]>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] rapidxml: new package

Hi Yonatan,

package/rapidxml/rapidxml.mk line 10

Quoted 4 lines · Jonathan Ben-Avraham
package/rapidxml/rapidxml.mk new file +4 -0
+RAPIDXML_VERSION = 1.13
+RAPIDXML_SOURCE = rapidxml-$(RAPIDXML_VERSION).zip
+
+#RAPIDXML_SITE = http://sourceforge.net/projects/rapidxml/files/latest/download

Please remove.

Quoted 1 line

+RAPIDXML_SITE = http://garr.dl.sourceforge.net/project/rapidxml/rapidxml/rapidxml%201.13/

Does

RAPIDXML_SITE = http://sourceforge.net/project/rapidxml/rapidxml/rapidxml%20$(RAPIDXML_VERSION)/

work?

package/rapidxml/rapidxml.mk line 14

Quoted 3 lines
package/rapidxml/rapidxml.mk new file +3 -0
+RAPIDXML_LICENSE = MIT
+RAPIDXML_LICENSE_FILES = license.txt
+RAPIDXML_INSTALL_TARGET = NO

This needs an explanation comment. Is this a header only package?

Quoted 13 lines

package/rapidxml/rapidxml.mk line 25

Quoted 11 lines
package/rapidxml/rapidxml.mk new file +11 -0
+RAPIDXML_INSTALL_STAGING = YES
+
+define RAPIDXML_EXTRACT_CMDS
+	$(UNZIP) -d $(@D) $(DL_DIR)/$(RAPIDXML_SOURCE)
+endef
+
+define RAPIDXML_INSTALL_STAGING_CMDS
+	cp -dpfr $(@D)/rapidxml-$(RAPIDXML_VERSION)/*hpp $(STAGING_DIR)/usr/include
+endef
+
+$(eval $(generic-package))

baruch

I removed the commented line and added the version variable to the RAPIDXML_SITE value as per your request in the v2 patch submitted just now.

Regarding "This needs an explanation comment. Is this a header only package?", you can see from RAPIDXML_INSTALL_TARGET = NO and RAPIDXML_INSTALL_STAGING = YES that the answer must be "yes". I did not see a need to add a comment since the precedent package "rapidjson", also has no comment.

- yba

Signature · 3 lines
  9590 8E58 D30D 1660 C349  673D B205 4FC4 B8F5 B7F9  ~. .~  Tk Open Systems
=}-------- Jonathan Ben-Avraham ("yba") ----------ooO--U--Ooo------------{=
mailto:yba at tkos.co.il tel:+972.52.486.3386 http://tkos.co.il skype:benavrhm
#3 lore raw

PATCH 1/1 rapidxml: new package

Hi Yonatan,

Quoted 6 lines · Jonathan Ben Avraham
Quoted 6 lines · Jonathan Ben-Avraham
Quoted 1 line

+RAPIDXML_INSTALL_TARGET = NO

This needs an explanation comment. Is this a header only package?

Quoted 1 line

+RAPIDXML_INSTALL_STAGING = YES

[snip]

Quoted 5 lines

Regarding "This needs an explanation comment. Is this a header only package?", you can see from RAPIDXML_INSTALL_TARGET = NO and RAPIDXML_INSTALL_STAGING = YES that the answer must be "yes". I did not see a need to add a comment since the precedent package "rapidjson", also has no comment.

Set precedents are not always a good guide. That's the case here, IMO.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -