dawgdic: new package
PATCH v2 1/1 dawgdic: new package
From: Jonathan Ben Avraham <[email protected]>
The dawgdic package provides object files and utilities for building and accessing directed acyclical word graph (DAWG) dictionaries.
This version of the patch uses the updated GitHub dawgdic repo instead of the Google Code repo used in the previous version of this patch.
--- package/Config.in | 1 + package/dawgdic/Config.in | 13 +++++++++++++ package/dawgdic/dawgdic.mk | 17 +++++++++++++++++ 3 files changed, 31 insertions(+) create mode 100644 package/dawgdic/Config.in create mode 100644 package/dawgdic/dawgdic.mk
package/Config.in +1 -0
@@ -1041,6 +1041,7 @@ menu "Other" source "package/clapack/Config.in" source "package/classpath/Config.in" source "package/cppcms/Config.in" + source "package/dawgdic/Config.in" source "package/ding-libs/Config.in" source "package/eigen/Config.in" source "package/elfutils/Config.in"
package/dawgdic/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_DAWGDIC + bool "dawgdic" + help + dawgdic provides a library for building and accessing + dictionaries implemented with directed acyclic word graphs + (DAWG). A dawg is constructed by minimizing a trie as a + deterministic finite automaton (DFA), and thus the dawg has + an advantage in memory usage. In addition, dawgdic uses a + double-array as a base data structure, so its retrieval + speed is as fast as that of Darts, a library for building + and accessing double-array tries. + + https://github.com/stil/dawgdic
package/dawgdic/dawgdic.mk new file +17 -0
@@ -0,0 +1,17 @@ +################################################################################ +# +# dawgdic +# +################################################################################ + +#DAWGDIC_SITE = http://dawgdic.googlecode.com/svn/trunk +DAWGDIC_SITE = https://github.com/stil/dawgdic.git +DAWGDIC_SITE_METHOD = git +DAWGDIC_VERSION = 16ac537ba9883ff01b63b6d1fdc3072150c68fee +DAWGDIC_LICENSE = GPLv3 +DAWGDIC_LICENSE_FILES = COPYING + +DAWGDIC_AUTORECONF = YES +DAWGDIC_INSTALL_STAGING = YES + +$(eval $(autotools-package))
Signature · 1 line
1.7.9.5
PATCH v2 1/1 dawgdic: new package
Hi Yonatan,
package/dawgdic/dawgdic.mk line 7
Quoted 13 lines · Jonathan Ben-Avraham
package/dawgdic/dawgdic.mk new file +7
-0@@ -0,0 +1,17 @@ +################################################################################ +# +# dawgdic +# +################################################################################ + +#DAWGDIC_SITE = http://dawgdic.googlecode.com/svn/trunk
Please remove.
package/dawgdic/dawgdic.mk line 10
Quoted 3 lines
package/dawgdic/dawgdic.mk new file +3
-0+DAWGDIC_SITE = https://github.com/stil/dawgdic.git +DAWGDIC_SITE_METHOD = git +DAWGDIC_VERSION = 16ac537ba9883ff01b63b6d1fdc3072150c68fee
Please use the github helper. See
http://nightly.buildroot.org/manual.html#github-download-url.
package/dawgdic/dawgdic.mk line 14
Quoted 4 lines
package/dawgdic/dawgdic.mk new file +4
-0+DAWGDIC_LICENSE = GPLv3 +DAWGDIC_LICENSE_FILES = COPYING + +DAWGDIC_AUTORECONF = YES
Why is that needed? Please explain in a comment.
package/dawgdic/dawgdic.mk line 17
Quoted 3 lines
package/dawgdic/dawgdic.mk new file +3
-0+DAWGDIC_INSTALL_STAGING = YES + +$(eval $(autotools-package))
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH v2 1/1 dawgdic: new package
In reply to Jonathan Ben-AvrahamDear Jonathan Ben-Avraham,
Quoted 9 lines · Jonathan Ben-Avraham
From: Jonathan Ben Avraham <[email protected]>
The dawgdic package provides object files and utilities for building and accessing directed acyclical word graph (DAWG) dictionaries.
This version of the patch uses the updated GitHub dawgdic repo instead of the Google Code repo used in the previous version of this patch.
Signed-off-by Jonathan Ben Avraham <[email protected]>
Patch applied, but I had to do quite a bit of changes:
[Thomas:
- use the github macro for <pkg>_SITE
- remove <pkg>_SITE_METHOD, useless once you use the github macro for <pkg>_SITE
- fix the license, it is BSD-3c and not GPLv3
- remove commented <pkg>_SITE in the .mk file
- add missing dependency on C++.]
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 dawgdic: new package
Hi Thomas,
Thanks.
Hold off on the other patches that I submitted. Baruch will provide feedback on what needs to be done and I will do the work myself from now on.
- yba
Quoted 33 lines · Thomas Petazzoni
Date: Tue, 4 Aug 2015 11:18:48 +0200
From: Thomas Petazzoni <[email protected]>
To: Jonathan Ben-Avraham <[email protected]>
Cc: buildroot at busybox.net
Subject: Re: [Buildroot] [PATCH v2 1/1] dawgdic: new packageDear Jonathan Ben-Avraham,
Quoted 9 lines · Jonathan Ben-Avraham
From: Jonathan Ben Avraham <[email protected]>
The dawgdic package provides object files and utilities for building and accessing directed acyclical word graph (DAWG) dictionaries.
This version of the patch uses the updated GitHub dawgdic repo instead of the Google Code repo used in the previous version of this patch.
Signed-off-by Jonathan Ben Avraham <[email protected]>Patch applied, but I had to do quite a bit of changes:
[Thomas:
- use the github macro for <pkg>_SITE
- remove <pkg>_SITE_METHOD, useless once you use the github macro for <pkg>_SITE
- fix the license, it is BSD-3c and not GPLv3
- remove commented <pkg>_SITE in the .mk file
- add missing dependency on C++.]Thanks!
Thomas
Signature · 3 lines
9590 8E58 D30D 1660 C349 673D B205 4FC4 B8F5 B7F9 ~. .~ Tk Open Systems
=}-------- Jonathan Ben-Avraham ("yba") ----------ooO--U--Ooo------------{=
mailto:yba at tkos.co.il tel:+972.52.486.3386 http://tkos.co.il skype:benavrhmPATCH v2 1/1 dawgdic: new package
Jonathan,
Quoted 3 lines · Jonathan Ben Avraham
Hold off on the other patches that I submitted. Baruch will provide feedback on what needs to be done and I will do the work myself from now on.
Well, that's OK, I don't mind doing a bit of rework. Having perfect patches is indeed better, but it's perfectly fine for me that new contributors don't yet know all the "rules" / best practices.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com