Skip to contentSkip to conversation

ddr: altera: sequencer: add RW_MGR_MEM_NUMBER_OF_RANKS

PATCH New dinguyen at opensource.altera.com 2 participants 5 messages Aug 5, 2015

lore
Share & tools
lore

dinguyen at opensource.altera.com

author
#0 lore raw

PATCH 1/1 ddr: altera: sequencer: add RW_MGR_MEM_NUMBER_OF_RANKS

From: Dinh Nguyen <[email protected]>

Fix build error for socfpga_cyclone5_defconfig:

board/altera/socfpga/wrap_sdram_config.c:245:26: error: ?RW_MGR_MEM_NUMBER_OF_RANKS? undeclared here (not in a function) make[2]: *** [spl/board/altera/socfpga/wrap_sdram_config.o] Error 1

Signed-off-by Dinh Nguyen <[email protected]>

---
Hi Marek,

This patch is based on your 02-ddr-part3 branch. It is also applicable to the wip/boards branch as well.

Thanks,
Dinh

---
 board/altera/socfpga/qts/sequencer_defines.h | 1 +
 1 file changed, 1 insertion(+)
board/altera/socfpga/qts/sequencer_defines.h +1 -0
index 32f13ac..bfe5b27 100644
@@ -103,6 +103,7 @@
 #define RW_MGR_MEM_IF_READ_DQS_WIDTH 5
 #define RW_MGR_MEM_IF_WRITE_DQS_WIDTH 5
 #define RW_MGR_MEM_NUMBER_OF_CS_PER_DIMM 1
+#define RW_MGR_MEM_NUMBER_OF_RANKS 1
 #define RW_MGR_MEM_ODT_WIDTH 1
 #define RW_MGR_MEM_VIRTUAL_GROUPS_PER_READ_DQS 1
 #define RW_MGR_MEM_VIRTUAL_GROUPS_PER_WRITE_DQS 1
Signature · 1 line
2.4.5
#1 lore raw

PATCH 1/1 ddr: altera: sequencer: add RW_MGR_MEM_NUMBER_OF_RANKS

Quoted 8 lines · dinguyen at opensource.altera.com

From: Dinh Nguyen <[email protected]>

Fix build error for socfpga_cyclone5_defconfig:

board/altera/socfpga/wrap_sdram_config.c:245:26: error:
?RW_MGR_MEM_NUMBER_OF_RANKS? undeclared here (not in a function) make[2]:
*** [spl/board/altera/socfpga/wrap_sdram_config.o] Error 1

Quoted 6 lines
Signed-off-by Dinh Nguyen <[email protected]>

---
Hi Marek,

This patch is based on your 02-ddr-part3 branch. It is also applicable to the wip/boards branch as well.

Hi,

Ouch, thanks for spotting this!

Acked-by Marek Vasut <[email protected]>

btw. did you have time to skim through [PATCH 00/28] socfpga: sdram.c cleanups please ? I'd like to apply that to master, put on the sequencer cleanups and this patch and then submit a PR :)

Best regards,
Marek Vasut

author
#2 lore raw

PATCH 1/1 ddr: altera: sequencer: add RW_MGR_MEM_NUMBER_OF_RANKS

Quoted 5 lines · Marek Vasut

btw. did you have time to skim through [PATCH 00/28] socfpga: sdram.c cleanups please ? I'd like to apply that to master, put on the sequencer cleanups and this patch and then submit a PR :)

Oh, I didn't see this series come in. You've been so quiet, :). I'll look for it.

Thanks,
Dinh

#3 lore raw

PATCH 1/1 ddr: altera: sequencer: add RW_MGR_MEM_NUMBER_OF_RANKS

Quoted 7 lines · Dinh Nguyen
Quoted 3 lines · Marek Vasut

btw. did you have time to skim through [PATCH 00/28] socfpga: sdram.c cleanups please ? I'd like to apply that to master, put on the sequencer cleanups and this patch and then submit a PR :)

Oh, I didn't see this series come in. You've been so quiet, :). I'll look for it.

Maybe the spam filter in Altera blocked me for a while there :-) Thanks!

Best regards,
Marek Vasut

Applied
#4 lore raw

PATCH 1/1 ddr: altera: sequencer: add RW_MGR_MEM_NUMBER_OF_RANKS

In reply to dinguyen at opensource.altera.com
Quoted 9 lines · dinguyen at opensource.altera.com

From: Dinh Nguyen <[email protected]>

Fix build error for socfpga_cyclone5_defconfig:

board/altera/socfpga/wrap_sdram_config.c:245:26: error:
?RW_MGR_MEM_NUMBER_OF_RANKS? undeclared here (not in a function) make[2]:
*** [spl/board/altera/socfpga/wrap_sdram_config.o] Error 1

Signed-off-by Dinh Nguyen <[email protected]>

Applied, thanks!

Best regards,
Marek Vasut