drivers: staging: wilc1000: Fix a few style errors
v2 cover drivers: staging: wilc1000: Fix a few style errors
v2 - Resending as v1 patch series did not apply cleanly.
These patches fixes a few style errors reported by checkpatch.pl. PATCH 3/3 should be applied after PATCH 2/3.
PATCH v2 1/3 drivers: staging: wilc1000: use 'void' for no arguments functions
Added 'void' keyword in the paranthesis of function definitions, when there are no arguments to the functions. This fixes the checkpatch.pl error - "Bad function definition 'function()' should probably be function(void)".
--- drivers/staging/wilc1000/linux_mon.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wilc1000/linux_mon.c +1 -1
@@ -558,7 +558,7 @@ struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_devi* @date 12 JUL 2012 * @version 1.0 */ -int WILC_WFI_deinit_mon_interface () +int WILC_WFI_deinit_mon_interface (void ) {bool rollback_lock = false;
drivers/staging/wilc1000/linux_wlan.c +2 -2
@@ -202,7 +202,7 @@ void printk_later(const char *format, ...) } -void dump_logs () +void dump_logs (void ) {if (DebugBuffer[0 ]) { DebugBuffer[DEGUG_BUFFER_LENGTH ] =0 ;
@@ -216,7 +216,7 @@ void dump_logs() } } -void Reset_WatchDogdebugger () +void Reset_WatchDogdebugger (void ) { WatchDogdebuggerCounter =0 ; }
Signature · 1 line
2.5.0
PATCH v2 2/3 drivers: staging: wilc1000: move { to previous line
Moved the opening brace of code blocks to the previous lines. This fixes the checkpatch.pl error - "that open brace { should be on the previous line".
--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +3 -6
@@ -1205,8 +1205,7 @@ static int WILC_WFI_add_key(struct wiphy *wiphy, struct net_device *netdev, u8 k -if (!pairwise) - { +if (!pairwise) {if (params->cipher ==WLAN_CIPHER_SUITE_TKIP ) u8gmode =ENCRYPT_ENABLED |WPA |TKIP ;else
@@ -1304,8 +1303,7 @@ static int WILC_WFI_add_key(struct wiphy *wiphy, struct net_device *netdev, u8 k { u8mode =0 ; -if (!pairwise) - { +if (!pairwise) {if (params->key_len >16 && params->cipher ==WLAN_CIPHER_SUITE_TKIP ) {/* swap the tx mic by rx mic */ pu8RxMic = params->key +24 ;
@@ -1531,8 +1529,7 @@ static int WILC_WFI_get_key(struct wiphy *wiphy, struct net_device *netdev, u8 k priv =wiphy_priv (wiphy); -if (!pairwise) - { +if (!pairwise) {PRINT_D (CFG80211_DBG ,"Getting group key idx: %x\n" , key_index); key_params.key = priv->wilc_gtk[key_index]->key;
Signature · 1 line
2.5.0
PATCH v2 3/3 drivers: staging: wilc1000: remove space after '('
The character ' ' is removed after the character '('. This fixes the checkpatch.pl error - "space prohibited after that open parenthesis '('".
--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +1 -1
@@ -1675,7 +1675,7 @@ static int WILC_WFI_get_station(struct wiphy *wiphy, struct net_device *dev,* kernel version 3.0.0 */ sinfo->filled |=BIT (NL80211_STA_INFO_SIGNAL ) | -BIT (NL80211_STA_INFO_RX_PACKETS ) | +BIT (NL80211_STA_INFO_RX_PACKETS ) |BIT (NL80211_STA_INFO_TX_PACKETS ) |BIT (NL80211_STA_INFO_TX_FAILED ) |BIT (NL80211_STA_INFO_TX_BITRATE );
Signature · 1 line
2.5.0
Greg KH
maintainerRe: [PATCH v2 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions
In reply to Chandra S GorentlaQuoted 9 lines · Chandra S Gorentla
Added 'void' keyword in the paranthesis of function definitions, when there are no arguments to the functions. This fixes the checkpatch.pl error - "Bad function definition '
function()' should probably be function(void)".--- drivers/staging/wilc1000/linux_mon.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot