Skip to contentSkip to conversation

acer-wmi: No rfkill on HP wifi

PATCH Superseded Powell, Michael 2 participants 4 messages Apr 23, 2015 – Aug 5, 2015

Subsystems (2)
x86 platform drivers Acer WMI laptop extras
lore
Share & tools
lore

Powell, Michael

author
#0 lore raw

PATCH 1/1 acer-wmi: No rfkill on HP wifi

Prevents acer-wmi from blocking wifi on HP Omen 15 laptops

Signed-off-by Michael Powell <[email protected]>
---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/platform/x86/acer-wmi.c
index 3ac29a1..3ad8077 100644

drivers/platform/x86/acer-wmi.c +0 -0
@@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]

__initconst = {
{ "IBM0068", 0},
{ "LEN0068", 0},
{ "SNY5001", 0}, /* sony-laptop in charge */
+ { "HPQ6001", 0},
{ "", 0},
};

Signature · 1 line
2.1.0
author
#1 lore raw

PATCH RESEND 1/1 acer-wmi: No rfkill on HP wifi

Prevents acer-wmi from blocking wifi on HP Omen 15 laptops

Signed-off-by Michael Powell <[email protected]>
---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/platform/x86/acer-wmi.c
index 3ac29a1..3ad8077 100644

drivers/platform/x86/acer-wmi.c +0 -0
@@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]

__initconst = {
        { "IBM0068", 0},
        { "LEN0068", 0},
        { "SNY5001", 0},        /* sony-laptop in charge */
+	{ "HPQ6001", 0},
        { "", 0},

};

Signature · 1 line
2.1.0
#2 lore raw
Quoted 1 line · Michael

Prevents acer-wmi from blocking wifi on HP Omen 15 laptops

Wow, you managed to miss both my automated scans for patches that fail to Cc the maintainer :-) Patchwork caught it though.

Please Cc the maintainer listed in MAINTAINERS in the future per Documentation/SubmittingPatches, section 5.

Quoted 12 lines
Signed-off-by Michael Powell <[email protected]>
---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/acer-wmi.c +0 -0
index 3ac29a1..3ad8077 100644

drivers/platform/x86/acer-wmi.c static const struct acpi_device_id norfkill_ids[] · line 813

Quoted 7 lines
drivers/platform/x86/acer-wmi.c +1 -0
@@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]
 __initconst = {
        { "IBM0068", 0},
        { "LEN0068", 0},
        { "SNY5001", 0},        /* sony-laptop in charge */
+	{ "HPQ6001", 0},
        { "", 0},
 };

I haven't determined the reason yet, but when saving this to apply, I get an encoded blob of text instead of the patch. How did you send this email?

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center
#3 lore raw
Quoted 15 lines · Darren Hart
Quoted 1 line · Michael

Prevents acer-wmi from blocking wifi on HP Omen 15 laptops

Wow, you managed to miss both my automated scans for patches that fail to Cc the maintainer :-) Patchwork caught it though.

Please Cc the maintainer listed in MAINTAINERS in the future per Documentation/SubmittingPatches, section 5.

Quoted 6 lines
Signed-off-by Michael Powell <[email protected]>
---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 16 lines

drivers/platform/x86/acer-wmi.c static const struct acpi_device_id norfkill_ids[] · line 813

Quoted 13 lines
drivers/platform/x86/acer-wmi.c +1 -0
index 3ac29a1..3ad8077 100644
@@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]
 __initconst = {
        { "IBM0068", 0},
        { "LEN0068", 0},
        { "SNY5001", 0},        /* sony-laptop in charge */
+	{ "HPQ6001", 0},
        { "", 0},
 };

I haven't determined the reason yet, but when saving this to apply, I get an encoded blob of text instead of the patch. How did you send this email?

And when pulling it down from Patchwork it has embedded ^M characters which cause it to fail to apply with:

fatal: corrupt patch at line 17

Please resubmit after sending to yourself and verifying you can apply the patch.

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center