Skip to contentSkip to conversation

jQuery: introduce external plugin menu

PATCH Superseded Yegor Yefremov 2 participants 2 messages Aug 5, 2015 – Aug 6, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yegor Yefremov

author
#0 lore raw

PATCH 1/1 jQuery: introduce external plugin menu

List all jQuery plugins in a dedicated menu and remove uneeded jQuery selection.

Signed-off-by Yegor Yefremov <[email protected]>
---
 package/Config.in                       | 4 ++++
 package/jquery-datetimepicker/Config.in | 3 +--
 package/jquery-keyboard/Config.in       | 1 -
 package/jquery-mobile/Config.in         | 2 +-
 package/jquery-sparkline/Config.in      | 1 -
 package/jquery-ui/Config.in             | 1 -
 package/jquery-validation/Config.in     | 1 -
 7 files changed, 6 insertions(+), 7 deletions(-)
package/Config.in +4 -0
index 47d14d7..55a4576 100644
@@ -888,6 +888,8 @@ menu "Javascript"
 	source "package/explorercanvas/Config.in"
 	source "package/flot/Config.in"
 	source "package/jquery/Config.in"
+if BR2_PACKAGE_JQUERY
+menu "external jQuery plugins"
 	source "package/jquery-datetimepicker/Config.in"
 	source "package/jquery-keyboard/Config.in"
 	source "package/jquery-mobile/Config.in"

@@ -895,6 +897,8 @@ menu "Javascript"
 	source "package/jquery-ui/Config.in"
 	source "package/jquery-ui-themes/Config.in"
 	source "package/jquery-validation/Config.in"
+endmenu
+endif
 	source "package/jsmin/Config.in"
 	source "package/json-javascript/Config.in"
 endmenu
package/jquery-datetimepicker/Config.in +1 -2
index 6a07ec3..ae101ca 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_DATETIMEPICKER
-	bool "jquery-datetimepicker"
-	select BR2_PACKAGE_JQUERY
+	bool "jQuery-datetimepicker"
 	help
 	  Use this plugin to unobtrusively add a datetimepicker,
 	  datepicker or timepicker dropdown to your forms.
package/jquery-keyboard/Config.in +0 -1
index e44193e..3f7a486 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_KEYBOARD
 	bool "jQuery keyboard"
-	select BR2_PACKAGE_JQUERY
 	select BR2_PACKAGE_JQUERY_UI
 	help
 	  Virtual Keyboard using jQuery UI
package/jquery-mobile/Config.in +1 -1
index fa31a36..b9d632f 100644
@@ -1,5 +1,5 @@
 config BR2_PACKAGE_JQUERY_MOBILE
-	bool "jquery-mobile"
+	bool "jQuery-mobile"
 	help
 	  jQuery-Mobile is a unified, HTML5-based user interface
 	  system for all popular mobile device platforms, built on the
package/jquery-sparkline/Config.in +0 -1
index ae66364..d656b45 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_SPARKLINE
 	bool "jQuery-Sparkline"
-	select BR2_PACKAGE_JQUERY
 	help
 	  This jQuery plugin generates sparklines (small inline
 	  charts) directly in the browser using data supplied either
package/jquery-ui/Config.in +0 -1
index f1653d5..4d755b6 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_UI
 	bool "jQuery UI"
-	select BR2_PACKAGE_JQUERY
 	help
 	  jQuery UI provides abstractions for low-level interaction and
 	  animation, advanced effects and high-level, themeable widgets,
package/jquery-validation/Config.in +0 -1
index ab2ee26..5d85756 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_VALIDATION
 	bool "jQuery-Validation"
-	select BR2_PACKAGE_JQUERY
 	help
 	  The jQuery Validation Plugin provides drop-in validation for
 	  your existing forms, while making all kinds of
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 jQuery: introduce external plugin menu

Yegor,

Quoted 4 lines · Yegor Yefremov

List all jQuery plugins in a dedicated menu and remove uneeded jQuery selection.

Signed-off-by Yegor Yefremov <[email protected]>

I'm fine with the principle, but I have some comments (see below);

package/jquery-datetimepicker/Config.in line 2

Quoted 9 lines
package/jquery-datetimepicker/Config.in +1 -2
index 6a07ec3..ae101ca 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_DATETIMEPICKER
-	bool "jquery-datetimepicker"
-	select BR2_PACKAGE_JQUERY
+	bool "jQuery-datetimepicker"

Please keep the lowercase name. I'd prefer to see the packages that do not conform to this principle to be changed to lowercase, rather than the opposite.

package/jquery-keyboard/Config.in line 2

Quoted 10 lines
package/jquery-datetimepicker/Config.in +0 -0
 	help
 	  Use this plugin to unobtrusively add a datetimepicker,
 	  datepicker or timepicker dropdown to your forms.
package/jquery-keyboard/Config.in +0 -0
index e44193e..3f7a486 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_KEYBOARD
 	bool "jQuery keyboard"

Change to lower-case.

package/jquery-mobile/Config.in line 2

Quoted 12 lines
package/jquery-keyboard/Config.in +0 -1
-	select BR2_PACKAGE_JQUERY
 	select BR2_PACKAGE_JQUERY_UI
 	help
 	  Virtual Keyboard using jQuery UI
package/jquery-mobile/Config.in +1 -1
index fa31a36..b9d632f 100644
@@ -1,5 +1,5 @@
 config BR2_PACKAGE_JQUERY_MOBILE
-	bool "jquery-mobile"
+	bool "jQuery-mobile"

Keep lowercase.

etc.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com