imagemagick depends on pango even if not available

Hi,
it seems imagemagick package does not force dependency on pango, but fails if it's not found.

$ git diff

package/imagemagick/imagemagick.mk +0 -0

index 1594f69..e8c7ab7 100644

Dear Mauro Condarelli,

Thanks for your contribution! See below for some comments/questions.

Quoted 2 lines · Mauro Condarelli

Hi,
it seems imagemagick package does not force dependency on pango, but fails if it's not found.

Can you give more details on how it fails?

Quoted 6 lines

$ git diff

package/imagemagick/imagemagick.mk +0 -0

index 1594f69..e8c7ab7 100644

package/imagemagick/imagemagick.mk else · line 52

Quoted 9 lines

package/imagemagick/imagemagick.mk +6 -0

@@ -44,6 +44,13 @@ else
   IMAGEMAGICK_CONF_OPTS += --without-fontconfig
   endif
 
+ifeq ($(BR2_PACKAGE_PANGO),y)
+IMAGEMAGICK_CONF_OPTS += --with-pango
+IMAGEMAGICK_DEPENDENCIES += pango
+else
+IMAGEMAGICK_CONF_OPTS += --without-pango
+endif

This patch is not making pango a mandatory dependency of imagemagick. It only makes it an optional dependency;

Again, can you give more details about the problem you're seeing?

The patch looks good (i.e pango is an optional dependency of imagemagick), but the description is not. Can you clarify?

Thanks!

Thoma

AFAIK pango is not mandatory to compile imagemagick, but without this patch imagemagick package would fail compilation if pango is not selected (either directly or because of other dependencies).
I.e.: to compile without pango it seem mandatory to explicitly pass " --without-pango" to imagemaagick's configure script; so we have two possibilities: either automatically select pango or do something along the lines of my patch (shamelessly adapted from other stances in imagemagick.mk). Does this clarify or did I misunderstand You?

AFAIK pango is not mandatory to compile imagemagick, but without this patch imagemagick package would fail compilation if pango is not selected (either directly or because of other dependencies).

Dear Mauro Condarelli,

Quoted 3 lines · Mauro Condarelli

AFAIK pango is not mandatory to compile imagemagick, but without this patch imagemagick package would fail compilation if pango is not selected (either directly or because of other dependencies).

Imagemagick without pango selected builds just fine here, and it's using pkg-config to detect pango, so I'm not quite sure how it could misdetect a host-installed pango on your system.

So, we'll really need the build output and config.log.

Thanks,

Thomas