Skip to contentSkip to conversation

haveged: for sparc we need generic clockgettime

PATCH Superseded Waldemar Brodkorb 2 participants 4 messages Aug 9, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 haveged: for sparc we need generic clockgettime

This fixes autobuilder error:
http://autobuild.buildroot.net/results/5b8bbc30f347140309ab2f81e1fe50f517356a3e/

As sparcv9 assembly is used, we need to enable generic clock_gettime for sparcv8 systems.

---
 package/haveged/haveged.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/haveged/haveged.mk +4 -0
index c68f766..489564a 100644
@@ -9,6 +9,10 @@ HAVEGED_SITE = http://www.issihosts.com/haveged
 HAVEGED_LICENSE = GPLv3+
 HAVEGED_LICENSE_FILES = COPYING
 
+ifeq ($(BR2_sparc),y)
+HAVEGED_CONF_OPTS += --enable-clock_gettime=yes
+endif
+
 define HAVEGED_INSTALL_INIT_SYSV
 	$(INSTALL) -m 755 -D package/haveged/S21haveged \
 		$(TARGET_DIR)/etc/init.d/S21haveged
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 haveged: for sparc we need generic clockgettime

Dear Waldemar Brodkorb,

Quoted 16 lines · Waldemar Brodkorb

This fixes autobuilder error:
http://autobuild.buildroot.net/results/5b8bbc30f347140309ab2f81e1fe50f517356a3e/

As sparcv9 assembly is used, we need to enable generic clock_gettime for sparcv8 systems.

---
 package/haveged/haveged.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/haveged/haveged.mk +0 -0
index c68f766..489564a 100644

package/haveged/haveged.mk HAVEGED_SITE = http://www.issihosts.com/haveged · line 12

Quoted 4 lines
package/haveged/haveged.mk +1 -0
@@ -9,6 +9,10 @@ HAVEGED_SITE = http://www.issihosts.com/haveged
 HAVEGED_LICENSE = GPLv3+
 HAVEGED_LICENSE_FILES = COPYING
 
+ifeq ($(BR2_sparc),y)

So this should be:

ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)

Right? We indeed don't support any SPARCv9 at the moment, but it's probably better to be more specific. What do you think?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 haveged: for sparc we need generic clockgettime

Hi,
Thomas Petazzoni wrote,

Quoted 22 lines

Dear Waldemar Brodkorb,

Quoted 19 lines · Waldemar Brodkorb

This fixes autobuilder error:
http://autobuild.buildroot.net/results/5b8bbc30f347140309ab2f81e1fe50f517356a3e/

As sparcv9 assembly is used, we need to enable generic clock_gettime for sparcv8 systems.

---
 package/haveged/haveged.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/haveged/haveged.mk +0 -0
index c68f766..489564a 100644
@@ -9,6 +9,10 @@ HAVEGED_SITE = http://www.issihosts.com/haveged
 HAVEGED_LICENSE = GPLv3+
 HAVEGED_LICENSE_FILES = COPYING
 
Quoted 8 lines

package/haveged/haveged.mk HAVEGED_SITE = http://www.issihosts.com/haveged · line 12

Quoted 1 line
package/haveged/haveged.mk +1 -0
+ifeq ($(BR2_sparc),y)

So this should be:

ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)

Right? We indeed don't support any SPARCv9 at the moment, but it's probably better to be more specific. What do you think?

Right. Are you interested in sparc64 qemu defconfigs after release?

best regards
Waldemar

#3 lore raw

PATCH 1/1 haveged: for sparc we need generic clockgettime

Dear Waldemar Brodkorb,

Quoted 8 lines · Waldemar Brodkorb
Quoted 6 lines

So this should be:

ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)

Right? We indeed don't support any SPARCv9 at the moment, but it's probably better to be more specific. What do you think?

Right.

Ok, I'll apply with this change.

Quoted 1 line

Are you interested in sparc64 qemu defconfigs after release?

Yes, sure. No need to wait after the release if these are ready. The next branch is opened, I can merge new stuff.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com