Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c

PATCH In review Bhaktipriya Shridhar 2 participants 2 messages Aug 9, 2015 – Aug 10, 2015 Staging

lore

Share & tools

lore

Bhaktipriya Shridhar

author

2015-08-09 12:45 UTC #0 lore raw

PATCH 1/1 Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c

Fixed coding style issue "warning line over 80 characters" detected by checkpatch.pl in dgnc_mgmt.c

---
 drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/staging/dgnc/dgnc_mgmt.c +2 -1

index b13318a..e8fd3da 100644
@@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 		di.info_bdstate = dgnc_Board[brd]->dpastatus;
 		di.info_ioport = 0;
 		di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
-		di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
+		di.info_physsize = (ulong) dgnc_Board[brd]->membase -
+			dgnc_Board[brd]->membase_end;
 		if (dgnc_Board[brd]->state != BOARD_FAILED)
 			di.info_nports = dgnc_Board[brd]->nasync;
 		else

Signature · 1 line

1.9.1

Dan Carpenter

2015-08-10 09:41 UTC #1 lore raw

Quoted 2 lines · Bhaktipriya Shridhar

Fixed coding style issue "warning line over 80 characters" detected by checkpatch.pl in dgnc_mgmt.c

No signed off by.

Quoted 9 lines

---
 drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/staging/dgnc/dgnc_mgmt.c +0 -0

index b13318a..e8fd3da 100644

drivers/staging/dgnc/dgnc_mgmt.c long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) · line 152

Quoted 6 lines

drivers/staging/dgnc/dgnc_mgmt.c +2 -1

@@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 		di.info_bdstate = dgnc_Board[brd]->dpastatus;
 		di.info_ioport = 0;
 		di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
-		di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
+		di.info_physsize = (ulong) dgnc_Board[brd]->membase -
+			dgnc_Board[brd]->membase_end;

Better to align it like:

		di.info_physsize = (ulong)dgnc_Board[brd]->membase -
					  dgnc_Board[brd]->membase_end;

But even better would be to rename brd to brd_idx and introduce a new "struct dgnc_board *brd" variable and set:

	brd = dgnc_Board[brd_idx];

Then replace ever reference to "dgnc_Board[brd]" with just "brd".

regards,
dan carpenter