tools: mxsboot: calculate ECC block level dynamically

PATCH New Jörg Krause 3 participants 4 messages Aug 11, 2015 – Aug 12, 2015 Arm i.MX and Layerscape

Share & tools

Jörg Krause

author

2015-08-11 11:44 UTC #0 lore raw

PATCH 1/1 tools: mxsboot: calculate ECC block level dynamically

For pages of 2048 bytes the current setting of the ECC Error Correction Level is only true for an oob size of 64 bytes and wrong for all others.

Instead of hard-coding every possible combination of page size and oob size use the dynamic calculation of the ECC strength introduced in commit 6121560d7714d6d8e41ce1687a1388a1a8fea4cb.

Cc Marek Vasut <[email protected]>

Signed-off-by J?rg Krause <[email protected]>

---
 tools/mxsboot.c | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

tools/mxsboot.c +4 ~~-17~~

index 185b327..15eec91 100644
@@ -271,23 +271,10 @@ static struct mx28_nand_fcb *mx28_nand_get_fcb(uint32_t size)
 	fcb->ecc_block_0_size =		512;
 	fcb->ecc_block_n_size =		512;
 	fcb->metadata_bytes =		10;
-
-	if (nand_writesize == 2048) {
-		fcb->ecc_block_n_ecc_type =		4;
-		fcb->ecc_block_0_ecc_type =		4;
-	} else if (nand_writesize == 4096) {
-		if (nand_oobsize == 128) {
-			fcb->ecc_block_n_ecc_type =	4;
-			fcb->ecc_block_0_ecc_type =	4;
-		} else if (nand_oobsize == 218) {
-			fcb->ecc_block_n_ecc_type =	8;
-			fcb->ecc_block_0_ecc_type =	8;
-		} else if (nand_oobsize == 224) {
-			fcb->ecc_block_n_ecc_type =	8;
-			fcb->ecc_block_0_ecc_type =	8;
-		}
-	}
-
+	fcb->ecc_block_n_ecc_type = mx28_nand_get_ecc_strength(
+					nand_writesize, nand_oobsize) >> 1;
+	fcb->ecc_block_0_ecc_type = mx28_nand_get_ecc_strength(
+					nand_writesize, nand_oobsize) >> 1;
 	if (fcb->ecc_block_n_ecc_type == 0) {
 		printf("MX28 NAND: Unsupported NAND geometry\n");
 		goto err;

Signature · 1 line

2.5.0

Marek Vasut

2015-08-11 11:51 UTC #1 lore raw

PATCH 1/1 tools: mxsboot: calculate ECC block level dynamically

Quoted 9 lines · J?rg Krause

For pages of 2048 bytes the current setting of the ECC Error Correction Level is only true for an oob size of 64 bytes and wrong for all others.
Instead of hard-coding every possible combination of page size and oob size use the dynamic calculation of the ECC strength introduced in commit 6121560d7714d6d8e41ce1687a1388a1a8fea4cb.
Cc Marek Vasut <[email protected]>
Signed-off-by J?rg Krause <[email protected]>

Acked-by Marek Vasut <[email protected]>

Best regards,
Marek Vasut

Stefano Babic

2015-08-12 15:38 UTC #2 lore raw

PATCH 1/1 tools: mxsboot: calculate ECC block level dynamically

Quoted 8 lines · Marek Vasut

Quoted 7 lines · J?rg Krause
For pages of 2048 bytes the current setting of the ECC Error Correction Level is only true for an oob size of 64 bytes and wrong for all others.
Instead of hard-coding every possible combination of page size and oob size use the dynamic calculation of the ECC strength introduced in commit 6121560d7714d6d8e41ce1687a1388a1a8fea4cb.

Quoted 8 lines

Quoted 2 lines
Cc Marek Vasut <[email protected]>
Signed-off-by J?rg Krause <[email protected]>
Acked-by Marek Vasut <[email protected]>
Best regards,
Marek Vasut

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Stefano Babic

2015-08-11 12:10 UTC #3 lore raw

PATCH 1/1 tools: mxsboot: calculate ECC block level dynamically

In reply to Jörg Krause

Quoted 36 lines · J?rg Krause

For pages of 2048 bytes the current setting of the ECC Error Correction Level is only true for an oob size of 64 bytes and wrong for all others.
Instead of hard-coding every possible combination of page size and oob size use the dynamic calculation of the ECC strength introduced in commit 6121560d7714d6d8e41ce1687a1388a1a8fea4cb.
Cc Marek Vasut <[email protected]>
Signed-off-by J?rg Krause <[email protected]>
---
 tools/mxsboot.c | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)
tools/mxsboot.c +0 ~~-14~~
index 185b327..15eec91 100644
@@ -271,23 +271,10 @@ static struct mx28_nand_fcb *mx28_nand_get_fcb(uint32_t size)
 	fcb->ecc_block_0_size =		512;
 	fcb->ecc_block_n_size =		512;
 	fcb->metadata_bytes =		10;
-
-	if (nand_writesize == 2048) {
-		fcb->ecc_block_n_ecc_type =		4;
-		fcb->ecc_block_0_ecc_type =		4;
-	} else if (nand_writesize == 4096) {
-		if (nand_oobsize == 128) {
-			fcb->ecc_block_n_ecc_type =	4;
-			fcb->ecc_block_0_ecc_type =	4;
-		} else if (nand_oobsize == 218) {
-			fcb->ecc_block_n_ecc_type =	8;
-			fcb->ecc_block_0_ecc_type =	8;
-		} else if (nand_oobsize == 224) {
-			fcb->ecc_block_n_ecc_type =	8;
-			fcb->ecc_block_0_ecc_type =	8;

tools/mxsboot.c static struct mx28_nand_fcb *mx28_nand_get_fcb(uint32_t size) · line 280

Quoted 10 lines

tools/mxsboot.c +4 -3

-		}
-	}
-
+	fcb->ecc_block_n_ecc_type = mx28_nand_get_ecc_strength(
+					nand_writesize, nand_oobsize) >> 1;
+	fcb->ecc_block_0_ecc_type = mx28_nand_get_ecc_strength(
+					nand_writesize, nand_oobsize) >> 1;
 	if (fcb->ecc_block_n_ecc_type == 0) {
 		printf("MX28 NAND: Unsupported NAND geometry\n");
 		goto err;

Reviewed-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================