mmc: imx: a few fixes and new feature
Subsystems (5)
v6 cover mmc: imx: a few fixes and new feature
Changes for v6:
-remove duplicate code in esdhc_set_uhs_signaling(). -fix a typo for patch-2.
-make commit log of patch-3 more specific.
Haibo Chen (6):
mmc: sdhci-esdhc-imx: add imx7d support and support HS400
mmc: sdhci-esdhc-imx: add tuning-step setting support
mmc: sdhci-esdhc-imx: add imx7d support in bingding doc
ARM: dts: imx7d-sdb: add eMMC5.0 support
mmc: sdhci-esdhc-imx: set back the burst_length_enable bit to 1
mmc: sdhci-esdhc-imx: change default watermark level and burst length
.../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 6 ++ arch/arm/boot/dts/imx7d-sdb.dts | 13 +++ drivers/mmc/host/sdhci-esdhc-imx.c | 114 ++++++++++++++++++++- include/linux/platform_data/mmc-esdhc-imx.h | 1 + 4 files changed, 130 insertions(+), 4 deletions(-)
Signature · 1 line
1.9.1
PATCH v6 1/6 mmc: sdhci-esdhc-imx: add imx7d support and support HS400
The imx7d usdhc is derived from imx6sx, the difference is that imx7d support HS400.
So introduce a new compatible string for imx7d and add HS400 support for imx7d usdhc.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 86 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 83 insertions(+), 3 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +83 -3
@@ -44,6 +44,7 @@#define ESDHC_MIX_CTRL_EXE_TUNE (1 << 22)#define ESDHC_MIX_CTRL_SMPCLK_SEL (1 << 23)#define ESDHC_MIX_CTRL_FBCLK_SEL (1 << 25) +#define ESDHC_MIX_CTRL_HS400_EN (1 << 26)/* Bits 3 and 6 are not SDHCI standard definitions */ #define ESDHC_MIX_CTRL_SDHCI_MASK 0xb7/* Tuning bits */
@@ -60,6 +61,16 @@#define ESDHC_TUNE_CTRL_MIN 0#define ESDHC_TUNE_CTRL_MAX ((1 << 7) - 1) +/* strobe dll register */ +#define ESDHC_STROBE_DLL_CTRL 0x70 +#define ESDHC_STROBE_DLL_CTRL_ENABLE (1 << 0) +#define ESDHC_STROBE_DLL_CTRL_RESET (1 << 1) +#define ESDHC_STROBE_DLL_CTRL_SLV_DLY_TARGET_SHIFT 3 + +#define ESDHC_STROBE_DLL_STATUS 0x74 +#define ESDHC_STROBE_DLL_STS_REF_LOCK (1 << 1) +#define ESDHC_STROBE_DLL_STS_SLV_LOCK 0x1 +#define ESDHC_TUNING_CTRL 0xcc#define ESDHC_STD_TUNING_EN (1 << 24)/* NOTE: the minimum valid tuning start tap for mx6sl is 1 */
@@ -120,6 +131,11 @@#define ESDHC_FLAG_ERR004536 BIT(7)/* The IP supports HS200 mode */ #define ESDHC_FLAG_HS200 BIT(8) +/* The IP supports HS400 mode */ +#define ESDHC_FLAG_HS400 BIT(9) + +/* A higher clock ferquency than this rate requires strobell dll control */ +#define ESDHC_STROBE_DLL_CLK_FREQ 100000000struct esdhc_soc_data {u32 flags;
@@ -156,6 +172,12 @@ static struct esdhc_soc_data usdhc_imx6sx_data = { | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200, }; +static struct esdhc_soc_data usdhc_imx7d_data = { + .flags =ESDHC_FLAG_USDHC |ESDHC_FLAG_STD_TUNING + |ESDHC_FLAG_HAVE_CAP1 |ESDHC_FLAG_HS200 + |ESDHC_FLAG_HS400 , +}; +struct pltfm_imx_data {u32 scratchpad;struct pinctrl *pinctrl;
@@ -199,6 +221,7 @@ static const struct of_device_id imx_esdhc_dt_ids[] = { { .compatible = "fsl,imx6sx-usdhc", .data = &usdhc_imx6sx_data, }, { .compatible = "fsl,imx6sl-usdhc", .data = &usdhc_imx6sl_data, }, { .compatible = "fsl,imx6q-usdhc", .data = &usdhc_imx6q_data, }, + { .compatible = "fsl,imx7d-usdhc", .data = &usdhc_imx7d_data, }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, imx_esdhc_dt_ids);
@@ -274,6 +297,9 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg) val =SDHCI_SUPPORT_DDR50 |SDHCI_SUPPORT_SDR104 |SDHCI_SUPPORT_SDR50 |SDHCI_USE_SDR50_TUNING ; + +if (imx_data->socdata->flags &ESDHC_FLAG_HS400 ) + val |=SDHCI_SUPPORT_HS400 ; } }
@@ -774,6 +800,7 @@ static int esdhc_change_pinstate(struct sdhci_host *host,break ;case MMC_TIMING_UHS_SDR104 :case MMC_TIMING_MMC_HS200 : +case MMC_TIMING_MMC_HS400 : pinctrl = imx_data->pins_200mhz;break ;default :
@@ -784,24 +811,68 @@ static int esdhc_change_pinstate(struct sdhci_host *host,return pinctrl_select_state (imx_data->pinctrl, pinctrl); } +/* +* For HS400 eMMC, there is a data_strobe line, this signal is generated +* by the device and used for data output and CRC status response output +* in HS400 mode. The frequency of this signal follows the frequency of +* CLK generated by host. Host receive the data which is aligned to the +* edge of data_strobe line. Due to the time delay between CLK line and +* data_strobe line, if the delay time is larger than one clock cycle, +* then CLK and data_strobe line will misaligned, read error shows up. +* So when the CLK is higher than 100MHz, each clock cycle is short enough, +* host should config the delay target. +*/ +static void esdhc_set_strobe_dll (struct sdhci_host *host) +{ +u32 v; + +if (host->mmc->actual_clock >ESDHC_STROBE_DLL_CLK_FREQ ) { +/* force a reset on strobe dll */ +writel (ESDHC_STROBE_DLL_CTRL_RESET , + host->ioaddr +ESDHC_STROBE_DLL_CTRL ); +/* +* enable strobe dll ctrl and adjust the delay target +* for the uSDHC loopback read clock +*/ + v =ESDHC_STROBE_DLL_CTRL_ENABLE | + (7 <<ESDHC_STROBE_DLL_CTRL_SLV_DLY_TARGET_SHIFT ); +writel (v, host->ioaddr +ESDHC_STROBE_DLL_CTRL ); +/* wait 1us to make sure strobe dll status register stable */ +udelay (1 ); + v =readl (host->ioaddr +ESDHC_STROBE_DLL_STATUS ); +if (!(v &ESDHC_STROBE_DLL_STS_REF_LOCK )) +dev_warn (mmc_dev (host->mmc), +"warning! HS400 strobe DLL status REF not lock!\n" ); +if (!(v &ESDHC_STROBE_DLL_STS_SLV_LOCK )) +dev_warn (mmc_dev (host->mmc), +"warning! HS400 strobe DLL status SLV not lock!\n" ); + } +} +static void esdhc_set_uhs_signaling (struct sdhci_host *host,unsigned timing) { +u32 m;struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host);struct pltfm_imx_data *imx_data = pltfm_host->priv;struct esdhc_platform_data *boarddata = &imx_data->boarddata; +/* disable ddr mode and disable HS400 mode */ + m =readl (host->ioaddr +ESDHC_MIX_CTRL ); + m &= ~(ESDHC_MIX_CTRL_DDREN |ESDHC_MIX_CTRL_HS400_EN ); + imx_data->is_ddr =0 ; +switch (timing) {case MMC_TIMING_UHS_SDR12 :case MMC_TIMING_UHS_SDR25 :case MMC_TIMING_UHS_SDR50 :case MMC_TIMING_UHS_SDR104 :case MMC_TIMING_MMC_HS200 : +writel (m, host->ioaddr +ESDHC_MIX_CTRL );break ;case MMC_TIMING_UHS_DDR50 :case MMC_TIMING_MMC_DDR52 : -writel (readl (host->ioaddr +ESDHC_MIX_CTRL ) | -ESDHC_MIX_CTRL_DDREN , - host->ioaddr +ESDHC_MIX_CTRL ); + m |=ESDHC_MIX_CTRL_DDREN ; +writel (m, host->ioaddr +ESDHC_MIX_CTRL ); imx_data->is_ddr =1 ;if (boarddata->delay_line) {u32 v;
@@ -813,6 +884,12 @@ static void esdhc_set_uhs_signaling(struct sdhci_host *host, unsigned timing)writel (v, host->ioaddr +ESDHC_DLL_CTRL ); }break ; +case MMC_TIMING_MMC_HS400 : + m |=ESDHC_MIX_CTRL_DDREN |ESDHC_MIX_CTRL_HS400_EN ; +writel (m, host->ioaddr +ESDHC_MIX_CTRL ); + imx_data->is_ddr =1 ; +esdhc_set_strobe_dll (host); +break ; }esdhc_change_pinstate (host, timing);
@@ -1100,6 +1177,9 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)if (imx_data->socdata->flags &ESDHC_FLAG_ERR004536 ) host->quirks |=SDHCI_QUIRK_BROKEN_ADMA ; +if (imx_data->socdata->flags &ESDHC_FLAG_HS400 ) + host->quirks2 |=SDHCI_QUIRK2_CAPS_BIT63_FOR_HS400 ; +if (of_id) err =sdhci_esdhc_imx_probe_dt (pdev, host, imx_data);else
Signature · 1 line
1.9.1
PATCH v6 2/6 mmc: sdhci-esdhc-imx: add tuning-step setting support
In reply to Haibo Chentuning-step is the delay cell steps in tuning procedure. The default value of tuning-step is 1. Some boards or cards need another value to pass the tuning procedure. For example, imx7d-sdb board need the tuning-step value as 2, otherwise it can't pass the tuning procedure.
So this patch add the tuning-step setting in driver, so that user can set the tuning-step value in dts.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 9 +++++++++ include/linux/platform_data/mmc-esdhc-imx.h | 1 + 2 files changed, 10 insertions(+)
drivers/mmc/host/sdhci-esdhc-imx.c +9 -0
@@ -75,6 +75,7 @@#define ESDHC_STD_TUNING_EN (1 << 24)/* NOTE: the minimum valid tuning start tap for mx6sl is 1 */ #define ESDHC_TUNING_START_TAP 0x1 +#define ESDHC_TUNING_STEP_SHIFT 16/* pinctrl state */ #define ESDHC_PINCTRL_STATE_100MHZ "state_100mhz"
@@ -474,6 +475,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg) }else if (imx_data->socdata->flags &ESDHC_FLAG_STD_TUNING ) {u32 v =readl (host->ioaddr +SDHCI_ACMD12_ERR );u32 m =readl (host->ioaddr +ESDHC_MIX_CTRL ); +u32 tuning_ctrl;if (val &SDHCI_CTRL_TUNED_CLK ) { v |=ESDHC_MIX_CTRL_SMPCLK_SEL ; }else {
@@ -484,6 +486,11 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)if (val &SDHCI_CTRL_EXEC_TUNING ) { v |=ESDHC_MIX_CTRL_EXE_TUNE ; m |=ESDHC_MIX_CTRL_FBCLK_SEL ; + tuning_ctrl =readl (host->ioaddr +ESDHC_TUNING_CTRL ); + tuning_ctrl |=ESDHC_STD_TUNING_EN |ESDHC_TUNING_START_TAP ; +if (imx_data->boarddata.tuning_step) + tuning_ctrl |= imx_data->boarddata.tuning_step <<ESDHC_TUNING_STEP_SHIFT ; +writel (tuning_ctrl, host->ioaddr +ESDHC_TUNING_CTRL ); }else { v &= ~ESDHC_MIX_CTRL_EXE_TUNE ; }
@@ -963,6 +970,8 @@ sdhci_esdhc_imx_probe_dt(struct platform_device *pdev,if (gpio_is_valid (boarddata->wp_gpio)) boarddata->wp_type =ESDHC_WP_GPIO ; +of_property_read_u32 (np,"fsl,tuning-step" , &boarddata->tuning_step); +if (of_find_property (np,"no-1-8-v" ,NULL )) boarddata->support_vsel = false;else
include/linux/platform_data/mmc-esdhc-imx.h +1 -0
@@ -45,5 +45,6 @@ struct esdhc_platform_data {int max_bus_width;bool support_vsel;unsigned int delay_line; + unsigned int tuning_step; /* The delay cell steps in tuning procedure */ };#endif /* __ASM_ARCH_IMX_ESDHC_H */
Signature · 1 line
1.9.1
PATCH v6 3/6 mmc: sdhci-esdhc-imx: add imx7d support in bingding doc
In reply to Haibo ChenAdd a required property "fsl,imx7d-usdhc" in binding doc. Add an optional property "fsl,tuning-step" in binding doc.
--- Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt +6 -0
@@ -15,6 +15,7 @@ Required properties: "fsl,imx6q-usdhc" "fsl,imx6sl-usdhc" "fsl,imx6sx-usdhc" + "fsl,imx7d-usdhc" Optional properties: - fsl,wp-controller : Indicate to use controller internal write protection
@@ -27,6 +28,11 @@ Optional properties: transparent level shifters on the outputs of the controller. Two cells are required, first cell specifies minimum slot voltage (mV), second cell specifies maximum slot voltage (mV). Several ranges could be specified. +- fsl,tuning-step: Specify the increasing delay cell steps in tuning procedure. + The uSDHC use one delay cell as default increasing step to do tuning process. + This property allows user to change the tuning step to more than one delay + cells which is useful for some special boards or cards when the default + tuning step can't find the proper delay window within limited tuning retries. Examples:
Signature · 1 line
1.9.1
PATCH v6 4/6 ARM: dts: imx7d-sdb: add eMMC5.0 support
In reply to Haibo Chenimx7d-sdb board has a eMMC5.0 on usdhc3. This eMMC support HS400. This patch add usdhc3 support for HS400
--- arch/arm/boot/dts/imx7d-sdb.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/imx7d-sdb.dts +13 -0
@@ -241,6 +241,19 @@ status = "okay"; }; +&usdhc3 { + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc3>; + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; + assigned-clocks = <&clks IMX7D_USDHC3_ROOT_CLK>; + assigned-clock-rates = <400000000>; + bus-width = <8>; + fsl,tuning-step = <2>; + non-removable; + status = "okay"; +}; + &iomuxc { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_hog>;
Signature · 1 line
1.9.1
Shawn Guo
AppliedRe: [PATCH v6 4/6] ARM: dts: imx7d-sdb: add eMMC5.0 support
Quoted 4 lines · Haibo Chen
imx7d-sdb board has a eMMC5.0 on usdhc3. This eMMC support HS400. This patch add usdhc3 support for HS400
Signed-off-by Haibo Chen <[email protected]>
Applied, thanks.
PATCH v6 5/6 mmc: sdhci-esdhc-imx: set back the burst_length_enable bit to 1
In reply to Haibo ChenCurrently we find that if a usdhc is choosed to boot system, then ROM code will set the burst length enable bit of this usdhc as 0.
This will make performance drop a lot if this usdhc's burst length is configed. So this patch set back the burst_length_enable bit as 1, which is the default value, and means burst length is enabled for INCR.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/mmc/host/sdhci-esdhc-imx.c +16 -0
@@ -32,6 +32,7 @@#include "sdhci-esdhc.h" #define ESDHC_CTRL_D3CD 0x08 +#define ESDHC_BURST_LEN_EN_INCR (1 << 27)/* VENDOR SPEC register */ #define ESDHC_VENDOR_SPEC 0xc0#define ESDHC_VENDOR_SPEC_SDIO_QUIRK (1 << 1)
@@ -1163,6 +1164,21 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) host->quirks2 |=SDHCI_QUIRK2_PRESET_VALUE_BROKEN ; host->mmc->caps |=MMC_CAP_1_8V_DDR ; +/* +* ROM code will change the bit burst_length_enable setting +* to zero if this usdhc is choosed to boot system. Change +* it back here, otherwise it will impact the performance a +* lot. This bit is used to enable/disable the burst length +* for the external AHB2AXI bridge, it's usefully especially +* for INCR transfer because without burst length indicator, +* the AHB2AXI bridge does not know the burst length in +* advance. And without burst length indicator, AHB INCR +* transfer can only be converted to singles on the AXI side. +*/ +writel (readl (host->ioaddr +SDHCI_HOST_CONTROL ) + |ESDHC_BURST_LEN_EN_INCR , + host->ioaddr +SDHCI_HOST_CONTROL ); +if (!(imx_data->socdata->flags &ESDHC_FLAG_HS200 )) host->quirks2 |=SDHCI_QUIRK2_BROKEN_HS200 ;
Signature · 1 line
1.9.1
PATCH v6 6/6 mmc: sdhci-esdhc-imx: change default watermark level and burst length
In reply to Haibo ChenBy default, for all imx SoC types, the watermark level is 16, and the burst length is 8. But if the SDIO/SD/MMC I/O speed is fast enough, this default watermark level and burst length will be the performance bottleneck.
For example, i.MX7D support eMMC HS400 mode, this mode can run in 8 bit, 200MHZ DDR mode. So the I/O speed improve a lot compare to SD3.0. The default burst length is 8, if we don't change this value, in HS400 mode, when we do eMMC read operation, we can find that the clock signal will stop for a period of time. This means the speed of data moving on AHB bus is slower than I/O speed. So we should improve the speed of data moving on AHB bus.
This patch set the default burst length as 16, and set the default watermark level as 64. The test result is the clock signal has no stop during the eMMC HS400 operation.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-esdhc-imx.c +2 -1
@@ -1160,7 +1160,8 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)* to something insane. Change it back here. */ if (esdhc_is_usdhc (imx_data)) { -writel (0x08100810 , host->ioaddr +ESDHC_WTMK_LVL ); +writel (0x10401040 , host->ioaddr +ESDHC_WTMK_LVL ); + host->quirks2 |=SDHCI_QUIRK2_PRESET_VALUE_BROKEN ; host->mmc->caps |=MMC_CAP_1_8V_DDR ;
Signature · 1 line
1.9.1
Quoted 13 lines · Haibo Chen
Changes for v6:
(quoted diff) +0
-3-remove duplicate code in esdhc_set_uhs_signaling(). -fix a typo for patch-2. -make commit log of patch-3 more specific.Haibo Chen (6):
mmc: sdhci-esdhc-imx: add imx7d support and support HS400
mmc: sdhci-esdhc-imx: add tuning-step setting support
mmc: sdhci-esdhc-imx: add imx7d support in bingding doc
ARM: dts: imx7d-sdb: add eMMC5.0 support
mmc: sdhci-esdhc-imx: set back theburst_length_enablebit to 1
mmc: sdhci-esdhc-imx: change default watermark level and burst length
Quoted 9 lines
.../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 6 ++ arch/arm/boot/dts/imx7d-sdb.dts | 13 +++ drivers/mmc/host/sdhci-esdhc-imx.c | 114 ++++++++++++++++++++- include/linux/platform_data/mmc-esdhc-imx.h | 1 + 4 files changed, 130 insertions(+), 4 deletions(-)Signature · 1 line
1.9.1
The patch set looks good to me.
Regards
Dong Aisheng
Quoted 26 lines · Dong Aisheng
Quoted 13 lines · Haibo Chen
Changes for v6:
(quoted diff) +0
-3-remove duplicate code in esdhc_set_uhs_signaling(). -fix a typo for patch-2. -make commit log of patch-3 more specific.Haibo Chen (6):
mmc: sdhci-esdhc-imx: add imx7d support and support HS400
mmc: sdhci-esdhc-imx: add tuning-step setting support
mmc: sdhci-esdhc-imx: add imx7d support in bingding doc
ARM: dts: imx7d-sdb: add eMMC5.0 support
mmc: sdhci-esdhc-imx: set back theburst_length_enablebit to 1
mmc: sdhci-esdhc-imx: change default watermark level and burst lengthQuoted 9 lines
.../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 6 ++ arch/arm/boot/dts/imx7d-sdb.dts | 13 +++ drivers/mmc/host/sdhci-esdhc-imx.c | 114 ++++++++++++++++++++- include/linux/platform_data/mmc-esdhc-imx.h | 1 + 4 files changed, 130 insertions(+), 4 deletions(-)Signature · 1 line
1.9.1The patch set looks good to me.
Quoted 4 lines
Acked-by Dong Aisheng <[email protected]>Regards
Dong Aisheng
Hi Ulf,
Can you help pull these patches into your branch?
Best regards
Haibo
Quoted 13 lines · Haibo Chen
Changes for v6:
(quoted diff) +0
-3-remove duplicate code in esdhc_set_uhs_signaling(). -fix a typo for patch-2. -make commit log of patch-3 more specific.Haibo Chen (6):
mmc: sdhci-esdhc-imx: add imx7d support and support HS400
mmc: sdhci-esdhc-imx: add tuning-step setting support
mmc: sdhci-esdhc-imx: add imx7d support in bingding doc
ARM: dts: imx7d-sdb: add eMMC5.0 support
mmc: sdhci-esdhc-imx: set back theburst_length_enablebit to 1
mmc: sdhci-esdhc-imx: change default watermark level and burst length
Quoted 9 lines
.../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 6 ++ arch/arm/boot/dts/imx7d-sdb.dts | 13 +++ drivers/mmc/host/sdhci-esdhc-imx.c | 114 ++++++++++++++++++++- include/linux/platform_data/mmc-esdhc-imx.h | 1 + 4 files changed, 130 insertions(+), 4 deletions(-)--
1.9.1
I have applied this for next - except patch4 as it needs and ack from the IMX SOC maintainer, or it may be better to take that patch through ARM soc...
Regarding patch3, which document the new bindings and the compatible string, I moved this to be the first patch and fixed the spelling of the commit message header.
Thanks!
Kind regards
Uffe
v6 cover mmc: imx: a few fixes and new feature
Thanks? Uffe.
Hi Shawn and Sascha,
Can you help pull the patch4 in your branch?
Best Regards
Haibo Chen
Quoted 49 lines
-----Original Message-----
From: Ulf Hansson [mailto:ulf.hansson at linaro.org]
Sent: Tuesday, August 25, 2015 8:06 PM
To: Chen Haibo-B51421
Cc: Rob Herring; Pawe? Moll; Mark Rutland; Ian Campbell; Kumar Gala; Shawn Guo; Sascha Hauer; Russell King - ARM Linux; Dong Aisheng-B29396; Johan Derycke; Marc Kleine-Budde; Estevam Fabio-R49496; devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm- kernel at lists.infradead.org; linux-mmc
Subject: Re: [PATCH v6 0/6] mmc: imx: a few fixes and new featureQuoted 14 lines · Haibo Chen
Changes for v6:
(quoted diff) +0
-3-remove duplicate code in esdhc_set_uhs_signaling(). -fix a typo for patch-2. -make commit log of patch-3 more specific.Haibo Chen (6):
mmc: sdhci-esdhc-imx: add imx7d support and support HS400
mmc: sdhci-esdhc-imx: add tuning-step setting support
mmc: sdhci-esdhc-imx: add imx7d support in bingding doc
ARM: dts: imx7d-sdb: add eMMC5.0 support
mmc: sdhci-esdhc-imx: set back theburst_length_enablebit to 1
mmc: sdhci-esdhc-imx: change default watermark level and burst
lengthQuoted 3 lines
.../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 6 ++ arch/arm/boot/dts/imx7d-sdb.dts | 13 +++ drivers/mmc/host/sdhci-esdhc-imx.c | 114++++++++++++++++++++-
Quoted 6 lines
include/linux/platform_data/mmc-esdhc-imx.h | 1 + 4 files changed, 130 insertions(+), 4 deletions(-)--
1.9.1I have applied this for next - except patch4 as it needs and ack from the IMX SOC maintainer, or it may be better to take that patch through ARM soc...
Regarding patch3, which document the new bindings and the compatible string, I moved this to be the first patch and fixed the spelling of the commit message header.
Thanks!
Kind regards
Uffe