Skip to contentSkip to conversation

msmtp: don't try to use IDN feature

PATCH New Anthony Viallard 2 participants 4 messages Aug 13, 2015

lore
Share & tools
lore

Anthony Viallard

author
#0 lore raw

PATCH 1/1 msmtp: don't try to use IDN feature

Signed-off-by Anthony Viallard <[email protected]>
---
 package/msmtp/msmtp.mk | 1 +
 1 file changed, 1 insertion(+)
package/msmtp/msmtp.mk +1 -0
index bff2620..7c8261e 100644
@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
 MSMTP_DEPENDENCIES = host-pkgconf
 MSMTP_CONF_OPTS = \
 	--without-libidn \
+	--disable-gai-idn \
 	--without-libgsasl
 MSMTP_LICENSE = GPLv3+
 MSMTP_LICENSE_FILES = COPYING
Signature · 1 line
2.4.6
#1 lore raw

PATCH 1/1 msmtp: don't try to use IDN feature

Hi Anthony,

Quoted 10 lines · Anthony Viallard
Signed-off-by Anthony Viallard <[email protected]>
---
 package/msmtp/msmtp.mk | 1 +
 1 file changed, 1 insertion(+)
package/msmtp/msmtp.mk +0 -0
index bff2620..7c8261e 100644

package/msmtp/msmtp.mk MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz · line 13

Quoted 4 lines
package/msmtp/msmtp.mk +1 -0
@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
 MSMTP_DEPENDENCIES = host-pkgconf
 MSMTP_CONF_OPTS = \
 	--without-libidn \
+	--disable-gai-idn \

Please explain why in the commit log. Does it break at build time, run time, something else?

package/msmtp/msmtp.mk MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz · line 16

Quoted 3 lines
package/msmtp/msmtp.mk +0 -0
 	--without-libgsasl
 MSMTP_LICENSE = GPLv3+
 MSMTP_LICENSE_FILES = COPYING

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#2 lore raw

PATCH 1/1 msmtp: don't try to use IDN feature

In reply to Anthony Viallard
Quoted 11 lines · Anthony Viallard
Signed-off-by Anthony Viallard <[email protected]>
---
  package/msmtp/msmtp.mk | 1 +
  1 file changed, 1 insertion(+)
package/msmtp/msmtp.mk +0 -0
index bff2620..7c8261e 100644

package/msmtp/msmtp.mk MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz · line 16

Quoted 7 lines
package/msmtp/msmtp.mk +1 -0
@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
  MSMTP_DEPENDENCIES = host-pkgconf
  MSMTP_CONF_OPTS = \
  	--without-libidn \
+	--disable-gai-idn \
  	--without-libgsasl
  MSMTP_LICENSE = GPLv3+
  MSMTP_LICENSE_FILES = COPYING

Hi buildroot guys,

I don't known if there is a consensus about IDN usage for buildroot. I didn't see an option in the config about it. I presume IDN should be disabled for all package, am I right ?

autoconf can't see if AI_IDN is really supported
(http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
It seems weird but this is the case apparently.

Before I did the above patch, msmtp failed to send mail. The output was:

msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags

Regards,
Anthony.

#3 lore raw

PATCH 1/1 msmtp: don't try to use IDN feature

Hi Anthony,

Quoted 23 lines · Viallard Anthony
Quoted 10 lines · Anthony Viallard
Signed-off-by Anthony Viallard <[email protected]>
---
 package/msmtp/msmtp.mk | 1 +
 1 file changed, 1 insertion(+)
package/msmtp/msmtp.mk +0 -0
index bff2620..7c8261e 100644

package/msmtp/msmtp.mk MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz · line 16

Quoted 7 lines
package/msmtp/msmtp.mk +1 -0
@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
 MSMTP_DEPENDENCIES = host-pkgconf
 MSMTP_CONF_OPTS = \
 	--without-libidn \
+	--disable-gai-idn \
 	--without-libgsasl
 MSMTP_LICENSE = GPLv3+
 MSMTP_LICENSE_FILES = COPYING

I don't known if there is a consensus about IDN usage for buildroot. I didn't see an option in the config about it. I presume IDN should be disabled for all package, am I right ?

Quoted 6 lines

autoconf can't see if AI_IDN is really supported (http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
It seems weird but this is the case apparently.

Before I did the above patch, msmtp failed to send mail. The output was:

msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags

Excellent. Please add that to the commit log. If someone later feels the need for IDN, that person should come up with a solution.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -