Skip to contentSkip to conversation

common/lcd_console: fix console/logo regression

PATCH RESEND Superseded Marcel Ziswiler 4 participants 5 messages Aug 4, 2015 – Aug 13, 2015

lore
Share & tools
lore

Marcel Ziswiler

author
#0 lore raw

PATCH RESEND 1/1 common/lcd_console: fix console/logo regression

From: Marcel Ziswiler <[email protected]>

The following commit changed the order of the column vs. row parameter to the lcd_init_console() function but missed actually changing it as well the second time it is called from lcd_clear() which resulted in a garbled text console which this patch fixes.

commit 604c7d4a5a3cf70949f6e6094bf0d52ee3b4804d common/lcd_console: introduce display/framebuffer rotation

Tested on Colibri T20 with my latest assortment of tegra fixes/enhancements patch set.

Signed-off-by Marcel Ziswiler <[email protected]>
---
 common/lcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
common/lcd.c +2 -2
index 5a52fe4..d29308a 100644
@@ -234,8 +234,8 @@ void lcd_clear(void)
 	lcd_logo();
 #if defined(CONFIG_LCD_LOGO) && !defined(CONFIG_LCD_INFO_BELOW_LOGO)
 	addr = (ulong)lcd_base + BMP_LOGO_HEIGHT * lcd_line_length;
-	lcd_init_console((void *)addr, panel_info.vl_row,
-			 panel_info.vl_col, panel_info.vl_rot);
+	lcd_init_console((void *)addr, panel_info.vl_col,
+			 panel_info.vl_row, panel_info.vl_rot);
 #endif
 	lcd_sync();
 }
Signature · 1 line
2.4.3
#1 lore raw

PATCH RESEND 1/1 common/lcd_console: fix console/logo regression

Quoted 10 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

The following commit changed the order of the column vs. row parameter to the lcd_init_console() function but missed actually changing it as well the second time it is called from lcd_clear() which resulted in a garbled text console which this patch fixes.

commit 604c7d4a5a3cf70949f6e6094bf0d52ee3b4804d common/lcd_console: introduce display/framebuffer rotation

Quoted 7 lines

Tested on Colibri T20 with my latest assortment of tegra fixes/enhancements patch set.

Signed-off-by Marcel Ziswiler <[email protected]>
---
 common/lcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by Simon Glass <[email protected]>
#3 lore raw

PATCH RESEND 1/1 common/lcd_console: fix console/logo regression

Hi,

On Thu, 13 Aug 2015 13:57:37 +0200
Marcel Ziswiler <[email protected]> wrote:
...

Quoted 1 line

Could any of you guys please pull that one in or how do we proceed?

Sorry for delay, I'll merge the patch soon.

Thanks,

Anatolij

#4 lore raw

PATCH RESEND 1/1 common/lcd_console: fix console/logo regression

In reply to Marcel Ziswiler
Quoted 7 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

The following commit changed the order of the column vs. row parameter to the lcd_init_console() function but missed actually changing it as well the second time it is called from lcd_clear() which resulted in a garbled text console which this patch fixes.

Quoted 8 lines

commit 604c7d4a5a3cf70949f6e6094bf0d52ee3b4804d common/lcd_console: introduce display/framebuffer rotation

Tested on Colibri T20 with my latest assortment of tegra fixes/enhancements patch set.

Signed-off-by Marcel Ziswiler <[email protected]>
Acked-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150813/db2c2a6e/attachment.sig>