Skip to contentSkip to conversation

package/libpfm4: disable Werror

PATCH New Jörg Krause 3 participants 3 messages Aug 13, 2015 – Aug 18, 2015

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH 1/1 package/libpfm4: disable Werror

Set DBG to an empty value to disable -Werror when building libpfm4. Build aborts with a musl toolchain because of warnings about redirecting incorrect header includes.

So -Werror shouldn't be used in released code since it can cause random build failures on moderate warnings. It also depends on the used toolchain since different toolchains may or may not print the same warnings.

Fixes:
http://autobuild.buildroot.net/results/6df/6df9b94a79be1dc5ba878f7b67bf9ad4ce2f2e98/

Signed-off-by J?rg Krause <[email protected]>
---
 package/libpfm4/libpfm4.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/libpfm4/libpfm4.mk +2 -1
index e2fff80..7f14758 100644
@@ -13,7 +13,8 @@ LIBPFM4_INSTALL_STAGING = YES
 
 LIBPFM4_FLAGS = SYS=Linux ARCH=$(BR2_ARCH) \
 	CC="$(TARGET_CC)" LDCONFIG=true \
-	CONFIG_PFMLIB_SHARED=$(if $(BR2_STATIC_LIBS),n,y)
+	CONFIG_PFMLIB_SHARED=$(if $(BR2_STATIC_LIBS),n,y) \
+	DBG=
 
 define LIBPFM4_BUILD_CMDS
 	$(MAKE) -C $(@D) $(LIBPFM4_FLAGS)
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 package/libpfm4: disable Werror

J?rg, All,

On 2015-08-13 22:16 +0200, J?rg Krause spake thusly:

Quoted 4 lines

Set DBG to an empty value to disable -Werror when building libpfm4. Build aborts with a musl toolchain because of warnings about redirecting incorrect header includes.

Quoted 8 lines

So -Werror shouldn't be used in released code since it can cause random build failures on moderate warnings. It also depends on the used toolchain since different toolchains may or may not print the same warnings.

Fixes:
http://autobuild.buildroot.net/results/6df/6df9b94a79be1dc5ba878f7b67bf9ad4ce2f2e98/

Signed-off-by J?rg Krause <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
[yann.morin.1998 at free.fr: build-tested only]
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/libpfm4/libpfm4.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/libpfm4/libpfm4.mk +2 -1
index e2fff80..7f14758 100644
@@ -13,7 +13,8 @@ LIBPFM4_INSTALL_STAGING = YES
 
 LIBPFM4_FLAGS = SYS=Linux ARCH=$(BR2_ARCH) \
 	CC="$(TARGET_CC)" LDCONFIG=true \
-	CONFIG_PFMLIB_SHARED=$(if $(BR2_STATIC_LIBS),n,y)
+	CONFIG_PFMLIB_SHARED=$(if $(BR2_STATIC_LIBS),n,y) \
+	DBG=
 
 define LIBPFM4_BUILD_CMDS
 	$(MAKE) -C $(@D) $(LIBPFM4_FLAGS)
Signature · 6 lines
2.5.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 package/libpfm4: disable Werror

In reply to Jörg Krause

Dear J?rg Krause,

Quoted 8 lines · J?rg Krause

Set DBG to an empty value to disable -Werror when building libpfm4. Build aborts with a musl toolchain because of warnings about redirecting incorrect header includes.

So -Werror shouldn't be used in released code since it can cause random build failures on moderate warnings. It also depends on the used toolchain since different toolchains may or may not print the same warnings.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/6df/6df9b94a79be1dc5ba878f7b67bf9ad4ce2f2e98/

Signed-off-by J?rg Krause <[email protected]>
---
 package/libpfm4/libpfm4.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com