package/oprofile: fix static linking

When getext is enabled, popt links with -lintl, specifies it in its popt.pc and has done so for the past 6+ years. But oprofile does not use pkconfig to find popt, so misses -lintl, which is important for a static build. We have to do the call to pkgconfig manually...

Fixes:

    http://autobuild.buildroot.org/results/a48/a485f2171a3fcbfa2e0e5aec8e653cf88512615d/
    http://autobuild.buildroot.org/results/b37/b374874f1915ab1d7aa6262604ccc8db102bb0b0/
    http://autobuild.buildroot.org/results/261/2616a63081ed8c55c7ca1a6879b1a6a14e19f918/
    http://autobuild.buildroot.org/results/73f/73f34ab59d54ded68ff60608a0212a6e5a5190e5/
    ...

---
Change v2 -> v3:
- don't make the call to pkgconfig contional (Baruch)
- fix comment appropriately

Changes v1 -> v2:
- use PKG_CONFIG_HOST_BINARY to find popt libs (Baruch)

---
 package/oprofile/oprofile.mk | 6 ++++++
 1 file changed, 6 insertions(+)

index 5876307..ba36640 100644
@@ -41,6 +41,12 @@ ifeq ($(BR2_PACKAGE_LIBPFM4),y)
 OPROFILE_DEPENDENCIES += libpfm4
 endif
 
+# When getext is enabled, popt links with -lintl, specifies it in its
+# popt.pc and has done so for the past 6+ years. But oprofile does not
+# use pkconfig to find popt, so misses -lintl, which is important for
+# a static build. We have to do the call to pkgconfig manually...
+OPROFILE_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs popt`"
+
 define OPROFILE_INSTALL_TARGET_CMDS
 	$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/bin
 	$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/share/oprofile

1.9.1

Dear Yann E. MORIN,

Applied, thanks. Interestingly, oprofile's configure.ac checks for pkg-config, but does not seem to use it...

Best regards,

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com