Skip to contentSkip to conversation

package/bwm-ng: fix build failures with gcc-5

PATCH Superseded Yann E. MORIN 2 participants 5 messages Aug 16, 2015 – Aug 18, 2015

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH v2 1/1 package/bwm-ng: fix build failures with gcc-5

Bumping to the latest release, for 0.6 -> 0.6.1 to fix gcc-5 build failures due to incorrect definitions of 'static' functions.

The project also has a new home.

Fixes:

    http://autobuild.buildroot.org/results/546/546b332cf95a48412d88add2feec2ffd4712857c/
    http://autobuild.buildroot.org/results/751/751797f3b97839f69626682ce81dca9bcb2cff22/
    ...

Notes: the project does not provide hashes on its new location, even though SF.net still has the new file. But as stated on the new home, SF.net "will not be used anymore". And as stated by Baruch, "the dubious reputation of sf.net as of late, I don't think we can rely on their hashes in the long run". So, we only refer to the SF.net hash for reference, but use a locally computed, stronger sha256 as was previously the case.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Baruch Siach <[email protected]>

---
Changes v1 -> v2:
- point to SF.net for the origin of the sha1, but only use a locally computed sha256 (Baruch)

---
 package/bwm-ng/Config.in   | 2 +-
 package/bwm-ng/bwm-ng.hash | 6 ++++--
 package/bwm-ng/bwm-ng.mk   | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)
package/bwm-ng/Config.in +1 -1
index 25e7cbe..f93dd93 100644
@@ -5,4 +5,4 @@ config BR2_PACKAGE_BWM_NG
 	  network and disk-io bandwidth monitor for Linux, BSD,
 	  Solaris, Mac OS X and others.
 
-	  http://sourceforge.net/projects/bwmng/
+	  http://www.gropp.org/?id=projects&sub=bwm-ng
package/bwm-ng/bwm-ng.hash +4 -2
index 6bb8355..85f436f 100644
@@ -1,2 +1,4 @@
-# Locally calculated
-sha256  c1134358e268329d438b0996399003b0f0b966034fb4b5b138761c2f3c62ffdd  bwm-ng-0.6.tar.gz
+# From: http://sourceforge.net/projects/bwmng/files/bwmng/0.6/
+# sha1  9445885d05e2430ca174739e3aba343afce94076  bwm-ng-0.6.1.tar.gz
+# Because we do not trust SF.net, locally computed sha256:
+sha256  027cf3c960cd96fc9ffacdf7713df62d0fc55eeef4a1388289f8a62ae5e50df0  bwm-ng-0.6.1.tar.gz
package/bwm-ng/bwm-ng.mk +2 -2
index ed1f5aa..e285422 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-BWM_NG_VERSION = 0.6
-BWM_NG_SITE = http://downloads.sourceforge.net/project/bwmng/bwmng/$(BWM_NG_VERSION)
+BWM_NG_VERSION = 0.6.1
+BWM_NG_SITE = http://www.gropp.org/bwm-ng
 BWM_NG_CONF_OPTS = --with-procnetdev --with-diskstats
 BWM_NG_LICENSE = GPLv2
 BWM_NG_LICENSE_FILES = COPYING
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 package/bwm-ng: fix build failures with gcc-5

Dear Yann E. MORIN,

package/bwm-ng/bwm-ng.hash line 4

Quoted 11 lines · Yann E. MORIN
package/bwm-ng/bwm-ng.hash +4 -2
index 6bb8355..85f436f 100644
@@ -1,2 +1,4 @@
-# Locally calculated
-sha256  c1134358e268329d438b0996399003b0f0b966034fb4b5b138761c2f3c62ffdd  bwm-ng-0.6.tar.gz
+# From: http://sourceforge.net/projects/bwmng/files/bwmng/0.6/
+# sha1  9445885d05e2430ca174739e3aba343afce94076  bwm-ng-0.6.1.tar.gz
+# Because we do not trust SF.net, locally computed sha256:
+sha256  027cf3c960cd96fc9ffacdf7713df62d0fc55eeef4a1388289f8a62ae5e50df0  bwm-ng-0.6.1.tar.gz

I think this is silly. We should use both the sha1 provided by sourceforge and a locally calculated sha256 hash.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH v2 1/1 package/bwm-ng: fix build failures with gcc-5

On 2015-08-17 22:34 +0200, Thomas Petazzoni spake thusly:

Quoted 4 lines

Dear Yann E. MORIN,

On Sun, 16 Aug 2015 16:53:11 +0200, Yann E. MORIN wrote:

Quoted 14 lines

package/bwm-ng/bwm-ng.hash line 4

Quoted 11 lines
package/bwm-ng/bwm-ng.hash +4 -2
index 6bb8355..85f436f 100644
@@ -1,2 +1,4 @@
-# Locally calculated
-sha256  c1134358e268329d438b0996399003b0f0b966034fb4b5b138761c2f3c62ffdd  bwm-ng-0.6.tar.gz
+# From: http://sourceforge.net/projects/bwmng/files/bwmng/0.6/
+# sha1  9445885d05e2430ca174739e3aba343afce94076  bwm-ng-0.6.1.tar.gz
+# Because we do not trust SF.net, locally computed sha256:
+sha256  027cf3c960cd96fc9ffacdf7713df62d0fc55eeef4a1388289f8a62ae5e50df0  bwm-ng-0.6.1.tar.gz

I think this is silly. We should use both the sha1 provided by sourceforge and a locally calculated sha256 hash.

See the discussion that got us toward this situation:

    http://lists.busybox.net/pipermail/buildroot/2015-August/137445.html
    http://lists.busybox.net/pipermail/buildroot/2015-August/137447.html

Basically:
- we no longer download from SF.net
- so, how relevant is it to use a SF-provided hash?

Of course, since the hash does match as of today, we can keep it if you really want it.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH v2 1/1 package/bwm-ng: fix build failures with gcc-5

Dear Yann E. MORIN,

Quoted 7 lines · Yann E. MORIN

See the discussion that got us toward this situation:

    http://lists.busybox.net/pipermail/buildroot/2015-August/137445.html
    http://lists.busybox.net/pipermail/buildroot/2015-August/137447.html

Basically:
- we no longer download from SF.net
- so, how relevant is it to use a SF-provided hash?

Then, just don't mention/use the SF hash in the hash file.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH v2 1/1 package/bwm-ng: fix build failures with gcc-5

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 25 lines · Yann E. MORIN

Bumping to the latest release, for 0.6 -> 0.6.1 to fix gcc-5 build failures due to incorrect definitions of 'static' functions.

The project also has a new home.

Fixes:

    http://autobuild.buildroot.org/results/546/546b332cf95a48412d88add2feec2ffd4712857c/
    http://autobuild.buildroot.org/results/751/751797f3b97839f69626682ce81dca9bcb2cff22/
    ...

Notes: the project does not provide hashes on its new location, even though SF.net still has the new file. But as stated on the new home, SF.net "will not be used anymore". And as stated by Baruch, "the dubious reputation of sf.net as of late, I don't think we can rely on their hashes in the long run". So, we only refer to the SF.net hash for reference, but use a locally computed, stronger sha256 as was previously the case.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Baruch Siach <[email protected]>

---
Changes v1 -> v2:
- point to SF.net for the origin of the sha1, but only use a locally computed sha256 (Baruch)

Quoted 5 lines
---
 package/bwm-ng/Config.in   | 2 +-
 package/bwm-ng/bwm-ng.hash | 6 ++++--
 package/bwm-ng/bwm-ng.mk   | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

Applied after removing the SF.net related comments in the hash file, and adjusting the commit log accordingly. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com