package/lightning: fix build for static-only
PATCH 1/1 package/lightning: fix build for static-only
Fixes:
http://autobuild.buildroot.org/results/019/019b6f2ac034766a4266e20e5dcc229bec4a7222/ http://autobuild.buildroot.org/results/55d/55d30db7212863d9f898bb929f0c75d529036bad/ http://autobuild.buildroot.org/results/459/459ab12bc3eeb493f39efa2450bc829a351ee3a3/ ...
--- package/lightning/0003-no-check-no-doc.patch | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 package/lightning/0003-no-check-no-doc.patch
package/lightning/0003-no-check-no-doc.patch new file +21 -0
@@ -0,0 +1,21 @@ +Makefile: do not build checks or docs + +checks require a toolchain with shared libs, so they FTBFS when the +build is static-only. + +Docs we don't care about in Buildroot. + +Signed-off-by: "Yann E. MORIN" <[email protected]> + +diff -durN lightning-2.0.5.orig/Makefile.am lightning-2.0.5/Makefile.am +--- lightning-2.0.5.orig/Makefile.am 2013-09-24 05:37:46.000000000 +0200 ++++ lightning-2.0.5/Makefile.am 2015-08-13 16:27:20.626730913 +0200 +@@ -17,8 +17,6 @@ + ACLOCAL_AMFLAGS = -I m4 + + SUBDIRS = \ +- check \ +- doc \ + include \ + lib +
Signature · 1 line
1.9.1
PATCH 1/1 package/lightning: fix build for static-only
Hi Yann,
Quoted 19 lines · Yann E. MORIN
Fixes:
http://autobuild.buildroot.org/results/019/019b6f2ac034766a4266e20e5dcc229bec4a7222/ http://autobuild.buildroot.org/results/55d/55d30db7212863d9f898bb929f0c75d529036bad/ http://autobuild.buildroot.org/results/459/459ab12bc3eeb493f39efa2450bc829a351ee3a3/ ...Signed-off-by "Yann E. MORIN" <[email protected]>Cc Paul Cercueil <[email protected]>--- package/lightning/0003-no-check-no-doc.patch | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 package/lightning/0003-no-check-no-doc.patchpackage/lightning/0003-no-check-no-doc.patch new file +0
-0
package/lightning/0003-no-check-no-doc.patch line 6
Quoted 6 lines
package/lightning/0003-no-check-no-doc.patch new file +6
-0@@ -0,0 +1,21 @@ +Makefile: do not build checks or docs + +checks require a toolchain with shared libs, so they FTBFS when the +build is static-only. + +Docs we don't care about in Buildroot.
In http://patchwork.ozlabs.org/patch/505871/ I opted for disabling static build support entirely. I see the value in preserving static build ability, but this patch is not upstreamable in its current form. I'm fine both ways.
Quoted 4 lines
package/lightning/0003-no-check-no-doc.patch new file +4
-0+ +Signed-off-by: "Yann E. MORIN" <[email protected]> + +diff -durN lightning-2.0.5.orig/Makefile.am lightning-2.0.5/Makefile.am
package/lightning/0003-no-check-no-doc.patch line 20
Quoted 10 lines
package/lightning/0003-no-check-no-doc.patch new file +10
-0+--- lightning-2.0.5.orig/Makefile.am 2013-09-24 05:37:46.000000000 +0200 ++++ lightning-2.0.5/Makefile.am 2015-08-13 16:27:20.626730913 +0200 +@@ -17,8 +17,6 @@ + ACLOCAL_AMFLAGS = -I m4 + + SUBDIRS = \ +- check \ +- doc \ + include \ + lib
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH 1/1 package/lightning: fix build for static-only
In reply to Yann E. MORINDear Yann E. MORIN,
Quoted 6 lines · Yann E. MORIN
Fixes:
http://autobuild.buildroot.org/results/019/019b6f2ac034766a4266e20e5dcc229bec4a7222/ http://autobuild.buildroot.org/results/55d/55d30db7212863d9f898bb929f0c75d529036bad/ http://autobuild.buildroot.org/results/459/459ab12bc3eeb493f39efa2450bc829a351ee3a3/ ...
Quoted 6 lines
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Paul Cercueil <[email protected]>--- package/lightning/0003-no-check-no-doc.patch | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 package/lightning/0003-no-check-no-doc.patch
I've applied Baruch proposal of making the package unavailable for static builds. If you are really interested in having lightning available for static builds, implementing an upstream-acceptable solution would be nice.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 package/lightning: fix build for static-only
Thomas, All,
On 2015-08-18 11:20 +0200, Thomas Petazzoni spake thusly:
Quoted 14 lines · Yann E. MORIN
Quoted 6 lines
Fixes:
http://autobuild.buildroot.org/results/019/019b6f2ac034766a4266e20e5dcc229bec4a7222/ http://autobuild.buildroot.org/results/55d/55d30db7212863d9f898bb929f0c75d529036bad/ http://autobuild.buildroot.org/results/459/459ab12bc3eeb493f39efa2450bc829a351ee3a3/ ...Quoted 6 lines
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Paul Cercueil <[email protected]>--- package/lightning/0003-no-check-no-doc.patch | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 package/lightning/0003-no-check-no-doc.patch
Quoted 4 lines
I've applied Baruch proposal of making the package unavailable for static builds. If you are really interested in having lightning available for static builds, implementing an upstream-acceptable solution would be nice.
No, I don't care about lightning being staticaly buildable.
<humor>
For once, I decided to go the extra length of actually fixing the stuff, not just do my usual lazy we-dont-care-static-just-disable-it type of fix. Just to get this kind of cautery actually applied. </humor>
;-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'