Skip to contentSkip to conversation

package/systat: fix linking with -lintl

PATCH New Yann E. MORIN 2 participants 2 messages Aug 13, 2015 – Aug 18, 2015

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 package/systat: fix linking with -lintl

When lining, libraries should be listed in the reverse-dependency order, that is the library/ies with no dependency last, preceded by libraries that depend on them.

And most importantly, libraries should be listed *after* the local objects, .o files.

Currently, sysstat uses CFLAGS to shoehorn the -lintl linker flags, which is incorrect, as the CFLAGS are passed before the object files.

However, sysstat has a LFLAGS variable that, presumably, is to be used to pass linker flags. This is where we want to shoehorn -lintl.

Fixes:

    http://autobuild.buildroot.org/results/8cc/8cc547074de23b9482ad110234ef7458a44e174a/
    http://autobuild.buildroot.org/results/360/360f7b8252dc9f6bb47841b1d7207a121f90048c/
    http://autobuild.buildroot.org/results/04c/04cfc76a09e089985549a4320f34f6669d21cab5/
    http://autobuild.buildroot.org/results/818/818c08decf4a6190a9ed39915eae4cd3d2779880/
    ...
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/sysstat/sysstat.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/sysstat/sysstat.mk +1 -1
index b28c029..7568a4b 100644
@@ -14,7 +14,7 @@ SYSSTAT_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
 SYSSTAT_DEPENDENCIES += gettext
-SYSSTAT_MAKE_OPTS += CFLAGS="$(TARGET_CFLAGS) -lintl"
+SYSSTAT_MAKE_OPTS += LFLAGS="$(TARGET_LDFLAGS) -lintl"
 endif
 
 # The isag tool is a post processing script that depends on tcl/tk
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 package/systat: fix linking with -lintl

Dear Yann E. MORIN,

Quoted 1 line · Yann E. MORIN

When lining, libraries should be listed in the reverse-dependency order,

lining -> linking

Quoted 19 lines

that is the library/ies with no dependency last, preceded by libraries that depend on them.

And most importantly, libraries should be listed *after* the local objects, .o files.

Currently, sysstat uses CFLAGS to shoehorn the -lintl linker flags, which is incorrect, as the CFLAGS are passed before the object files.

However, sysstat has a LFLAGS variable that, presumably, is to be used to pass linker flags. This is where we want to shoehorn -lintl.

Fixes:

    http://autobuild.buildroot.org/results/8cc/8cc547074de23b9482ad110234ef7458a44e174a/
    http://autobuild.buildroot.org/results/360/360f7b8252dc9f6bb47841b1d7207a121f90048c/
    http://autobuild.buildroot.org/results/04c/04cfc76a09e089985549a4320f34f6669d21cab5/
    http://autobuild.buildroot.org/results/818/818c08decf4a6190a9ed39915eae4cd3d2779880/
    ...
Quoted 4 lines
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/sysstat/sysstat.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com