Skip to contentSkip to conversation

package/mosh: fix dependencies

PATCH New Yann E. MORIN 3 participants 5 messages Aug 11, 2015 – Aug 18, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mosh: fix dependencies

mosh selects protobuf, so it needs to propagate *all* its dependencies.

Fixes:

    http://autobuild.buildroot.org/results/1e7/1e7d28018252fa48ee1ccd68d0a21afb3e0f072f/
    http://autobuild.buildroot.org/results/a91/a91ea29454a6f8eefc0bf4f0eb137dd8e061f028/
    http://autobuild.buildroot.org/results/ecb/ecb67c1d1b04a79ad9fbe4a09121ec492fe1501c/
    [...]
Cc Christian Stewart <[email protected]>
---
 package/mosh/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/mosh/Config.in +2 -1
index 4ad7d61..feba023 100644
@@ -5,7 +5,8 @@ comment "mosh needs a toolchain w/ threads"
 config BR2_PACKAGE_MOSH
 	bool "mosh"
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
-	depends on BR2_TOOLCHAIN_HAS_THREADS #protobuf
+	depends on BR2_INSTALL_LIBSTDCPP # protobuf
+	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" # protobuf
 	select BR2_PACKAGE_PROTOBUF
 	select BR2_PACKAGE_NCURSES
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/mosh: fix dependencies

Yann & All,

Looks good, tested on an ODROID XU3 (ARM).

Signed-off-by "Christian Stewart" <c <[email protected]>

hristian at paral.in>

Christian

Quoted 30 lines · Yann E. MORIN

mosh selects protobuf, so it needs to propagate *all* its dependencies.

Fixes:

http://autobuild.buildroot.org/results/1e7/1e7d28018252fa48ee1ccd68d0a21afb3e0f072f/

http://autobuild.buildroot.org/results/a91/a91ea29454a6f8eefc0bf4f0eb137dd8e061f028/

http://autobuild.buildroot.org/results/ecb/ecb67c1d1b04a79ad9fbe4a09121ec492fe1501c/

    [...]
Cc Christian Stewart <[email protected]>
---
 package/mosh/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/mosh/Config.in +0 -0
index 4ad7d61..feba023 100644
@@ -5,7 +5,8 @@ comment "mosh needs a toolchain w/ threads"
 config BR2_PACKAGE_MOSH
        bool "mosh"
        depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 #

protobuf

package/mosh/Config.in +2 -1
-       depends on BR2_TOOLCHAIN_HAS_THREADS #protobuf
+       depends on BR2_INSTALL_LIBSTDCPP # protobuf
+       depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
        depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" #
Quoted 7 lines

protobuf
select BR2_PACKAGE_PROTOBUF
select BR2_PACKAGE_NCURSES
--
1.9.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150811/a18da630/attachment.html>

#2 lore raw

PATCH 1/1 package/mosh: fix dependencies

Dear Christian Stewart,

Quoted 6 lines · Christian Stewart

Yann & All,

Looks good, tested on an ODROID XU3 (ARM).

Signed-off-by "Christian Stewart" <c <[email protected]>

hristian at paral.in>

This is a bit messed up, no? Also, you shouldn't give a Signed-off-by here, but rather a Reviewed-by and/or Tested-by.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 package/mosh: fix dependencies

Hi Thomas,

Gmail messed it up (again). I've read the docs on signatures and will be following them accordingly.

Thanks!
Christian

Quoted 13 lines · Thomas Petazzoni

Dear Christian Stewart,

Quoted 6 lines · Christian Stewart

Yann & All,

Looks good, tested on an ODROID XU3 (ARM).

Signed-off-by "Christian Stewart" <c <[email protected]>

hristian at paral.in>

This is a bit messed up, no? Also, you shouldn't give a Signed-off-by here, but rather a Reviewed-by and/or Tested-by.

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150818/c112bb29/attachment.html>

#4 lore raw

PATCH 1/1 package/mosh: fix dependencies

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 19 lines · Yann E. MORIN

mosh selects protobuf, so it needs to propagate *all* its dependencies.

Fixes:

    http://autobuild.buildroot.org/results/1e7/1e7d28018252fa48ee1ccd68d0a21afb3e0f072f/
    http://autobuild.buildroot.org/results/a91/a91ea29454a6f8eefc0bf4f0eb137dd8e061f028/
    http://autobuild.buildroot.org/results/ecb/ecb67c1d1b04a79ad9fbe4a09121ec492fe1501c/
    [...]
Cc Christian Stewart <[email protected]>
---
 package/mosh/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/mosh/Config.in +0 -0
index 4ad7d61..feba023 100644

package/mosh/Config.in comment "mosh needs a toolchain w/ threads" · line 8

Quoted 5 lines
package/mosh/Config.in +1 -1
@@ -5,7 +5,8 @@ comment "mosh needs a toolchain w/ threads"
 config BR2_PACKAGE_MOSH
 	bool "mosh"
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
-	depends on BR2_TOOLCHAIN_HAS_THREADS #protobuf
+	depends on BR2_INSTALL_LIBSTDCPP # protobuf

And therefore, an update to the comment was needed to indicate that mosh needs C++ support. I've done that and applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com