Skip to contentSkip to conversation

msmtp: don't try to use IDN feature

PATCH New Anthony Viallard 3 participants 3 messages Aug 13, 2015 – Aug 18, 2015

lore
Share & tools
lore

Anthony Viallard

author
#0 lore raw

PATCH 1/1 msmtp: don't try to use IDN feature

I don't known if there is a consensus about IDN usage for buildroot. I didn't see an option in the config about it. I presume IDN should be disabled for all package, am I right ?

autoconf can't see if AI_IDN is really supported (http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
It seems weird but this is the case apparently.

Before I did the above patch, msmtp failed to send mail. The output was:

msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags

Signed-off-by Anthony Viallard <[email protected]>
---
 package/msmtp/msmtp.mk | 1 +
 1 file changed, 1 insertion(+)
package/msmtp/msmtp.mk +1 -0
index bff2620..7c8261e 100644
@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
 MSMTP_DEPENDENCIES = host-pkgconf
 MSMTP_CONF_OPTS = \
 	--without-libidn \
+	--disable-gai-idn \
 	--without-libgsasl
 MSMTP_LICENSE = GPLv3+
 MSMTP_LICENSE_FILES = COPYING
Signature · 1 line
2.4.6
#1 lore raw

PATCH 1/1 msmtp: don't try to use IDN feature

Hi Anthony,

Quoted 3 lines · Anthony Viallard

I don't known if there is a consensus about IDN usage for buildroot. I didn't see an option in the config about it. I presume IDN should be disabled for all package, am I right ?

This part should not appear in the commit log. The rest looks OK to me.

Quoted 8 lines

autoconf can't see if AI_IDN is really supported
(http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
It seems weird but this is the case apparently.

Before I did the above patch, msmtp failed to send mail. The output was:

msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags

Signed-off-by Anthony Viallard <[email protected]>

The convention is to have an empty line just above the sign-off line.

Quoted 9 lines
---
 package/msmtp/msmtp.mk | 1 +
 1 file changed, 1 insertion(+)
package/msmtp/msmtp.mk +0 -0
index bff2620..7c8261e 100644

package/msmtp/msmtp.mk MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz · line 16

Quoted 7 lines
package/msmtp/msmtp.mk +1 -0
@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
 MSMTP_DEPENDENCIES = host-pkgconf
 MSMTP_CONF_OPTS = \
 	--without-libidn \
+	--disable-gai-idn \
 	--without-libgsasl
 MSMTP_LICENSE = GPLv3+
 MSMTP_LICENSE_FILES = COPYING

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 msmtp: don't try to use IDN feature

In reply to Anthony Viallard

Dear Anthony Viallard,

Quoted 7 lines · Anthony Viallard

I don't known if there is a consensus about IDN usage for buildroot. I didn't see an option in the config about it. I presume IDN should be disabled for all package, am I right ?

autoconf can't see if AI_IDN is really supported (http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
It seems weird but this is the case apparently.

Quoted 7 lines

Before I did the above patch, msmtp failed to send mail. The output was:

msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags

Signed-off-by Anthony Viallard <[email protected]>
---
 package/msmtp/msmtp.mk | 1 +
 1 file changed, 1 insertion(+)

Applied after tweaking the commit log. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com