Skip to contentSkip to conversation

mtd: drop unconditional non LFS build

PATCH New Baruch Siach 2 participants 2 messages Aug 11, 2015 – Aug 18, 2015

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 mtd: drop unconditional non LFS build

Buildroot removed non LFS support in the 2015.05 release. We now pass -D_FILE_OFFSET_BITS=64 unconditionally, so the mtd WITHOUT_LARGEFILE make variable has no effect.

Signed-off-by Baruch Siach <[email protected]>
---
 package/mtd/mtd.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
package/mtd/mtd.mk +2 -4
index edf6e083ed60..5f14f1677645 100644
@@ -24,15 +24,13 @@ ifeq ($(BR2_PACKAGE_BUSYBOX),y)
 MTD_DEPENDENCIES += busybox
 endif
 
-MTD_MAKE_OPTS = WITHOUT_LARGEFILE=1
-
 # If extended attributes are required, the acl package must
 # also be enabled which will also include the attr package.
 ifeq ($(BR2_PACKAGE_ACL),y)
 MTD_DEPENDENCIES += acl
-MTD_MAKE_OPTS += WITHOUT_XATTR=0
+MTD_MAKE_OPTS = WITHOUT_XATTR=0
 else
-MTD_MAKE_OPTS += WITHOUT_XATTR=1
+MTD_MAKE_OPTS = WITHOUT_XATTR=1
 endif
 
 HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-e2fsprogs
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 mtd: drop unconditional non LFS build

Dear Baruch Siach,

Quoted 18 lines · Baruch Siach

Buildroot removed non LFS support in the 2015.05 release. We now pass -D_FILE_OFFSET_BITS=64 unconditionally, so the mtd WITHOUT_LARGEFILE make variable has no effect.

Signed-off-by Baruch Siach <[email protected]>
---
 package/mtd/mtd.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
package/mtd/mtd.mk +0 -1
index edf6e083ed60..5f14f1677645 100644
@@ -24,15 +24,13 @@ ifeq ($(BR2_PACKAGE_BUSYBOX),y)
 MTD_DEPENDENCIES += busybox
 endif
 
-MTD_MAKE_OPTS = WITHOUT_LARGEFILE=1

package/mtd/mtd.mk ifeq ($(BR2_PACKAGE_BUSYBOX),y) · line 33

Quoted 10 lines
package/mtd/mtd.mk +2 -3
-
 # If extended attributes are required, the acl package must
 # also be enabled which will also include the attr package.
 ifeq ($(BR2_PACKAGE_ACL),y)
 MTD_DEPENDENCIES += acl
-MTD_MAKE_OPTS += WITHOUT_XATTR=0
+MTD_MAKE_OPTS = WITHOUT_XATTR=0
 else
-MTD_MAKE_OPTS += WITHOUT_XATTR=1
+MTD_MAKE_OPTS = WITHOUT_XATTR=1

I believe using += is still better, as it will avoid potential mistakes in the future. I've reverted to use += instead, and applied your patch to next. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com