nfct: don't link against libnetfilter_conntrack
PATCH 1/1 nfct: don't link against libnetfilter_conntrack
The nfct program uses none of the symbols of libnetfilter_conntrack.
Linking against it means that distributors have to maintain an useless depedency.
This was spotted by the dpkg-shlibdeps tool.
--- src/Makefile.am | 1 - 1 file changed, 1 deletion(-)
src/Makefile.am +0 -1
@@ -25,7 +25,6 @@ nfct_SOURCES += nfct-extensions/timeout.c endif nfct_LDADD = ${LIBMNL_LIBS} \ - ${LIBNETFILTER_CONNTRACK_LIBS} \ ${libdl_LIBS} if HAVE_CTTIMEOUT
Quoted 4 lines · Arturo Borrero Gonzalez
The nfct program uses none of the symbols of
libnetfilter_conntrack.Linking against it means that distributors have to maintain an useless depedency.
Not to say the patch is bad, but:
Distributions do not really have to maintain a dependency anyway, as it can be autodiscovered from the DT_NEEDED entries. In addition, conntrackd still uses the library, so a dependency in the package will stay around.
Quoted 4 lines · Jan Engelhardt
Quoted 2 lines · Arturo Borrero Gonzalez
The nfct program uses none of the symbols of
libnetfilter_conntrack.
Quoted 8 lines
Quoted 2 lines
Linking against it means that distributors have to maintain an useless depedency.
Not to say the patch is bad, but:
Distributions do not really have to maintain a dependency anyway, as it can be autodiscovered from theDT_NEEDEDentries. In addition, conntrackd still uses the library, so a dependency in the package will stay around.
In case of debian, there are 3 different binary packages for conntrack, conntrackd and nfct. Each package may have different dependencies.
Signature · 5 lines
Arturo Borrero González -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Pablo Neira Ayuso
maintainerQuoted 14 lines · Arturo Borrero Gonzalez
Quoted 4 lines · Jan Engelhardt
Quoted 2 lines · Arturo Borrero Gonzalez
The nfct program uses none of the symbols of
libnetfilter_conntrack.Quoted 8 lines
Quoted 2 lines
Linking against it means that distributors have to maintain an useless depedency.
Not to say the patch is bad, but:
Distributions do not really have to maintain a dependency anyway, as it can be autodiscovered from theDT_NEEDEDentries. In addition, conntrackd still uses the library, so a dependency in the package will stay around.
Quoted 3 lines
In case of debian, there are 3 different binary packages for conntrack, conntrackd and nfct. Each package may have different dependencies.
Also applied, thanks Arturo.