ti: add usb peripheral support for omap5 and beagle x15

PATCH New Kishon Vijay Abraham I 2 participants 11 messages Aug 19, 2015 – Aug 28, 2015 Arm (32-bit)

lore

Share & tools

lore

Kishon Vijay Abraham I

author

2015-08-19 08:43 UTC #0 lore raw

cover ti: add usb peripheral support for omap5 and beagle x15

Add dwc3 peripheral support for omap5 and beagle x15 and enable DFU for these platforms.

This patch series is split from [1] to contain only adding peripheral support for omap5 and beagle x15.

[1] -> http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/229188

Kishon Vijay Abraham I (3):
board: ti: beagle_x15: added USB initializtion code
board: ti: OMAP5: added USB initializtion code
include: configs: Enable DWC3 and DFU in ti_omap5_common

 arch/arm/include/asm/arch-omap5/omap.h |    8 ++-
 board/ti/beagle_x15/board.c            |  111 ++++++++++++++++++++++++++++++++
 board/ti/omap5_uevm/evm.c              |   75 +++++++++++++++++++++
 include/configs/dra7xx_evm.h           |   63 ------------------
 include/configs/ti_omap5_common.h      |   67 ++++++++++++++++++-
 5 files changed, 257 insertions(+), 67 deletions(-)

Signature · 1 line

1.7.9.5

Kishon Vijay Abraham I

author

2015-08-19 08:43 UTC #1 lore raw

PATCH 1/3 board: ti: beagle_x15: added USB initializtion code

Implemented board_usb_init(), board_usb_cleanup() and usb_gadget_handle_interrupts() in beagle_x15 board file that can be invoked by various gadget drivers.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 arch/arm/include/asm/arch-omap5/omap.h |    2 +-
 board/ti/beagle_x15/board.c            |  111 ++++++++++++++++++++++++++++++++
 2 files changed, 112 insertions(+), 1 deletion(-)

arch/arm/include/asm/arch-omap5/omap.h +1 -1

index 524fae4..9b66877 100644
@@ -33,7 +33,7 @@
 #define CONTROL_ID_CODE		CONTROL_CORE_ID_CODE
 #endif
 
-#ifdef CONFIG_DRA7XX
+#if defined(CONFIG_DRA7XX) || defined(CONFIG_AM57XX)
 #define DRA7_USB_OTG_SS1_BASE		0x48890000
 #define DRA7_USB_OTG_SS1_GLUE_BASE	0x48880000
 #define DRA7_USB3_PHY1_PLL_CTRL		0x4A084C00

board/ti/beagle_x15/board.c +111 -0

124 lines not on this page · raw message

Signature · 1 line

1.7.9.5

Tom Rini

2015-08-20 17:54 UTC #2 lore raw

PATCH 1/3 board: ti: beagle_x15: added USB initializtion code

Quoted 5 lines · Kishon Vijay Abraham I

Implemented board_usb_init(), board_usb_cleanup() and usb_gadget_handle_interrupts() in beagle_x15 board file that can be invoked by various gadget drivers.
Signed-off-by Kishon Vijay Abraham I <[email protected]>

Reviewed-by Tom Rini <[email protected]>

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150820/62e4a5d5/attachment.sig>

Tom Rini

2015-08-28 21:04 UTC #3 lore raw

PATCH 1/3 board: ti: beagle_x15: added USB initializtion code

In reply to Kishon Vijay Abraham I

Quoted 6 lines · Kishon Vijay Abraham I

Implemented board_usb_init(), board_usb_cleanup() and usb_gadget_handle_interrupts() in beagle_x15 board file that can be invoked by various gadget drivers.
Signed-off-by Kishon Vijay Abraham I <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150828/4473213f/attachment.sig>

Kishon Vijay Abraham I

author

2015-08-19 08:43 UTC #4 lore raw

PATCH 2/3 board: ti: OMAP5: added USB initializtion code

In reply to Kishon Vijay Abraham I

Implemented board_usb_init(), board_usb_cleanup() and usb_gadget_handle_interrupts() in omap5 board file that can be invoked by various gadget drivers.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 arch/arm/include/asm/arch-omap5/omap.h |    6 +++
 board/ti/omap5_uevm/evm.c              |   75 ++++++++++++++++++++++++++++++++
 2 files changed, 81 insertions(+)

arch/arm/include/asm/arch-omap5/omap.h +6 -0

index 9b66877..bf5afbd 100644
@@ -43,6 +43,12 @@
 #define DRA7_USB_OTG_SS2_BASE		0x488D0000
 #define DRA7_USB_OTG_SS2_GLUE_BASE	0x488C0000
 #define DRA7_USB2_PHY2_POWER		0x4A002E74
+#else
+#define OMAP5XX_USB_OTG_SS_BASE		0x4A030000
+#define OMAP5XX_USB_OTG_SS_GLUE_BASE	0x4A020000
+#define OMAP5XX_USB3_PHY_PLL_CTRL	0x4A084C00
+#define OMAP5XX_USB3_PHY_POWER		0x4A002370
+#define OMAP5XX_USB2_PHY_POWER		0x4A002300
 #endif
 
 /* To be verified */

board/ti/omap5_uevm/evm.c +75 -0

90 lines not on this page · raw message

Signature · 1 line

1.7.9.5

Tom Rini

2015-08-20 17:54 UTC #5 lore raw

PATCH 2/3 board: ti: OMAP5: added USB initializtion code

Quoted 5 lines · Kishon Vijay Abraham I

Implemented board_usb_init(), board_usb_cleanup() and usb_gadget_handle_interrupts() in omap5 board file that can be invoked by various gadget drivers.
Signed-off-by Kishon Vijay Abraham I <[email protected]>

Reviewed-by Tom Rini <[email protected]>

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150820/e48c1f79/attachment.sig>

Tom Rini

2015-08-28 21:04 UTC #6 lore raw

PATCH 2/3 board: ti: OMAP5: added USB initializtion code

In reply to Kishon Vijay Abraham I

Quoted 6 lines · Kishon Vijay Abraham I

Implemented board_usb_init(), board_usb_cleanup() and usb_gadget_handle_interrupts() in omap5 board file that can be invoked by various gadget drivers.
Signed-off-by Kishon Vijay Abraham I <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150828/5916966a/attachment.sig>

Kishon Vijay Abraham I

author

2015-08-19 08:43 UTC #7 lore raw

PATCH 3/3 include: configs: Enable DWC3 and DFU in ti_omap5_common

In reply to Kishon Vijay Abraham I

Enabled configs for dwc3, dwc3-omap and PHY for dwc3 in ti_omap5_common. Also enabled support for DFU.

Since ti_omap5_common is used by dra7 too, removed these configs from dra7xx_evm config file.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 include/configs/dra7xx_evm.h      |   63 ----------------------------------
 include/configs/ti_omap5_common.h |   67 +++++++++++++++++++++++++++++++++++--
 2 files changed, 64 insertions(+), 66 deletions(-)

include/configs/dra7xx_evm.h +0 ~~-63~~

index 7499447..78a2c25 100644
@@ -47,47 +47,6 @@
 	"uuid_disk=${uuid_gpt_disk};" \
 	"name=rootfs,start=2MiB,size=-,uuid=${uuid_gpt_rootfs}"
 
-#define DFU_ALT_INFO_MMC \
-	"dfu_alt_info_mmc=" \
-	"boot part 0 1;" \
-	"rootfs part 0 2;" \
-	"MLO fat 0 1;" \
-	"MLO.raw raw 0x100 0x100;" \
-	"u-boot.img.raw raw 0x300 0x400;" \
-	"spl-os-args.raw raw 0x80 0x80;" \
-	"spl-os-image.raw raw 0x900 0x2000;" \
-	"spl-os-args fat 0 1;" \
-	"spl-os-image fat 0 1;" \
-	"u-boot.img fat 0 1;" \
-	"uEnv.txt fat 0 1\0"
-
-#define DFU_ALT_INFO_EMMC \
-	"dfu_alt_info_emmc=" \
-	"rawemmc raw 0 3751936;" \
-	"boot part 1 1;" \
-	"rootfs part 1 2;" \
-	"MLO fat 1 1;" \
-	"MLO.raw raw 0x100 0x100;" \
-	"u-boot.img.raw raw 0x300 0x400;" \
-	"spl-os-args.raw raw 0x80 0x80;" \
-	"spl-os-image.raw raw 0x900 0x2000;" \
-	"spl-os-args fat 1 1;" \
-	"spl-os-image fat 1 1;" \
-	"u-boot.img fat 1 1;" \
-	"uEnv.txt fat 1 1\0"
-
-#define DFU_ALT_INFO_RAM \
-	"dfu_alt_info_ram=" \
-	"kernel ram 0x80200000 0x4000000;" \
-	"fdt ram 0x80f80000 0x80000;" \
-	"ramdisk ram 0x81000000 0x4000000\0"
-
-#define DFUARGS \
-	"dfu_bufsiz=0x10000\0" \
-	DFU_ALT_INFO_MMC \
-	DFU_ALT_INFO_EMMC \
-	DFU_ALT_INFO_RAM
-
 /* Fastboot */
 #define CONFIG_USB_FUNCTION_FASTBOOT
 #define CONFIG_CMD_FASTBOOT

@@ -184,28 +143,6 @@
 #define CONFIG_OMAP_USB_PHY
 #define CONFIG_OMAP_USB2PHY2_HOST
 
-/* USB GADGET */
-#define CONFIG_USB_DWC3_PHY_OMAP
-#define CONFIG_USB_DWC3_OMAP
-#define CONFIG_USB_DWC3
-#define CONFIG_USB_DWC3_GADGET
-
-#define CONFIG_USB_GADGET
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_USB_GADGET_VBUS_DRAW 2
-#define CONFIG_G_DNL_MANUFACTURER "Texas Instruments"
-#define CONFIG_G_DNL_VENDOR_NUM 0x0451
-#define CONFIG_G_DNL_PRODUCT_NUM 0xd022
-#define CONFIG_USB_GADGET_DUALSPEED
-
-/* USB Device Firmware Update support */
-#define CONFIG_USB_FUNCTION_DFU
-#define CONFIG_DFU_RAM
-#define CONFIG_CMD_DFU
-
-#define CONFIG_DFU_MMC
-#define CONFIG_DFU_RAM
-
 /* SATA */
 #define CONFIG_BOARD_LATE_INIT
 #define CONFIG_CMD_SCSI

include/configs/ti_omap5_common.h +64 -3

79 lines not on this page · raw message

Signature · 1 line

1.7.9.5

Tom Rini

2015-08-20 17:56 UTC #8 lore raw

PATCH 3/3 include: configs: Enable DWC3 and DFU in ti_omap5_common

Quoted 7 lines · Kishon Vijay Abraham I

Enabled configs for dwc3, dwc3-omap and PHY for dwc3 in ti_omap5_common. Also enabled support for DFU.
Since ti_omap5_common is used by dra7 too, removed these configs from dra7xx_evm config file.
Signed-off-by Kishon Vijay Abraham I <[email protected]>

This is starting to move board-specific stuff (like using DFU) into the common file for all OMAP5 boards, so I don't like this. NAK in concept, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150820/9b38d66c/attachment.sig>

Kishon Vijay Abraham I

author

2015-08-21 05:57 UTC #9 lore raw

PATCH 3/3 include: configs: Enable DWC3 and DFU in ti_omap5_common

Hi Tom,

Quoted 5 lines · Tom Rini

Quoted 3 lines · Kishon Vijay Abraham I
Enabled configs for dwc3, dwc3-omap and PHY for dwc3 in ti_omap5_common. Also enabled support for DFU.

Quoted 8 lines

Quoted 4 lines
Since ti_omap5_common is used by dra7 too, removed these configs from dra7xx_evm config file.
Signed-off-by Kishon Vijay Abraham I <[email protected]>
This is starting to move board-specific stuff (like using DFU) into the common file for all OMAP5 boards, so I don't like this. NAK in concept, thanks!

Since we have added support for DFU for all the OMAP5 based boards (including DRA's), thought it is better to add in a common file which is used by all these boards.

So do you prefer the configs be added in dra7xx_evm.h, omap5_evm.h, beagle_x15.h etc..

Thanks
Kishon

Tom Rini

2015-08-24 16:11 UTC #10 lore raw

PATCH 3/3 include: configs: Enable DWC3 and DFU in ti_omap5_common

Quoted 17 lines · Kishon Vijay Abraham I

Hi Tom,
Quoted 5 lines · Tom Rini
Quoted 3 lines · Kishon Vijay Abraham I
Enabled configs for dwc3, dwc3-omap and PHY for dwc3 in ti_omap5_common. Also enabled support for DFU.
Quoted 8 lines
Quoted 4 lines
Since ti_omap5_common is used by dra7 too, removed these configs from dra7xx_evm config file.
Signed-off-by Kishon Vijay Abraham I <[email protected]>
This is starting to move board-specific stuff (like using DFU) into the common file for all OMAP5 boards, so I don't like this. NAK in concept, thanks!

Quoted 6 lines

Since we have added support for DFU for all the OMAP5 based boards (including DRA's), thought it is better to add in a common file which is used by all these boards.
So do you prefer the configs be added in dra7xx_evm.h, omap5_evm.h, beagle_x15.h etc..

Yes in each config. As we can see from when am335x (and am43xx now) starts getting used outside of TI some assumptions get changed and we still want them opting in on the comon header files :)

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150824/2c7d0929/attachment.sig>