Skip to contentSkip to conversation

linux: enable all options needed by xtables-addons

PATCH New Yann E. MORIN 2 participants 2 messages Aug 21, 2015 – Aug 23, 2015

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 linux: enable all options needed by xtables-addons

Both of CONFIG_NF_CONNTRACK and CONFIG_NF_CONNTRACK_MARK are needed by xtables-addons.

Although the current code does enable them in the linux' .config file, the former is protected behind CONFIG_NETFILTER_ADVANCED, which may be missing from a user-supplied (def)config file, and is missing from some of the bundled defconfigs as well.

For example, the following defconfig fails to build:

    BR2_TOOLCHAIN_EXTERNAL=y
    BR2_LINUX_KERNEL=y
    BR2_LINUX_KERNEL_DEFCONFIG="i386"
    BR2_PACKAGE_XTABLES_ADDONS=y

So, also force-enable CONFIG_NETFILTER_ADVANCED.

Signed-off-by "Yann E. MORIN" <[email protected]>
---
 linux/linux.mk | 1 +
 1 file changed, 1 insertion(+)
linux/linux.mk +1 -0
index d91dbb2..48f9c74 100644
@@ -215,6 +215,7 @@ define LINUX_KCONFIG_FIXUP_CMDS
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_XTABLES,$(@D)/.config))
 	$(if $(BR2_PACKAGE_XTABLES_ADDONS),
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_ADVANCED,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_MARK,$(@D)/.config))
 	$(if $(BR2_LINUX_KERNEL_APPENDED_DTB),
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 linux: enable all options needed by xtables-addons

Dear Yann E. MORIN,

Quoted 15 lines · Yann E. MORIN

Both of CONFIG_NF_CONNTRACK and CONFIG_NF_CONNTRACK_MARK are needed by xtables-addons.

Although the current code does enable them in the linux' .config file, the former is protected behind CONFIG_NETFILTER_ADVANCED, which may be missing from a user-supplied (def)config file, and is missing from some of the bundled defconfigs as well.

For example, the following defconfig fails to build:

    BR2_TOOLCHAIN_EXTERNAL=y
    BR2_LINUX_KERNEL=y
    BR2_LINUX_KERNEL_DEFCONFIG="i386"
    BR2_PACKAGE_XTABLES_ADDONS=y
Quoted 6 lines

So, also force-enable CONFIG_NETFILTER_ADVANCED.

Signed-off-by "Yann E. MORIN" <[email protected]>
---
 linux/linux.mk | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com