Skip to contentSkip to conversation

package/libcgroup: allow to build cgroup-tools

PATCH Superseded Bartosz Golaszewski 3 participants 4 messages Aug 24, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/1 package/libcgroup: allow to build cgroup-tools

Add a new config option that allows to build cgroup-tools - a set of command-line utils for managing cgroups.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 package/libcgroup/Config.in    | 6 ++++++
 package/libcgroup/libcgroup.mk | 7 ++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)
package/libcgroup/Config.in +6 -0
index b7a84e0..2d7a808 100644
@@ -9,5 +9,11 @@ config BR2_PACKAGE_LIBCGROUP
 
 	  http://libcg.sourceforge.net/
 
+config BR2_PACKAGE_CGROUP_TOOLS
+	bool "build cgroup-tools"
+	depends on BR2_PACKAGE_LIBCGROUP
+	help
+	  Include a set of command-line tools for managing cgroups.
+
 comment "libcgroup needs an (e)glibc toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
package/libcgroup/libcgroup.mk +6 -1
index ace2744..f3dbf18 100644
@@ -20,10 +20,15 @@ LIBCGROUP_CONF_ENV = \
 	CFLAGS="$(TARGET_CFLAGS) -U_FILE_OFFSET_BITS"
 
 LIBCGROUP_CONF_OPTS = \
-	--disable-tools \
 	--disable-daemon \
 	--disable-initscript-install
 
+ifeq ($(BR2_PACKAGE_CGROUP_TOOLS),y)
+LIBCGROUP_CONF_OPTS += --enable-tools
+else
+LIBCGROUP_CONF_OPTS += --disable-tools
+endif
+
 ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
 LIBCGROUP_DEPENDENCIES += linux-pam
 LIBCGROUP_CONF_OPTS += --enable-pam
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 package/libcgroup: allow to build cgroup-tools

Bartosz, All,

On 2015-08-24 11:13 +0200, Bartosz Golaszewski spake thusly:

Quoted 14 lines

Add a new config option that allows to build cgroup-tools - a set of command-line utils for managing cgroups.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 package/libcgroup/Config.in    | 6 ++++++
 package/libcgroup/libcgroup.mk | 7 ++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)
package/libcgroup/Config.in +0 -0
index b7a84e0..2d7a808 100644

package/libcgroup/Config.in config BR2_PACKAGE_LIBCGROUP · line 12

Quoted 4 lines
package/libcgroup/Config.in +1 -0
@@ -9,5 +9,11 @@ config BR2_PACKAGE_LIBCGROUP
 
 	  http://libcg.sourceforge.net/
 
+config BR2_PACKAGE_CGROUP_TOOLS

Options should be prefixed with the package name:

config BR2_PACKAGE_LIBCGROUP_TOOLS

package/libcgroup/Config.in config BR2_PACKAGE_LIBCGROUP · line 14

Quoted 2 lines
package/libcgroup/Config.in +2 -0
+	bool "build cgroup-tools"
+	depends on BR2_PACKAGE_LIBCGROUP

That's technically correct, but I think we'd prefer an enclosing if-endif construct, like so:

if BR2_PACKAGE_LIBCGROUP

config BR2_PACKAGE_LIBCGROUP_TOOLS
bool "cgroup tools"
help
Include a set of command-line tools for managing cgroups.

endif

Quoted 10 lines
package/libcgroup/Config.in +3 -0
+	help
+	  Include a set of command-line tools for managing cgroups.
+
 comment "libcgroup needs an (e)glibc toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
package/libcgroup/libcgroup.mk +0 -0
index ace2744..f3dbf18 100644

package/libcgroup/libcgroup.mk LIBCGROUP_CONF_ENV = \ · line 26

Quoted 8 lines
package/libcgroup/libcgroup.mk +1 -1
@@ -20,10 +20,15 @@ LIBCGROUP_CONF_ENV = \
 	CFLAGS="$(TARGET_CFLAGS) -U_FILE_OFFSET_BITS"
 
 LIBCGROUP_CONF_OPTS = \
-	--disable-tools \
 	--disable-daemon \
 	--disable-initscript-install
 
+ifeq ($(BR2_PACKAGE_CGROUP_TOOLS),y)

Of course, fix the variable name above, too.

Regards,
Yann E. MORIN.

Quoted 15 lines
package/libcgroup/libcgroup.mk +5 -0
+LIBCGROUP_CONF_OPTS += --enable-tools
+else
+LIBCGROUP_CONF_OPTS += --disable-tools
+endif
+
 ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
 LIBCGROUP_DEPENDENCIES += linux-pam
 LIBCGROUP_CONF_OPTS += --enable-pam
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/libcgroup: allow to build cgroup-tools

In reply to Bartosz Golaszewski

Dear Bartosz Golaszewski,

Quoted 37 lines · Bartosz Golaszewski

Add a new config option that allows to build cgroup-tools - a set of command-line utils for managing cgroups.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 package/libcgroup/Config.in    | 6 ++++++
 package/libcgroup/libcgroup.mk | 7 ++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)
package/libcgroup/Config.in +6 -0
index b7a84e0..2d7a808 100644
@@ -9,5 +9,11 @@ config BR2_PACKAGE_LIBCGROUP
 
 	  http://libcg.sourceforge.net/
 
+config BR2_PACKAGE_CGROUP_TOOLS
+	bool "build cgroup-tools"
+	depends on BR2_PACKAGE_LIBCGROUP
+	help
+	  Include a set of command-line tools for managing cgroups.
+
 comment "libcgroup needs an (e)glibc toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
package/libcgroup/libcgroup.mk +0 -1
index ace2744..f3dbf18 100644
@@ -20,10 +20,15 @@ LIBCGROUP_CONF_ENV = \
 	CFLAGS="$(TARGET_CFLAGS) -U_FILE_OFFSET_BITS"
 
 LIBCGROUP_CONF_OPTS = \
-	--disable-tools \
 	--disable-daemon \
 	--disable-initscript-install

package/libcgroup/libcgroup.mk LIBCGROUP_CONF_ENV = \ · line 34

Quoted 10 lines
package/libcgroup/libcgroup.mk +6 -0
 
+ifeq ($(BR2_PACKAGE_CGROUP_TOOLS),y)
+LIBCGROUP_CONF_OPTS += --enable-tools
+else
+LIBCGROUP_CONF_OPTS += --disable-tools
+endif
+
 ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
 LIBCGROUP_DEPENDENCIES += linux-pam
 LIBCGROUP_CONF_OPTS += --enable-pam

could you please mark this patch as superseded?
Regards,

Vincent.

author
#3 lore raw

PATCH 1/1 package/libcgroup: allow to build cgroup-tools

2015-08-24 13:29 GMT+02:00 Vicente Olivert Riera <[email protected]>:

Quoted 54 lines

Dear Bartosz Golaszewski,

Quoted 37 lines · Bartosz Golaszewski

Add a new config option that allows to build cgroup-tools - a set of command-line utils for managing cgroups.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 package/libcgroup/Config.in    | 6 ++++++
 package/libcgroup/libcgroup.mk | 7 ++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)
package/libcgroup/Config.in +6 -0
index b7a84e0..2d7a808 100644
@@ -9,5 +9,11 @@ config BR2_PACKAGE_LIBCGROUP
 
        http://libcg.sourceforge.net/
 
+config BR2_PACKAGE_CGROUP_TOOLS
+     bool "build cgroup-tools"
+     depends on BR2_PACKAGE_LIBCGROUP
+     help
+       Include a set of command-line tools for managing cgroups.
+
 comment "libcgroup needs an (e)glibc toolchain w/ C++"
      depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
package/libcgroup/libcgroup.mk +0 -1
index ace2744..f3dbf18 100644
@@ -20,10 +20,15 @@ LIBCGROUP_CONF_ENV = \
      CFLAGS="$(TARGET_CFLAGS) -U_FILE_OFFSET_BITS"
 
 LIBCGROUP_CONF_OPTS = \
-     --disable-tools \
      --disable-daemon \
      --disable-initscript-install

package/libcgroup/libcgroup.mk LIBCGROUP_CONF_ENV = \ · line 34

Quoted 10 lines
package/libcgroup/libcgroup.mk +6 -0
 
+ifeq ($(BR2_PACKAGE_CGROUP_TOOLS),y)
+LIBCGROUP_CONF_OPTS += --enable-tools
+else
+LIBCGROUP_CONF_OPTS += --disable-tools
+endif
+
 ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
 LIBCGROUP_DEPENDENCIES += linux-pam
 LIBCGROUP_CONF_OPTS += --enable-pam

could you please mark this patch as superseded?
Regards,

Quoted 1 line

Vincent.

Superseded by:
http://patchwork.ozlabs.org/patch/509986/