fbdev: fix snprintf() limit in show_bl_curve()

PATCH New Dan Carpenter 1 participant 1 message Aug 24, 2015

Subsystems (3)

Kernel janitors Framebuffer layer Framebuffer core

lore

Share & tools

lore

Dan Carpenter

author

2015-08-24 19:54 UTC #0 lore raw

PATCH v2 1/1 fbdev: fix snprintf() limit in show_bl_curve()

The limit should be "PAGE_SIZE - len" instead of PAGE_SIZE. Also let's use scnprintf() because snprintf() returns the number of bytes which would have been printed if there were space and scnprintf() returns the number of bytes actually printed.

I don't think we are ever going to actually hit this limit in real life.

Signed-off-by Dan Carpenter <[email protected]>

drivers/video/fbdev/core/fbsysfs.c +1 -1

index 60c3f0a..15755ce 100644
@@ -485,7 +485,7 @@ static ssize_t show_bl_curve(struct device *device,
 
 	mutex_lock(&fb_info->bl_curve_mutex);
 	for (i = 0; i < FB_BACKLIGHT_LEVELS; i += 8)
-		len += snprintf(&buf[len], PAGE_SIZE, "%8ph\n",
+		len += scnprintf(&buf[len], PAGE_SIZE - len, "%8ph\n",
 				fb_info->bl_curve + i);
 	mutex_unlock(&fb_info->bl_curve_mutex);