arc: make AXS101 default platform

PATCH New Alexey Brodkin 2 participants 5 messages Aug 24, 2015 – Sep 7, 2015 Synopsys ARC architecture

lore

Share & tools

lore

Alexey Brodkin

author

2015-08-24 16:00 UTC #0 lore raw

PATCH 1/1 arc: make AXS101 default platform

This fixes building in automated flow that doesn't use defconfigs.

See discussion on that topic here:
http://patchwork.ozlabs.org/patch/502558/

And while at it add missing shell prompt to axs103.

Cc Tom Rini <[email protected]>

Cc Joe Hershberger <[email protected]>

Cc Masahiro Yamada <[email protected]>

Signed-off-by Alexey Brodkin <[email protected]>

---
 arch/arc/Kconfig         | 2 +-
 configs/axs101_defconfig | 3 +--
 configs/axs103_defconfig | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

arch/arc/Kconfig +1 -1

index 925e312..264c83d 100644
@@ -129,7 +129,7 @@ config ARC_CACHE_LINE_SHIFT
 
 choice
 	prompt "Target select"
-	optional
+	default TARGET_AXS101
 
 config TARGET_TB100
 	bool "Support tb100"

configs/axs101_defconfig +1 -2

index 9a6cef3..fdb3149 100644
@@ -1,13 +1,12 @@
 CONFIG_ARC=y
 CONFIG_SYS_DCACHE_OFF=y
 CONFIG_ARC_CACHE_LINE_SHIFT=5
-CONFIG_TARGET_AXS101=y
 CONFIG_SYS_CLK_FREQ=750000000
 CONFIG_SYS_TEXT_BASE=0x81000000
+CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_NETDEVICES=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
-CONFIG_SYS_PROMPT="AXS# "

configs/axs103_defconfig +1 -1

index 8315b61..b3dbb8d 100644
@@ -1,8 +1,8 @@
 CONFIG_ARC=y
 CONFIG_ISA_ARCV2=y
-CONFIG_TARGET_AXS101=y
 CONFIG_SYS_CLK_FREQ=50000000
 CONFIG_SYS_TEXT_BASE=0x81000000
+CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set

Signature · 1 line

2.4.3

Tom Rini

2015-08-24 16:09 UTC #1 lore raw

PATCH 1/1 arc: make AXS101 default platform

Quoted 58 lines · Alexey Brodkin

This fixes building in automated flow that doesn't use defconfigs.
See discussion on that topic here:
http://patchwork.ozlabs.org/patch/502558/
See similar patches for other architectures/platforms here:
[1] http://git.denx.de/?p=u-boot.git;a=commit;h=ff560a13056a565a4e9ce1761bd04276a3cace88
[2] http://git.denx.de/?p=u-boot.git;a=commit;h=589907e2c187ec69b351c38ccda36730d25ab5d6
And while at it add missing shell prompt to axs103.
Cc Tom Rini <[email protected]>
Cc Joe Hershberger <[email protected]>
Cc Masahiro Yamada <[email protected]>
Signed-off-by Alexey Brodkin <[email protected]>
---
 arch/arc/Kconfig         | 2 +-
 configs/axs101_defconfig | 3 +--
 configs/axs103_defconfig | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)
arch/arc/Kconfig +1 -1
index 925e312..264c83d 100644
@@ -129,7 +129,7 @@ config ARC_CACHE_LINE_SHIFT
 
 choice
 	prompt "Target select"
-	optional
+	default TARGET_AXS101
 
 config TARGET_TB100
 	bool "Support tb100"
configs/axs101_defconfig +1 -2
index 9a6cef3..fdb3149 100644
@@ -1,13 +1,12 @@
 CONFIG_ARC=y
 CONFIG_SYS_DCACHE_OFF=y
 CONFIG_ARC_CACHE_LINE_SHIFT=5
-CONFIG_TARGET_AXS101=y
 CONFIG_SYS_CLK_FREQ=750000000
 CONFIG_SYS_TEXT_BASE=0x81000000
+CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_NETDEVICES=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
-CONFIG_SYS_PROMPT="AXS# "
configs/axs103_defconfig +0 -0
index 8315b61..b3dbb8d 100644

configs/axs103_defconfig line 8

Quoted 9 lines

configs/axs103_defconfig +1 -1

@@ -1,8 +1,8 @@
 CONFIG_ARC=y
 CONFIG_ISA_ARCV2=y
-CONFIG_TARGET_AXS101=y
 CONFIG_SYS_CLK_FREQ=50000000
 CONFIG_SYS_TEXT_BASE=0x81000000
+CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set

It all makes sense. But.. should it be TARGET_ASX10X ? Or is there (or might be..) future 10x devices that wouldn't be supported by the same code / config option?

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150824/3d30064b/attachment.sig>

Alexey Brodkin

author

2015-08-24 16:12 UTC #2 lore raw

PATCH 1/1 arc: make AXS101 default platform

Hi Tom,

Quoted 64 lines · Tom Rini

Quoted 63 lines · Alexey Brodkin
This fixes building in automated flow that doesn't use defconfigs.
See discussion on that topic here:
http://patchwork.ozlabs.org/patch/502558/
See similar patches for other architectures/platforms here:
[1] http://git.denx.de/?p=u-boot.git;a=commit;h=ff560a13056a565a4e9ce1761bd04276a3cace88
[2] http://git.denx.de/?p=u-boot.git;a=commit;h=589907e2c187ec69b351c38ccda36730d25ab5d6
And while at it add missing shell prompt to axs103.
Cc Tom Rini <[email protected]>
Cc Joe Hershberger <[email protected]>
Cc Masahiro Yamada <[email protected]>
Signed-off-by Alexey Brodkin <[email protected]>
---
 arch/arc/Kconfig         | 2 +-
 configs/axs101_defconfig | 3 +--
 configs/axs103_defconfig | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)
arch/arc/Kconfig +1 -1
index 925e312..264c83d 100644
@@ -129,7 +129,7 @@ config ARC_CACHE_LINE_SHIFT
 
 choice
 	prompt "Target select"
-	optional
+	default TARGET_AXS101
 
 config TARGET_TB100
 	bool "Support tb100"
configs/axs101_defconfig +1 -2
index 9a6cef3..fdb3149 100644
@@ -1,13 +1,12 @@
 CONFIG_ARC=y
 CONFIG_SYS_DCACHE_OFF=y
 CONFIG_ARC_CACHE_LINE_SHIFT=5
-CONFIG_TARGET_AXS101=y
 CONFIG_SYS_CLK_FREQ=750000000
 CONFIG_SYS_TEXT_BASE=0x81000000
+CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_NETDEVICES=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
-CONFIG_SYS_PROMPT="AXS# "
configs/axs103_defconfig +0 -1
index 8315b61..b3dbb8d 100644
@@ -1,8 +1,8 @@
 CONFIG_ARC=y
 CONFIG_ISA_ARCV2=y
-CONFIG_TARGET_AXS101=y
 CONFIG_SYS_CLK_FREQ=50000000
 CONFIG_SYS_TEXT_BASE=0x81000000

Quoted 8 lines

configs/axs103_defconfig line 8
Quoted 4 lines
configs/axs103_defconfig +1 -0
+CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
It all makes sense. But.. should it be TARGET_ASX10X ? Or is there (or might be..) future 10x devices that wouldn't be supported by the same code / config option?

Indeed we already have axs101 and axs103 as you see in U-Boot. Moreover there's internal thing that stands in between - axs102. And I'm going to do that naming clean-up when time permits but let's say for today that legacy naming stuff is fine.

So yes I'll try to do that sometime soon.

-Alexey

Tom Rini

2015-08-24 20:00 UTC #3 lore raw

PATCH 1/1 arc: make AXS101 default platform

Quoted 76 lines · Alexey Brodkin

Hi Tom,
Quoted 64 lines · Tom Rini
Quoted 63 lines · Alexey Brodkin
This fixes building in automated flow that doesn't use defconfigs.
See discussion on that topic here:
http://patchwork.ozlabs.org/patch/502558/
See similar patches for other architectures/platforms here:
[1] http://git.denx.de/?p=u-boot.git;a=commit;h=ff560a13056a565a4e9ce1761bd04276a3cace88
[2] http://git.denx.de/?p=u-boot.git;a=commit;h=589907e2c187ec69b351c38ccda36730d25ab5d6
And while at it add missing shell prompt to axs103.
Cc Tom Rini <[email protected]>
Cc Joe Hershberger <[email protected]>
Cc Masahiro Yamada <[email protected]>
Signed-off-by Alexey Brodkin <[email protected]>
---
 arch/arc/Kconfig         | 2 +-
 configs/axs101_defconfig | 3 +--
 configs/axs103_defconfig | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)
arch/arc/Kconfig +1 -1
index 925e312..264c83d 100644
@@ -129,7 +129,7 @@ config ARC_CACHE_LINE_SHIFT
 
 choice
 	prompt "Target select"
-	optional
+	default TARGET_AXS101
 
 config TARGET_TB100
 	bool "Support tb100"
configs/axs101_defconfig +1 -2
index 9a6cef3..fdb3149 100644
@@ -1,13 +1,12 @@
 CONFIG_ARC=y
 CONFIG_SYS_DCACHE_OFF=y
 CONFIG_ARC_CACHE_LINE_SHIFT=5
-CONFIG_TARGET_AXS101=y
 CONFIG_SYS_CLK_FREQ=750000000
 CONFIG_SYS_TEXT_BASE=0x81000000
+CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_NETDEVICES=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
-CONFIG_SYS_PROMPT="AXS# "
configs/axs103_defconfig +0 -1
index 8315b61..b3dbb8d 100644
@@ -1,8 +1,8 @@
 CONFIG_ARC=y
 CONFIG_ISA_ARCV2=y
-CONFIG_TARGET_AXS101=y
 CONFIG_SYS_CLK_FREQ=50000000
 CONFIG_SYS_TEXT_BASE=0x81000000
Quoted 8 lines
configs/axs103_defconfig line 8
Quoted 4 lines
configs/axs103_defconfig +1 -0
+CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
It all makes sense. But.. should it be TARGET_ASX10X ? Or is there (or might be..) future 10x devices that wouldn't be supported by the same code / config option?

Quoted 6 lines

Indeed we already have axs101 and axs103 as you see in U-Boot. Moreover there's internal thing that stands in between - axs102. And I'm going to do that naming clean-up when time permits but let's say for today that legacy naming stuff is fine.
So yes I'll try to do that sometime soon.

OK thanks and this is fine to do in the mean time as-is.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150824/57235460/attachment.sig>

Alexey Brodkin

author Applied

2015-09-07 10:47 UTC #4 lore raw

PATCH 1/1 arc: make AXS101 default platform

In reply to Alexey Brodkin

Quoted 9 lines · Alexey Brodkin

This fixes building in automated flow that doesn't use defconfigs.
See discussion on that topic here:
http://patchwork.ozlabs.org/patch/502558/
See similar patches for other architectures/platforms here:
[1] http://git.denx.de/?p=u-boot.git;a=commit;h=ff560a13056a565a4e9ce1761bd04276a3cace88
[2] http://git.denx.de/?p=u-boot.git;a=commit;h=589907e2c187ec69b351c38ccda36730d25ab5d6

Quoted 7 lines

And while at it add missing shell prompt to axs103.
Cc Tom Rini <[email protected]>
Cc Joe Hershberger <[email protected]>
Cc Masahiro Yamada <[email protected]>
Signed-off-by Alexey Brodkin <[email protected]>
---

Applied, thanks.

-Alexey