Skip to contentSkip to conversation

net: compile renesas directory if NET_VENDOR_RENESAS is configured

PATCH Applied Simon Horman 4 participants 5 messages Aug 25, 2015

Subsystems (3)
Networking Network drivers SuperH
lore
Share & tools
lore

Simon Horman

author
#0 lore raw

PATCH 1/1 net: compile renesas directory if NET_VENDOR_RENESAS is configured

From: Kazuya Mizuguchi <[email protected]>

Currently the renesas ethernet driver directory is compiled if SH_ETH is configured rather than NET_VENDOR_RENESAS. Although incorrect that was quite harmless as until recently as SH_ETH configured the only driver in the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB driver proper") the renesas directory includes another driver, configured by RAVB, and it makes little sense for it to have a hidden dependency on SH_ETH.

Signed-off-by Kazuya Mizuguchi <[email protected]>
[horms: rewrote changelog]
Signed-off-by Simon Horman <[email protected]>
---
 drivers/net/ethernet/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Reposted with net-next prefix.

drivers/net/ethernet/Makefile +1 -1
index f42177b11723..ddfc808110a1 100644
@@ -65,7 +65,7 @@ obj-$(CONFIG_NET_VENDOR_PASEMI) += pasemi/
 obj-$(CONFIG_NET_VENDOR_QLOGIC) += qlogic/
 obj-$(CONFIG_NET_VENDOR_QUALCOMM) += qualcomm/
 obj-$(CONFIG_NET_VENDOR_REALTEK) += realtek/
-obj-$(CONFIG_SH_ETH) += renesas/
+obj-$(CONFIG_NET_VENDOR_RENESAS) += renesas/
 obj-$(CONFIG_NET_VENDOR_RDC) += rdc/
 obj-$(CONFIG_NET_VENDOR_ROCKER) += rocker/
 obj-$(CONFIG_NET_VENDOR_SAMSUNG) += samsung/
Signature · 1 line
2.1.4
#1 lore raw
Quoted 10 lines · Simon Horman

From: Kazuya Mizuguchi <[email protected]>

Currently the renesas ethernet driver directory is compiled if SH_ETH is configured rather than NET_VENDOR_RENESAS. Although incorrect that was quite harmless as until recently as SH_ETH configured the only driver in the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB driver proper") the renesas directory includes another driver, configured by RAVB, and it makes little sense for it to have a hidden dependency on SH_ETH.

Quoted 3 lines
Signed-off-by Kazuya Mizuguchi <[email protected]>
[horms: rewrote changelog]
Signed-off-by Simon Horman <[email protected]>

Sorry about missing that when submitting the AVB driver.

MBR, Sergei

#2 lore raw
Quoted 10 lines · Sergei Shtylyov
Quoted 10 lines

From: Kazuya Mizuguchi <[email protected]>

Currently the renesas ethernet driver directory is compiled if SH_ETH is configured rather than NET_VENDOR_RENESAS. Although incorrect that was quite harmless as until recently as SH_ETH configured the only driver in the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB driver proper") the renesas directory includes another driver, configured by RAVB, and it makes little sense for it to have a hidden dependency on SH_ETH.

Quoted 5 lines
Quoted 3 lines
Signed-off-by Kazuya Mizuguchi <[email protected]>
[horms: rewrote changelog]
Signed-off-by Simon Horman <[email protected]>

Sorry about missing that when submitting the AVB driver.

BTW, why against net-next? I consider this a fix.

MBR, Sergei

#3 lore raw
Quoted 12 lines · Sergei Shtylyov
Quoted 10 lines · Sergei Shtylyov
Quoted 10 lines

From: Kazuya Mizuguchi <[email protected]>

Currently the renesas ethernet driver directory is compiled if SH_ETH is configured rather than NET_VENDOR_RENESAS. Although incorrect that was quite harmless as until recently as SH_ETH configured the only driver in the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB driver proper") the renesas directory includes another driver, configured by RAVB, and it makes little sense for it to have a hidden dependency on SH_ETH.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Kazuya Mizuguchi <[email protected]>
[horms: rewrote changelog]
Signed-off-by Simon Horman <[email protected]>

Sorry about missing that when submitting the AVB driver.

BTW, why against net-next? I consider this a fix.

I wasn't sure which way to go and decided to err on the side of caution with a net-next submission. I have no objections to it being considered for next.

maintainer Applied
#4 lore raw

From: Simon Horman <[email protected]>
Date: Wed, 26 Aug 2015 08:55:39 +1000

Quoted 17 lines · Sergei Shtylyov
Quoted 16 lines · Sergei Shtylyov
Quoted 15 lines
Quoted 14 lines

From: Kazuya Mizuguchi <[email protected]>

Currently the renesas ethernet driver directory is compiled if SH_ETH is configured rather than NET_VENDOR_RENESAS. Although incorrect that was quite harmless as until recently as SH_ETH configured the only driver in the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB driver proper") the renesas directory includes another driver, configured by RAVB, and it makes little sense for it to have a hidden dependency on SH_ETH.

Signed-off-by Kazuya Mizuguchi <[email protected]>
[horms: rewrote changelog]
Signed-off-by Simon Horman <[email protected]>
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Sorry about missing that when submitting the AVB driver.

BTW, why against net-next? I consider this a fix.

I wasn't sure which way to go and decided to err on the side of caution with a net-next submission. I have no objections to it being considered for next.

I'll put it in the 'net' tree.

Applied, thanks.