Skip to contentSkip to conversation

Revert "dev: set iflink to 0 for virtual interfaces"

PATCH Applied Stephen Hemminger 2 participants 2 messages Aug 25, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "dev: set iflink to 0 for virtual interfaces"

Dave could you include this in next update to 4.1 stable update?

Quoted 1 line

From a72f813bf1aab4dfe47e3d4ab5e2e07bbcdf2b58 Mon Sep 17 00:00:00 2001

From: Nicolas Dichtel <[email protected]>
Date: Mon, 6 Jul 2015 17:25:10 +0200
Subject: [PATCH] Revert "dev: set iflink to 0 for virtual interfaces"

commit 95ec655bc465ccb2a3329d4aff9a45e3c8188db5 upstream. It should be applied to 4.1.y stable tree.

This reverts commit e1622baf54df8cc958bf29d71de5ad545ea7d93c.

The side effect of this commit is to add a '@NONE' after each virtual interface name with a 'ip link'. It may break existing scripts.

---
 net/core/dev.c | 4 ----
 1 file changed, 4 deletions(-)
net/core/dev.c +0 -4
index aa82f9a..8c416c99 100644
@@ -672,10 +672,6 @@ int dev_get_iflink(const struct net_device *dev)
 	if (dev->netdev_ops && dev->netdev_ops->ndo_get_iflink)
 		return dev->netdev_ops->ndo_get_iflink(dev);
 
-	/* If dev->rtnl_link_ops is set, it's a virtual interface. */
-	if (dev->rtnl_link_ops)
-		return 0;
-
 	return dev->ifindex;
 }
 EXPORT_SYMBOL(dev_get_iflink);
Signature · 1 line
2.1.4
maintainer Applied
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Tue, 25 Aug 2015 14:09:58 -0700

Quoted 1 line

Dave could you include this in next update to 4.1 stable update?

Queued up, thanks Stephen.