Skip to contentSkip to conversation

package/tn5250: fix static linking problem

PATCH New Vicente Olivert Riera 3 participants 10 messages Aug 26, 2015

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

tn5250 fails to link with openssl when building statically. We need to add the needed libraries to the LIBS configure environment variable in order to make tn5250 able to find them.

Fixes:

http://autobuild.buildroot.net/results/95f/95f6df0d01e4944ecd84e830e2bbd8389e1d3e3d/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/tn5250/tn5250.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/tn5250/tn5250.mk +1 -0
index 213f02c..953b395 100644
@@ -12,6 +12,7 @@ TN5250_LICENSE = LGPLv2.1+
 TN5250_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
+TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"
 TN5250_CONF_OPTS += --with-ssl-dir=$(STAGING_DIR)/usr
 TN5250_DEPENDENCIES += openssl
 else
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

Hi Vicente,

Quoted 18 lines · Vicente Olivert Riera

tn5250 fails to link with openssl when building statically. We need to add the needed libraries to the LIBS configure environment variable in order to make tn5250 able to find them.

Fixes:

http://autobuild.buildroot.net/results/95f/95f6df0d01e4944ecd84e830e2bbd8389e1d3e3d/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/tn5250/tn5250.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/tn5250/tn5250.mk +0 -0
index 213f02c..953b395 100644

package/tn5250/tn5250.mk TN5250_LICENSE = LGPLv2.1+ · line 15

Quoted 4 lines
package/tn5250/tn5250.mk +1 -0
@@ -12,6 +12,7 @@ TN5250_LICENSE = LGPLv2.1+
 TN5250_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
+TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"

Please use pkg-config. See package/vsftpd/vsftpd.mk for example.

package/tn5250/tn5250.mk TN5250_LICENSE = LGPLv2.1+ · line 18

Quoted 3 lines
package/tn5250/tn5250.mk +0 -0
 TN5250_CONF_OPTS += --with-ssl-dir=$(STAGING_DIR)/usr
 TN5250_DEPENDENCIES += openssl
 else

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#2 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

Dear Baruch Siach,

Quoted 23 lines · Baruch Siach

Hi Vicente,

Quoted 20 lines · Vicente Olivert Riera

tn5250 fails to link with openssl when building statically. We need to add the needed libraries to the LIBS configure environment variable in order to make tn5250 able to find them.

Fixes:

http://autobuild.buildroot.net/results/95f/95f6df0d01e4944ecd84e830e2bbd8389e1d3e3d/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/tn5250/tn5250.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/tn5250/tn5250.mk +0 -0
index 213f02c..953b395 100644
@@ -12,6 +12,7 @@ TN5250_LICENSE = LGPLv2.1+
 TN5250_LICENSE_FILES = COPYING
Quoted 4 lines

package/tn5250/tn5250.mk TN5250_LICENSE = LGPLv2.1+ · line 15

Quoted 2 lines
package/tn5250/tn5250.mk +1 -0
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
+TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"

Please use pkg-config. See package/vsftpd/vsftpd.mk for example.

that was my first approach and it didn't work. Does it work for you?

Regards,

Vincent.

Quoted 6 lines

package/tn5250/tn5250.mk TN5250_LICENSE = LGPLv2.1+ · line 18

Quoted 3 lines
package/tn5250/tn5250.mk +0 -0
 TN5250_CONF_OPTS += --with-ssl-dir=$(STAGING_DIR)/usr
 TN5250_DEPENDENCIES += openssl
 else

baruch

#3 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

Hi vincente,

Quoted 8 lines · Vicente Olivert Riera
Quoted 5 lines · Baruch Siach
Quoted 2 lines · Vicente Olivert Riera

ifeq ($(BR2_PACKAGE_OPENSSL),y)
+TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"

Please use pkg-config. See package/vsftpd/vsftpd.mk for example.

that was my first approach and it didn't work. Does it work for you?

Please try http://patchwork.ozlabs.org/patch/510797/. Works for me :-).

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#4 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

Dear Baruch Siach,

Quoted 8 lines · Baruch Siach

Hi vincente,

Quoted 5 lines · Vicente Olivert Riera
Quoted 4 lines · Baruch Siach
Quoted 2 lines · Vicente Olivert Riera

ifeq ($(BR2_PACKAGE_OPENSSL),y)
+TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Please use pkg-config. See package/vsftpd/vsftpd.mk for example.

that was my first approach and it didn't work. Does it work for you?

Please try http://patchwork.ozlabs.org/patch/510797/. Works for me :-).

baruch

yeah, that one works. I was missing "libcrypto". But, I don't understand why do you need to put libcrypto manually since it's already listed in the openssl.pc file, and then libcrypto pulls libz. Doesn't work recursively?

Regards,

Vincent.

#5 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

Hi Vicente,

Quoted 9 lines · Vicente Olivert Riera
Quoted 8 lines · Baruch Siach
Quoted 7 lines · Vicente Olivert Riera
Quoted 5 lines · Baruch Siach
Quoted 2 lines · Vicente Olivert Riera

ifeq ($(BR2_PACKAGE_OPENSSL),y)
+TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"

Please use pkg-config. See package/vsftpd/vsftpd.mk for example.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

that was my first approach and it didn't work. Does it work for you?

Please try http://patchwork.ozlabs.org/patch/510797/. Works for me :-).

yeah, that one works. I was missing "libcrypto". But, I don't understand why do you need to put libcrypto manually since it's already listed in the openssl.pc file, and then libcrypto pulls libz. Doesn't work recursively?

I tried "--libs openssl" here, and it works as well. I'm not sure which one is better.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#6 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

Dear Baruch Siach,

Quoted 21 lines · Baruch Siach

Hi Vicente,

Quoted 9 lines · Vicente Olivert Riera
Quoted 8 lines · Baruch Siach
Quoted 7 lines · Vicente Olivert Riera
Quoted 5 lines · Baruch Siach
Quoted 2 lines · Vicente Olivert Riera

ifeq ($(BR2_PACKAGE_OPENSSL),y)
+TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"

Please use pkg-config. See package/vsftpd/vsftpd.mk for example.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

that was my first approach and it didn't work. Does it work for you?

Please try http://patchwork.ozlabs.org/patch/510797/. Works for me :-).

yeah, that one works. I was missing "libcrypto". But, I don't understand why do you need to put libcrypto manually since it's already listed in the openssl.pc file, and then libcrypto pulls libz. Doesn't work recursively?

Quoted 5 lines

I tried "--libs openssl" here, and it works as well. I'm not sure which one is better.

baruch

indeed, it works. Now I'm wondering which which mistake I made.

I think just "--libs openssl" is better since it seems to act recursively and pull all the other libraries as well. If you send a v2 of your patch, you can keep my reviewed-by and my tested-by, since I have already done the test.

Regards,

Vincent.

author
#7 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

Dear Baruch Siach,

Quoted 2 lines · Vicente Olivert Riera

I think just "--libs openssl" is better since it seems to act recursively

look at this snippet from config.log:

ac_cv_env_LIBS_value='-lssl -L/br/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot/usr//lib -lcrypto -lz '

So, it does recursion.

Regards,

Vincent.

#8 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

In reply to Vicente Olivert Riera

Hi Vicente,

Quoted 23 lines · Vicente Olivert Riera
Quoted 14 lines · Baruch Siach
Quoted 13 lines · Vicente Olivert Riera
Quoted 11 lines · Baruch Siach
Quoted 8 lines · Vicente Olivert Riera
Quoted 5 lines · Baruch Siach
Quoted 2 lines · Vicente Olivert Riera

ifeq ($(BR2_PACKAGE_OPENSSL),y)
+TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"

Please use pkg-config. See package/vsftpd/vsftpd.mk for example.

that was my first approach and it didn't work. Does it work for you?

Please try http://patchwork.ozlabs.org/patch/510797/. Works for me :-).

Quoted 7 lines
Quoted 4 lines

yeah, that one works. I was missing "libcrypto". But, I don't understand why do you need to put libcrypto manually since it's already listed in the openssl.pc file, and then libcrypto pulls libz. Doesn't work recursively?

I tried "--libs openssl" here, and it works as well. I'm not sure which one is better.

Quoted 6 lines

indeed, it works. Now I'm wondering which which mistake I made.

I think just "--libs openssl" is better since it seems to act recursively and pull all the other libraries as well. If you send a v2 of your patch, you can keep my reviewed-by and my tested-by, since I have already done the test.

Just did.

Thanks,
baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#9 lore raw

PATCH 1/1 package/tn5250: fix static linking problem

In reply to Vicente Olivert Riera
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Hi,

Quoted 4 lines

yeah, that one works. I was missing "libcrypto". But, I don't understand why do you need to put libcrypto manually since it's already listed in the openssl.pc file, and then libcrypto pulls libz. Doesn't work recursively?

It should when linking statically. Make sure you pass --static to pkg-conf (like we do in BR).

Signature · 1 line
Bye, Peter Korsgaard