Skip to contentSkip to conversation

libpam-tacplus: new package

PATCH New giovanni.zantedeschi 2 participants 2 messages Aug 20, 2015 – Aug 28, 2015

lore
Share & tools
lore

giovanni.zantedeschi

author
#0 lore raw

PATCH v2 1/1 libpam-tacplus: new package

From: "Giovanni Zantedeschi" <[email protected]>

Signed-off-by Giovanni Zantedeschi <[email protected]>

---
Changes v1 -> v2:
- Using Library instead of Lib (suggested by Ryan Barnett)
- Improved package description (suggested by Thomas Petazzoni)
- Added project site to description (suggested by Ryan Barnett)
- Changed download method (suggested by Ryan Barnett)
- Added dependency of linux-pam
- Using LIBPAM_TACPLUS_CONF_ENV instead of LIBPAM_TACPLUS_CONF_OPTS (suggested by Thomas Petazzoni)

---
 package/Config.in                        |  1 +
 package/libpam-tacplus/Config.in         | 10 ++++++++++
 package/libpam-tacplus/libpam-tacplus.mk | 18 ++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/libpam-tacplus/Config.in
 create mode 100644 package/libpam-tacplus/libpam-tacplus.mk
package/Config.in +1 -0
index 47d14d7..9e92023 100644
@@ -1074,6 +1074,7 @@ menu "Other"
 	source "package/libical/Config.in"
 	source "package/liblinear/Config.in"
 	source "package/libnspr/Config.in"
+	source "package/libpam-tacplus/Config.in"
 	source "package/libpfm4/Config.in"
 	source "package/libplatform/Config.in"
 	source "package/libplist/Config.in"
package/libpam-tacplus/Config.in new file +10 -0
new file mode 100644
index 0000000..1dc40ac
@@ -0,0 +1,10 @@
+ config BR2_PACKAGE_LIBPAM_TACPLUS
+        bool "libpam-tacplus"
+        help
+          Library needed to use pam-tacplus.
+          TACACS+ protocol client library and PAM module in C. This PAM
+          module support authentication, authorization (account
+          management) and accounting (session management)performed
+          using TACACS+ protocol designed by Cisco.
+
+          http://sourceforge.net/projects/tacplus/
package/libpam-tacplus/libpam-tacplus.mk new file +18 -0
new file mode 100644
index 0000000..11f9e94
@@ -0,0 +1,18 @@
+################################################################################
+#
+# libpam-tacplus
+#
+################################################################################
+
+LIBPAM_TACPLUS_VERSION = 1.3.9
+LIBPAM_TACPLUS_SITE = $(call github,jeroennijhof,pam_tacplus,$(LIBPAM_TACPLUS_VERSION))
+LIBPAM_TACPLUS_DEPENDENCIES = linux-pam
+# Fetching from github, we need to generate the configure script
+LIBPAM_TACPLUS_INSTALL_STAGING = YES
+LIBPAM_TACPLUS_AUTORECONF = YES
+LIBPAM_TACPLUS_CONF_ENV = $(TARGET_CONFIGURE_OPTS)
+LIBPAM_TACPLUS_AUTORECONF_OPTS = -I m4
+LIBPAM_TACPLUS_LICENSE = GPLv2+
+LIBPAM_TACPLUS_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 libpam-tacplus: new package

Giovanni,

Quoted 11 lines · giovanni.zantedeschi

From: "Giovanni Zantedeschi" <[email protected]>

Signed-off-by Giovanni Zantedeschi <[email protected]>

---
Changes v1 -> v2:
- Using Library instead of Lib (suggested by Ryan Barnett)
- Improved package description (suggested by Thomas Petazzoni)
- Added project site to description (suggested by Ryan Barnett)
- Changed download method (suggested by Ryan Barnett)
- Added dependency of linux-pam
- Using LIBPAM_TACPLUS_CONF_ENV instead of LIBPAM_TACPLUS_CONF_OPTS (suggested by Thomas Petazzoni)

Quoted 7 lines
---
 package/Config.in                        |  1 +
 package/libpam-tacplus/Config.in         | 10 ++++++++++
 package/libpam-tacplus/libpam-tacplus.mk | 18 ++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/libpam-tacplus/Config.in
 create mode 100644 package/libpam-tacplus/libpam-tacplus.mk

Thanks for this new version! I've applied to the next branch, after doing a few changes:

[Thomas:
- change the inclusion location in package/Config.in to be with the other linux-pam plugins.
- fix indentation of the Config.in file.
- fix build of the package when a toolchain without SSP support is used.
- fix installation location of the PAM module: it was installed in /usr/lib/security, while all other PAM modules are in /lib/security.
- adjust the ordering of the variables in the .mk file to be a bit more logical.
- remove passing of $(TARGET_CONFIGURE_OPTS) in <pkg>_CONF_ENV as it is not needed: it is already done by the autotools-package infrastructure.]

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com