ocfs2: set filesytem read-only when ocfs2_delete_entry failed.
PATCH 1/28 ocfs2: set filesytem read-only when ocfs2_delete_entry failed.
From: jiangyiwen <[email protected]>
Subject: ocfs2: set filesytem read-only when ocfs2_delete_entry failed.
In ocfs2_rename, it will lead to an inode with two entried(old and new) if ocfs2_delete_entry(old) failed. Thus, filesystem will be inconsistent.
The case is described below:
ocfs2_rename
-> ocfs2_start_trans
-> ocfs2_add_entry(new)
-> ocfs2_delete_entry(old)
-> __ocfs2_journal_access *failed* because of -ENOMEM
-> ocfs2_commit_transSo filesystem should be set to read-only at the moment.
---
fs/ocfs2/namei.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
fs/ocfs2/namei.c renamed from fs/ocfs2/namei.c~ocfs2-set-filesytem-read-only-when-ocfs2_delete_entry-failed +14 -1
@@ -1544,12 +1544,25 @@ static int ocfs2_rename(struct inode *ol status =ocfs2_find_entry (old_dentry->d_name.name, old_dentry->d_name.len, old_dir, &old_entry_lookup); -if (status) +if (status) { +if (!is_journal_aborted (osb->journal->j_journal)) { +ocfs2_error (osb->sb,"new entry %.*s is added, but old entry %.*s " +"is not deleted." , + new_dentry->d_name.len, new_dentry->d_name.name, + old_dentry->d_name.len, old_dentry->d_name.name); + } goto bail; + } status =ocfs2_delete_entry (handle, old_dir, &old_entry_lookup);if (status <0 ) {mlog_errno (status); +if (!is_journal_aborted (osb->journal->j_journal)) { +ocfs2_error (osb->sb,"new entry %.*s is added, but old entry %.*s " +"is not deleted." , + new_dentry->d_name.len, new_dentry->d_name.name, + old_dentry->d_name.len, old_dentry->d_name.name); + } goto bail; }
_
PATCH 1/28 ocfs2: set filesytem read-only when ocfs2_delete_entry failed.
Quoted 15 lines · Andrew Morton
From: jiangyiwen <[email protected]>
Subject: ocfs2: set filesytem read-only whenocfs2_delete_entryfailed.In
ocfs2_rename, it will lead to an inode with two entried(old and new) ifocfs2_delete_entry(old)failed. Thus, filesystem will be inconsistent.The case is described below:
ocfs2_rename-> ocfs2_start_trans -> ocfs2_add_entry(new) -> ocfs2_delete_entry(old) -> __ocfs2_journal_access *failed* because of -ENOMEM -> ocfs2_commit_trans
Quoted 7 lines
So filesystem should be set to read-only at the moment.
Signed-off-by Yiwen Jiang <[email protected]>Cc Joseph Qi <[email protected]>Cc Joel Becker <[email protected]>Cc Mark Fasheh <[email protected]>Signed-off-by Andrew Morton <[email protected]>
--
Mark Fasheh