Skip to contentSkip to conversation

video: discard empty video_set_lut implementation

PATCH New Peng Fan 3 participants 3 messages Jul 25, 2015 – Aug 30, 2015

Subsystems (2)
Arm i.MX and Layerscape Framebuffer layer
lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH 1/1 video: discard empty video_set_lut implementation

Discard the empty video_set_lut function from platform video drivers.

This commit "69d275458893eaec35229b589092c2a6bde5440f" introduces a weak function video_set_lut, so we do not need an strong function in platform drivers, which does nothing.

Signed-off-by Peng Fan <[email protected]>
---
 drivers/video/da8xx-fb.c     | 10 ----------
 drivers/video/mx3fb.c        |  9 ---------
 drivers/video/mxc_ipuv3_fb.c |  9 ---------
 3 files changed, 28 deletions(-)
drivers/video/da8xx-fb.c +0 -10
index 3a5f325..e2b2144 100644
@@ -1035,16 +1035,6 @@ err_release_fb:
 	return NULL;
 }
 
-void video_set_lut(unsigned int index,	/* color number */
-		    unsigned char r,	/* red */
-		    unsigned char g,	/* green */
-		    unsigned char b	/* blue */
-		    )
-{
-
-	return;
-}
-
 void da8xx_video_init(const struct da8xx_panel *panel,
 		      const struct lcd_ctrl_config *lcd_cfg, int bits_pixel)
 {
drivers/video/mx3fb.c +0 -9
index aa4cc43..3f10d5c 100644
@@ -904,12 +904,3 @@ void *video_hw_init(void)
 
 	return (void *) &panel;
 }
-
-void video_set_lut(unsigned int index,	/* color number */
-		    unsigned char r,	/* red */
-		    unsigned char g,	/* green */
-		    unsigned char b	/* blue */
-		    )
-{
-	return;
-}
drivers/video/mxc_ipuv3_fb.c +0 -9
index 1fa9531..265274b 100644
@@ -599,15 +599,6 @@ void *video_hw_init(void)
 	return (void *)&panel;
 }
 
-void video_set_lut(unsigned int index, /* color number */
-			unsigned char r,    /* red */
-			unsigned char g,    /* green */
-			unsigned char b     /* blue */
-			)
-{
-	return;
-}
-
 int ipuv3_fb_init(struct fb_videomode const *mode,
 		  uint8_t disp,
 		  uint32_t pixfmt)
Signature · 1 line
1.8.4
#1 lore raw

PATCH 1/1 video: discard empty video_set_lut implementation

Quoted 8 lines · Peng Fan

Discard the empty video_set_lut function from platform video drivers.

This commit "69d275458893eaec35229b589092c2a6bde5440f" introduces a weak function video_set_lut, so we do not need an strong function in platform drivers, which does nothing.

Signed-off-by Peng Fan <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150727/f9433d17/attachment.sig>
Applied
#2 lore raw

PATCH 1/1 video: discard empty video_set_lut implementation

In reply to Peng Fan

Hi,

Quoted 7 lines · On Sat, 25 Jul 2015 20:59:35 +0800 Peng Fan <[email protected]> wrote:

Discard the empty video_set_lut function from platform video drivers.

This commit "69d275458893eaec35229b589092c2a6bde5440f" introduces a weak function video_set_lut, so we do not need an strong function in platform drivers, which does nothing.

Quoted 6 lines
Signed-off-by Peng Fan <[email protected]>
---
 drivers/video/da8xx-fb.c     | 10 ----------
 drivers/video/mx3fb.c        |  9 ---------
 drivers/video/mxc_ipuv3_fb.c |  9 ---------
 3 files changed, 28 deletions(-)

applied, thanks!

Anatolij