Skip to contentSkip to conversation

Christopher Larson : update-rc.d.bbclass: explicitly dep on initscripts

oe-commits Martin Jansa 4 participants 4 messages Aug 31, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 18 lines · On Sun, Aug 30, 2015 at 11:48:19AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 833302761df924bb503cc2ad04ecae1023381f8f
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=833302761df924bb503cc2ad04ecae1023381f8f
Author: Christopher Larson <[email protected]>
Date:   Mon Aug 24 15:18:34 2015 -0700

update-rc.d.bbclass: explicitly dep on initscripts

update-rc.d doesn't just want an initscripts package, it wants initscripts-functions. In the case where VIRTUAL-RUNTIME_initscripts is set to nothing, update-rc.d still needs initscripts-functions to satisfy its runtime dependencies. Further, we shouldn't be using a *runtime* virtual in a *build time* variable. This should resolve image creation failures with configurations without sysv initscripts when a recipe inherits update-rc.d and doesn't inherit systemd.

Quoted 1 line

(From OE-Core rev: e6642ae0849e5ac3174c643a7693af25d829d6d1)

Unfortunately this means that I cannot PNBLACKLIST initscripts recipe in DISTRO which provides own initscripts implementation (which also provides initscripts-functions).

What's even worse is that I'll have to overlay whole bbclass to get rid of this dependency :/

Regards,

Quoted 29 lines

---

 meta/classes/update-rc.d.bbclass | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta/classes/update-rc.d.bbclass +1 -3
index 6a08315..2a0a74a 100644
@@ -1,8 +1,6 @@
 UPDATERCPN ?= "${PN}"
 
-DEPENDS_append_class-target = " update-rc.d-native update-rc.d"
-VIRTUAL-RUNTIME_initscripts ?= "initscripts"
-DEPENDS_append_class-target = " ${VIRTUAL-RUNTIME_initscripts}"
+DEPENDS_append_class-target = " update-rc.d-native update-rc.d initscripts"
 UPDATERCD = "update-rc.d"
 UPDATERCD_class-cross = ""
 UPDATERCD_class-native = ""
Signature · 5 lines
-- 
_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 24 lines · Martin Jansa
Quoted 4 lines · On Sun, Aug 30, 2015 at 11:48:19AM +0000, [email protected] wrote:

Module: openembedded-core.git
Branch: master
Commit: 833302761df924bb503cc2ad04ecae1023381f8f
URL:

http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=833302761df924bb503cc2ad04ecae1023381f8f

Quoted 8 lines
Author: Christopher Larson <[email protected]>
Date:   Mon Aug 24 15:18:34 2015 -0700

update-rc.d.bbclass: explicitly dep on initscripts

update-rc.d doesn't just want an initscripts package, it wants initscripts-functions. In the case where VIRTUAL-RUNTIME_initscripts is

set to

Quoted 1 line

nothing, update-rc.d still needs initscripts-functions to satisfy its

runtime

Quoted 1 line

dependencies. Further, we shouldn't be using a *runtime* virtual in a

*build

Quoted 2 lines

time* variable. This should resolve image creation failures with configurations without sysv initscripts when a recipe inherits

update-rc.d and

Quoted 2 lines

doesn't inherit systemd.

Quoted 9 lines
Quoted 1 line

(From OE-Core rev: e6642ae0849e5ac3174c643a7693af25d829d6d1)

Unfortunately this means that I cannot PNBLACKLIST initscripts recipe in DISTRO which provides own initscripts implementation (which also provides initscripts-functions).

What's even worse is that I'll have to overlay whole bbclass to get rid of this dependency :/

Of course you can. This is a build dependency. Add a PROVIDES += "initscripts" + appropriate preferences. Alternatively, we could introduce a virtual/initscripts-functions.

Signature · 5 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#3 lore raw
In reply to Martin Jansa
Quoted 10 lines · Martin Jansa
Quoted 10 lines

update-rc.d.bbclass: explicitly dep on initscripts

update-rc.d doesn't just want an initscripts package, it wants initscripts-functions. In the case where VIRTUAL-RUNTIME_initscripts is set to nothing, update-rc.d still needs initscripts-functions to satisfy its runtime dependencies. Further, we shouldn't be using a *runtime* virtual in a *build time* variable. This should resolve image creation failures with configurations without sysv initscripts when a recipe inherits update-rc.d and doesn't inherit systemd.

Quoted 9 lines
Quoted 1 line

(From OE-Core rev: e6642ae0849e5ac3174c643a7693af25d829d6d1)

Unfortunately this means that I cannot PNBLACKLIST initscripts recipe in DISTRO which provides own initscripts implementation (which also provides initscripts-functions).

What's even worse is that I'll have to overlay whole bbclass to get rid of this dependency :/

would it help if initscript-functions was also PROVIDED by initscript replacement ?

#4 lore raw
In reply to Martin Jansa
Quoted 24 lines · On Monday, August 31, 2015, Martin Jansa <[email protected]…
Quoted 4 lines · On Sun, Aug 30, 2015 at 11:48:19AM +0000, [email protected] wrote:

Module: openembedded-core.git
Branch: master
Commit: 833302761df924bb503cc2ad04ecae1023381f8f
URL:

http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=833302761df924bb503cc2ad04ecae1023381f8f

Quoted 8 lines
Author: Christopher Larson <[email protected]>
Date:   Mon Aug 24 15:18:34 2015 -0700

update-rc.d.bbclass: explicitly dep on initscripts

update-rc.d doesn't just want an initscripts package, it wants initscripts-functions. In the case where VIRTUAL-RUNTIME_initscripts is

set to

Quoted 1 line

nothing, update-rc.d still needs initscripts-functions to satisfy its

runtime

Quoted 1 line

dependencies. Further, we shouldn't be using a *runtime* virtual in a

*build

Quoted 2 lines

time* variable. This should resolve image creation failures with configurations without sysv initscripts when a recipe inherits

update-rc.d and

Quoted 2 lines

doesn't inherit systemd.

Quoted 8 lines
Quoted 1 line

(From OE-Core rev: e6642ae0849e5ac3174c643a7693af25d829d6d1)

Unfortunately this means that I cannot PNBLACKLIST initscripts recipe in DISTRO which provides own initscripts implementation (which also provides initscripts-functions).

What's even worse is that I'll have to overlay whole bbclass to get rid of this dependency :/

Of course you can. This is a build dependency. Add a PROVIDES += "initscripts" + appropriate preferences (or keep your PNBLACKLIST). This is precisely what provides is for. Alternatively, we could introduce a virtual/initscripts-functions rather than using 'initscripts' for this. In either case, you don't need to override anything.

Signature · 5 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics