Skip to contentSkip to conversation

python-urwid: bump version and add checksums

PATCH Superseded Christophe Vu-Brugier 4 participants 14 messages Sep 1, 2015 – Sep 16, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 python-urwid: bump version and add checksums

---
 package/python-urwid/python-urwid.hash | 3 +++
 package/python-urwid/python-urwid.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/python-urwid/python-urwid.hash
package/python-urwid/python-urwid.hash new file +3 -0
new file mode 100644
index 0000000..2b18082
@@ -0,0 +1,3 @@
+# md from https://pypi.python.org/pypi?:action=show_md5&digest=a989acd54f4ff1a554add464803a9175, sha256 locally computed
+md5  	a989acd54f4ff1a554add464803a9175  urwid-1.3.0.tar.gz
+sha256	29f04fad3bf0a79c5491f7ebec2d50fa086e9d16359896c9204c6a92bc07aba2  urwid-1.3.0.tar.gz
package/python-urwid/python-urwid.mk +1 -1
index 4f1be46..1cd3022 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PYTHON_URWID_VERSION = 1.2.1
+PYTHON_URWID_VERSION = 1.3.0
 PYTHON_URWID_SOURCE = urwid-$(PYTHON_URWID_VERSION).tar.gz
 PYTHON_URWID_SITE = https://pypi.python.org/packages/source/u/urwid
 PYTHON_URWID_LICENSE = LGPLv2.1+
Signature · 1 line
2.5.0
#1 lore raw

PATCH 2/6 python-pyparsing: bump version

Also download tarball from PyPI instead of SourceForge.

---
 package/python-pyparsing/python-pyparsing.hash | 5 +++--
 package/python-pyparsing/python-pyparsing.mk   | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)
package/python-pyparsing/python-pyparsing.hash +3 -2
index aee93af..df39116 100644
@@ -1,2 +1,3 @@
-# Locally computed:
-sha256  17e43d6b17588ed5968735575b3983a952133ec4082596d214d7090b56d48a06  pyparsing-2.0.2.tar.gz
+# md5 from https://pypi.python.org/pypi?:action=show_md5&digest=0fe479be09fc2cf005f753d3acc35939, sha256 locally computed
+md5	0fe479be09fc2cf005f753d3acc35939  pyparsing-2.0.3.tar.gz
+sha256  06e729e1cbf5274703b1f47b6135ed8335999d547f9d8cf048b210fb8ebf844f  pyparsing-2.0.3.tar.gz
package/python-pyparsing/python-pyparsing.mk +2 -2
index 8e83f34..ad066b8 100644
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-PYTHON_PYPARSING_VERSION = 2.0.2
+PYTHON_PYPARSING_VERSION = 2.0.3
 PYTHON_PYPARSING_SOURCE = pyparsing-$(PYTHON_PYPARSING_VERSION).tar.gz
-PYTHON_PYPARSING_SITE = http://downloads.sourceforge.net/project/pyparsing/pyparsing/pyparsing-$(PYTHON_PYPARSING_VERSION)
+PYTHON_PYPARSING_SITE = https://pypi.python.org/packages/source/p/pyparsing
 PYTHON_PYPARSING_LICENSE = MIT
 PYTHON_PYPARSING_LICENSE_FILES = LICENSE
 PYTHON_PYPARSING_SETUP_TYPE = distutils
Signature · 1 line
2.5.0
#2 lore raw

PATCH 3/6 python-rtslib-fb: bump version

In reply to Christophe Vu-Brugier

Also add new dependency to python-six.

---
 package/python-rtslib-fb/python-rtslib-fb.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/python-rtslib-fb/python-rtslib-fb.mk +2 -1
index d45c261..85bee0b 100644
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-PYTHON_RTSLIB_FB_VERSION = v2.1.fb50
+PYTHON_RTSLIB_FB_VERSION = v2.1.fb57
 PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION))
 PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
 PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING
 PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools
+PYTHON_RTSLIB_FB_DEPENDENCIES = python-six
 
 $(eval $(python-package))
Signature · 1 line
2.5.0
#3 lore raw

PATCH 3/6 python-rtslib-fb: bump version

Hi Christophe,

Quoted 12 lines · Christophe Vu-Brugier

Also add new dependency to python-six.

---
 package/python-rtslib-fb/python-rtslib-fb.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/python-rtslib-fb/python-rtslib-fb.mk +0 -0
index d45c261..85bee0b 100644

package/python-rtslib-fb/python-rtslib-fb.mk line 12

Quoted 10 lines
package/python-rtslib-fb/python-rtslib-fb.mk +2 -1
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-PYTHON_RTSLIB_FB_VERSION = v2.1.fb50
+PYTHON_RTSLIB_FB_VERSION = v2.1.fb57
 PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION))
 PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
 PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING
 PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools
+PYTHON_RTSLIB_FB_DEPENDENCIES = python-six

You should select BR2_PACKAGE_PYTHON_SIX in Config.in. Same for other package bumps adding python-six dependency in this series.

package/python-rtslib-fb/python-rtslib-fb.mk line 14

Quoted 1 line
package/python-rtslib-fb/python-rtslib-fb.mk +0 -0
 $(eval $(python-package))

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#4 lore raw

PATCH 4/6 python-configshell-fb: bump version

In reply to Christophe Vu-Brugier

Also add new dependency to python-six.

---
 package/python-configshell-fb/python-configshell-fb.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/python-configshell-fb/python-configshell-fb.mk +2 -2
index 76ef48d..d0671d5 100644
@@ -4,11 +4,11 @@
 #
 ################################################################################
 
-PYTHON_CONFIGSHELL_FB_VERSION = v1.1.fb15
+PYTHON_CONFIGSHELL_FB_VERSION = v1.1.fb18
 PYTHON_CONFIGSHELL_FB_SITE = $(call github,agrover,configshell-fb,$(PYTHON_CONFIGSHELL_FB_VERSION))
 PYTHON_CONFIGSHELL_FB_LICENSE = Apache-2.0
 PYTHON_CONFIGSHELL_FB_LICENSE_FILES = COPYING
 PYTHON_CONFIGSHELL_FB_SETUP_TYPE = setuptools
-PYTHON_CONFIGSHELL_FB_DEPENDENCIES = python-pyparsing python-urwid
+PYTHON_CONFIGSHELL_FB_DEPENDENCIES = python-pyparsing python-six python-urwid
 
 $(eval $(python-package))
Signature · 1 line
2.5.0
#5 lore raw

PATCH 5/6 targetcli-fb: bump version

In reply to Christophe Vu-Brugier

Also add new dependency to python-six.

---
 package/targetcli-fb/targetcli-fb.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/targetcli-fb/targetcli-fb.mk +2 -2
index b5f2fbe..0a64c46 100644
@@ -4,12 +4,12 @@
 #
 ################################################################################
 
-TARGETCLI_FB_VERSION = v2.1.fb37
+TARGETCLI_FB_VERSION = v2.1.fb41
 TARGETCLI_FB_SITE = $(call github,agrover,targetcli-fb,$(TARGETCLI_FB_VERSION))
 TARGETCLI_FB_LICENSE = Apache-2.0
 TARGETCLI_FB_LICENSE_FILES = COPYING
 TARGETCLI_FB_SETUP_TYPE = setuptools
-TARGETCLI_FB_DEPENDENCIES = python-configshell-fb python-rtslib-fb
+TARGETCLI_FB_DEPENDENCIES = python-configshell-fb python-rtslib-fb python-six
 
 define TARGETCLI_FB_INSTALL_INIT_SYSV
 	$(INSTALL) -m 0755 -D package/targetcli-fb/S50target $(TARGET_DIR)/etc/init.d/S50target
Signature · 1 line
2.5.0
#6 lore raw

PATCH 6/6 targetcli-fb: systemd support

In reply to Christophe Vu-Brugier

The systemd service file is taken from Fedora.

---
 package/targetcli-fb/target.service  | 14 ++++++++++++++
 package/targetcli-fb/targetcli-fb.mk |  8 +++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 package/targetcli-fb/target.service
package/targetcli-fb/target.service new file +14 -0
new file mode 100644
index 0000000..400284e
@@ -0,0 +1,14 @@
+[Unit]
+Description=Restore LIO kernel target configuration
+Requires=sys-kernel-config.mount
+After=sys-kernel-config.mount network.target local-fs.target
+
+[Service]
+Type=oneshot
+RemainAfterExit=yes
+ExecStart=/usr/bin/targetctl restore
+ExecStop=/usr/bin/targetctl clear
+SyslogIdentifier=target
+
+[Install]
+WantedBy=multi-user.target
package/targetcli-fb/targetcli-fb.mk +7 -1
index 0a64c46..cf7f29f 100644
@@ -12,7 +12,13 @@ TARGETCLI_FB_SETUP_TYPE = setuptools
 TARGETCLI_FB_DEPENDENCIES = python-configshell-fb python-rtslib-fb python-six
 
 define TARGETCLI_FB_INSTALL_INIT_SYSV
-	$(INSTALL) -m 0755 -D package/targetcli-fb/S50target $(TARGET_DIR)/etc/init.d/S50target
+	$(INSTALL) -m 0755 -D package/targetcli-fb/S50target \
+		$(TARGET_DIR)/etc/init.d/S50target
+endef
+
+define TARGETCLI_FB_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -m 0644 -D package/targetcli-fb/target.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/target.service
 endef
 
 # Targetcli stores its configuration in /etc/target/saveconfig.json
Signature · 1 line
2.5.0
#7 lore raw

PATCH 1/6 python-urwid: bump version and add checksums

In reply to Christophe Vu-Brugier

Hi Christophe,

Quoted 13 lines · Christophe Vu-Brugier
---
 package/python-urwid/python-urwid.hash | 3 +++
 package/python-urwid/python-urwid.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/python-urwid/python-urwid.hash
package/python-urwid/python-urwid.hash new file +0 -0
new file mode 100644
index 0000000..2b18082

package/python-urwid/python-urwid.hash line 1

Quoted 1 line
package/python-urwid/python-urwid.hash new file +1 -0
@@ -0,0 +1,3 @@
+# md from https://pypi.python.org/pypi?:action=show_md5&digest=a989acd54f4ff1a554add464803a9175, sha256 locally computed

This is weird. You put the MD5 in the URL to retrieve the same MD5? Is there a way to lookup the MD5 using the package name? If not, I guess that
https://pypi.python.org/pypi/urwid/1.3.0 would be good enough.

Quoted 7 lines
package/python-urwid/python-urwid.hash new file +2 -0
+md5  	a989acd54f4ff1a554add464803a9175  urwid-1.3.0.tar.gz
+sha256	29f04fad3bf0a79c5491f7ebec2d50fa086e9d16359896c9204c6a92bc07aba2  urwid-1.3.0.tar.gz
package/python-urwid/python-urwid.mk +0 -0
index 4f1be46..1cd3022 100644

package/python-urwid/python-urwid.mk line 10

Quoted 8 lines
package/python-urwid/python-urwid.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PYTHON_URWID_VERSION = 1.2.1
+PYTHON_URWID_VERSION = 1.3.0
 PYTHON_URWID_SOURCE = urwid-$(PYTHON_URWID_VERSION).tar.gz
 PYTHON_URWID_SITE = https://pypi.python.org/packages/source/u/urwid
 PYTHON_URWID_LICENSE = LGPLv2.1+

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#8 lore raw

PATCH 1/6 python-urwid: bump version and add checksums

Hi Baruch,

Thank you for your review!

Quoted 8 lines · Baruch Siach
Quoted 7 lines · Christophe Vu-Brugier
---
 package/python-urwid/python-urwid.hash | 3 +++
 package/python-urwid/python-urwid.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/python-urwid/python-urwid.hash
Quoted 11 lines

package/python-urwid/python-urwid.hash line 1

Quoted 7 lines
package/python-urwid/python-urwid.hash new file +1 -0
new file mode 100644
index 0000000..2b18082
@@ -0,0 +1,3 @@
+# md from https://pypi.python.org/pypi?:action=show_md5&digest=a989acd54f4ff1a554add464803a9175, sha256 locally computed

This is weird. You put the MD5 in the URL to retrieve the same MD5? Is there a way to lookup the MD5 using the package name? If not, I guess that
https://pypi.python.org/pypi/urwid/1.3.0 would be good enough.

I noticed that other packages downloaded from PyPI (e.g. python-tornado, python-requests) have the same header in their hash file and decided to do the same.

I am not aware of a way to lookup the checksum from the package name. The only association I see between a package name and its checksum is the URL to download a package from PyPI. For instance:

https://pypi.python.org/packages/source/u/urwid/urwid-1.3.0.tar.gz#md5=a989acd54f4ff1a554add464803a9175

The "show_md5" action displays the MD5 if it is known. For instance :

https://pypi.python.org/pypi?:action=show_md5&digest=a989acd54f4ff1a554add464803a9175
displays a989acd54f4ff1a554add464803a9175

Whereas

https://pypi.python.org/pypi?:action=show_md5&digest=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
displays 404 not found

Anyway, I am OK with using https://pypi.python.org/pypi/urwid/1.3.0 or
https://pypi.python.org/packages/source/u/urwid/urwid-1.3.0.tar.gz#md5=a989acd54f4ff1a554add464803a9175
if you prefer.

What do other developers think? What is the best header for the hash file of a PyPI package?

With best regards,

Signature · 1 line
Christophe Vu-Brugier
#9 lore raw

PATCH 1/6 python-urwid: bump version and add checksums

In reply to Baruch Siach
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Hi Christophe,

Quoted 7 lines · Christophe Vu-Brugier

---
package/python-urwid/python-urwid.hash | 3 +++
package/python-urwid/python-urwid.mk | 2 +-

2 files changed, 4 insertions(+), 1 deletion(-)

create mode 100644 package/python-urwid/python-urwid.hash

Quoted 13 lines
Quoted 9 lines
package/python-urwid/python-urwid.hash new file +1 -0
new file mode 100644
index 0000000..2b18082
@@ -0,0 +1,3 @@
+# md from

https://pypi.python.org/pypi?:action=show_md5&digest=a989acd54f4ff1a554add464803a9175,
sha256 locally computed

This is weird. You put the MD5 in the URL to retrieve the same MD5? Is there a way to lookup the MD5 using the package name? If not, I guess that
https://pypi.python.org/pypi/urwid/1.3.0 would be good enough.

Yeah, the upstream pypi hash URLs are kind of odd. These are the official links though.

Signature · 1 line
Bye, Peter Korsgaard
#10 lore raw

PATCH 1/6 python-urwid: bump version and add checksums

Hi Peter,

Quoted 24 lines · Peter Korsgaard
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Quoted 7 lines · Christophe Vu-Brugier

---
package/python-urwid/python-urwid.hash | 3 +++
package/python-urwid/python-urwid.mk | 2 +-

2 files changed, 4 insertions(+), 1 deletion(-)

create mode 100644 package/python-urwid/python-urwid.hash

Quoted 13 lines
Quoted 9 lines
package/python-urwid/python-urwid.hash new file +1 -0
new file mode 100644
index 0000000..2b18082
@@ -0,0 +1,3 @@
+# md from

https://pypi.python.org/pypi?:action=show_md5&digest=a989acd54f4ff1a554add464803a9175,
sha256 locally computed

This is weird. You put the MD5 in the URL to retrieve the same MD5? Is there a way to lookup the MD5 using the package name? If not, I guess that
https://pypi.python.org/pypi/urwid/1.3.0 would be good enough.

Quoted 2 lines

Yeah, the upstream pypi hash URLs are kind of odd. These are the official links though.

The .hash file is all about trust, IMO. Seeing md5 that is an identity function of the URL just makes me feel uneasy. The package URL at
https://pypi.python.org/pypi/urwid/1.3.0 contains the same link (next to the file name), but it looks less easy to trick.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#11 lore raw

PATCH 1/6 python-urwid: bump version and add checksums

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 2 lines

Yeah, the upstream pypi hash URLs are kind of odd. These are the official links though.

The .hash file is all about trust, IMO. Seeing md5 that is an identity function of the URL just makes me feel uneasy. The package URL at
https://pypi.python.org/pypi/urwid/1.3.0 contains the same link (next to the file name), but it looks less easy to trick.

Yes, I agree. As long as we have a stronger hash locally computed it isn't a big deal, but it would be good if the pypi guys could do something more sensible. I'm not sure who to contact about that though.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard 
#12 lore raw

PATCH 1/6 python-urwid: bump version and add checksums

In reply to Christophe Vu-Brugier

Dear Zhristophe Vu-Brugier,

could you please mark this v1 patch series as superseded in patchwork? Thanks.

Regards,

Vincent.

Quoted 30 lines · Christophe Vu-Brugier
---
 package/python-urwid/python-urwid.hash | 3 +++
 package/python-urwid/python-urwid.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/python-urwid/python-urwid.hash
package/python-urwid/python-urwid.hash new file +3 -0
new file mode 100644
index 0000000..2b18082
@@ -0,0 +1,3 @@
+# md from https://pypi.python.org/pypi?:action=show_md5&digest=a989acd54f4ff1a554add464803a9175, sha256 locally computed
+md5  	a989acd54f4ff1a554add464803a9175  urwid-1.3.0.tar.gz
+sha256	29f04fad3bf0a79c5491f7ebec2d50fa086e9d16359896c9204c6a92bc07aba2  urwid-1.3.0.tar.gz
package/python-urwid/python-urwid.mk +1 -1
index 4f1be46..1cd3022 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PYTHON_URWID_VERSION = 1.2.1
+PYTHON_URWID_VERSION = 1.3.0
 PYTHON_URWID_SOURCE = urwid-$(PYTHON_URWID_VERSION).tar.gz
 PYTHON_URWID_SITE = https://pypi.python.org/packages/source/u/urwid
 PYTHON_URWID_LICENSE = LGPLv2.1+
#13 lore raw

PATCH 1/6 python-urwid: bump version and add checksums

Dear Vincent,

Quoted 2 lines · Vicente Olivert Riera

could you please mark this v1 patch series as superseded in patchwork? Thanks.

Done: I have marked the whole v1 patch serie as superseded. Also thank you for reviewing and testing v2.

Best regards,

Signature · 1 line
Christophe Vu-Brugier