clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

PATCH Superseded Romain Perier 3 participants 10 messages Aug 23, 2015 – Sep 10, 2015

Subsystems (2)

Common clk Arm Rockchip

lore

Share & tools

lore

Romain Perier

author

2015-08-23 09:32 UTC #0 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

Now that the rockchip clock subsystem does clock gating with GPIO banks, these are no longer enabled once during probe and no longer stay enabled for eternity. When all these clocks are disabled, the parent clock pclk_peri might be disabled too, as no other child claims it. So, we need to add pclk_peri to the critical clocks.

Signed-off-by Romain Perier <[email protected]>

Tested-by Michael Niewoehner <[email protected]>

---

changes in v2:
- Improved commit messages
- Added "Tested-by" from Michael Niewoehner, as he tested v1 and no code changed

 drivers/clk/rockchip/clk-rk3188.c | 1 +
 1 file changed, 1 insertion(+)

drivers/clk/rockchip/clk-rk3188.c +1 -0

index bf20214..839a22a 100644
@@ -717,6 +717,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
 	"aclk_peri",
 	"hclk_peri",
 	"pclk_cpu",
+	"pclk_peri",
 };
 
 static void __init rk3188_common_clk_init(struct device_node *np)

Signature · 1 line

2.1.4

Romain Perier

author

2015-08-31 14:42 UTC #1 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

ping

2015-08-23 11:32 GMT+02:00 Romain Perier <[email protected]>:

Quoted 32 lines

Now that the rockchip clock subsystem does clock gating with GPIO banks, these are no longer enabled once during probe and no longer stay enabled for eternity. When all these clocks are disabled, the parent clock pclk_peri might be disabled too, as no other child claims it. So, we need to add pclk_peri to the critical clocks.
Signed-off-by Romain Perier <[email protected]>
Tested-by Michael Niewoehner <[email protected]>
---
changes in v2:
- Improved commit messages
- Added "Tested-by" from Michael Niewoehner, as he tested v1 and no code changed
 drivers/clk/rockchip/clk-rk3188.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/rockchip/clk-rk3188.c +1 -1
index bf20214..839a22a 100644
@@ -717,6 +717,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
        "aclk_peri",
        "hclk_peri",
        "pclk_cpu",
+       "pclk_peri",
 };
 
 static void __init rk3188_common_clk_init(struct device_node *np)
--
2.1.4

Romain Perier

author

2015-09-04 06:50 UTC #2 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

Hi all,

just a reminder, I sent this patch two weeks ago, rk3xxx-based platforms still need it, it fixes a freeze during boot.

Regards,
Romain

2015-08-31 16:42 GMT+02:00 Romain Perier <[email protected]>:

Quoted 35 lines

ping
2015-08-23 11:32 GMT+02:00 Romain Perier <[email protected]>:
Quoted 32 lines
Now that the rockchip clock subsystem does clock gating with GPIO banks, these are no longer enabled once during probe and no longer stay enabled for eternity. When all these clocks are disabled, the parent clock pclk_peri might be disabled too, as no other child claims it. So, we need to add pclk_peri to the critical clocks.
Signed-off-by Romain Perier <[email protected]>
Tested-by Michael Niewoehner <[email protected]>
---
changes in v2:
- Improved commit messages
- Added "Tested-by" from Michael Niewoehner, as he tested v1 and no code changed
 drivers/clk/rockchip/clk-rk3188.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/rockchip/clk-rk3188.c +1 -1
index bf20214..839a22a 100644
@@ -717,6 +717,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
        "aclk_peri",
        "hclk_peri",
        "pclk_cpu",
+       "pclk_peri",
 };
 
 static void __init rk3188_common_clk_init(struct device_node *np)
--
2.1.4

Stephen Boyd

2015-09-04 16:24 UTC #3 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

Quoted 4 lines · Romain Perier

Hi all,
just a reminder, I sent this patch two weeks ago, rk3xxx-based platforms still need it, it fixes a freeze during boot.

Sorry I thought that Linus W was going to pick this up? If not, we can take it through clk tree as a fix for -rc1.

Signature · 2 lines

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Romain Perier

author

2015-09-05 16:12 UTC #4 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

Np,

Yes it would be nice to take it for -rc1, because I think that 4.3 won't boot without this fix

Regards,
Romain

2015-09-04 18:24 GMT+02:00 Stephen Boyd <[email protected]>:

Quoted 12 lines · Romain Perier

Quoted 4 lines
Hi all,
just a reminder, I sent this patch two weeks ago, rk3xxx-based platforms still need it, it fixes a freeze during boot.
Sorry I thought that Linus W was going to pick this up? If not, we can take it through clk tree as a fix for -rc1.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Romain Perier

author

2015-09-09 17:58 UTC #5 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

so, which of you does take the patch for -rc1 ?

Regards,
Romain

2015-09-05 18:12 GMT+02:00 Romain Perier <[email protected]>:

Quoted 22 lines

Np,
Yes it would be nice to take it for -rc1, because I think that 4.3 won't boot without this fix
Regards,
Romain
2015-09-04 18:24 GMT+02:00 Stephen Boyd <[email protected]>:
Quoted 12 lines · Romain Perier
Quoted 4 lines
Hi all,
just a reminder, I sent this patch two weeks ago, rk3xxx-based platforms still need it, it fixes a freeze during boot.
Sorry I thought that Linus W was going to pick this up? If not, we can take it through clk tree as a fix for -rc1.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Stephen Boyd

2015-09-09 21:47 UTC #6 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

Quoted 2 lines · Romain Perier

so, which of you does take the patch for -rc1 ?

Please stop top posting. I was going to take it after -rc1 is tagged, but I can't tell what branch this is based on. It doesn't apply to clk-next, nor to torvalds' tree, or linux-next. Is there some other patch out there that's also needed?

Signature · 2 lines

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Romain Perier

author

2015-09-10 07:05 UTC #7 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

It was based on linux-next few weeks ago. I will rebase it today and send a v3.

2015-09-09 23:47 GMT+02:00 Stephen Boyd <[email protected]>:

Quoted 4 lines · Romain Perier

Quoted 2 lines
so, which of you does take the patch for -rc1 ?
Is there some other patch out there that's also needed?

No, that's a single patch.

Romain

Michael Niewoehner

2015-09-10 16:40 UTC #8 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

Am 10.09.2015 um 09:05 schrieb Romain Perier <[email protected]>:

Quoted 12 lines

It was based on linux-next few weeks ago. I will rebase it today and send a v3.
2015-09-09 23:47 GMT+02:00 Stephen Boyd <[email protected]>:
Quoted 4 lines · Romain Perier
Quoted 2 lines
so, which of you does take the patch for -rc1 ?
Is there some other patch out there that's also needed?
No, that's a single patch.
Romain

Hi Stephen,

Romain?s patch was applied after mine in his github tree so you?ll need to apply that first: [PATCH v3] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

Best regards
Michael

Stephen Boyd

2015-09-10 20:51 UTC #9 lore raw

PATCH v2 1/1 clk: rockchip: Add pclk_peri to critical clocks on RK3066/RK3188

Quoted 11 lines · Michael Niewoehner

Am 10.09.2015 um 09:05 schrieb Romain Perier <[email protected]>:
Quoted 8 lines
It was based on linux-next few weeks ago. I will rebase it today and send a v3.
2015-09-09 23:47 GMT+02:00 Stephen Boyd <[email protected]>:
Quoted 4 lines · Romain Perier
Quoted 2 lines
so, which of you does take the patch for -rc1 ?
Is there some other patch out there that's also needed?

Quoted 9 lines

Quoted 4 lines
No, that's a single patch.
Romain
Hi Stephen,
Romain?s patch was applied after mine in his github tree so you?ll need to apply that first: [PATCH v3] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

Ah ok. Consider both applied to clk-fixes.

Signature · 2 lines

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project