Input: walkera0701 - fix abs() calculations on 64 bit values
Subsystems (2)
Dmitry Torokhov
maintainerPATCH 1/1 Input: walkera0701 - fix abs() calculations on 64 bit values
abs() function can not be used with 64 bit values, so let's switch to abs64(). From include/linux/kernel.h:
/*
* abs() handles unsigned and signed longs, ints, shorts and chars.
* For all input types abs() returns a signed long.
* abs() should not be used for 64-bit types (s64, u64, long long)
* - use abs64() for those.
*/
Reported-by Joe Perches <[email protected]>
Signed-off-by Dmitry Torokhov <[email protected]>
--- drivers/input/joystick/walkera0701.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/input/joystick/walkera0701.c +2 -2
@@ -150,7 +150,7 @@ static void walkera0701_irq_handler(void *handler_data)if (w->counter ==24 ) {/* full frame */ walkera0701_parse_frame (w); w->counter =NO_SYNC ; -if (abs (pulse_time -SYNC_PULSE ) <RESERVE )/* new frame sync */ +if (abs64 (pulse_time -SYNC_PULSE ) <RESERVE )/* new frame sync */ w->counter =0 ; }else { if ((pulse_time > (ANALOG_MIN_PULSE - RESERVE)
@@ -161,7 +161,7 @@ static void walkera0701_irq_handler(void *handler_data) }else w->counter =NO_SYNC ; } - }else if (abs (pulse_time -SYNC_PULSE -BIN0_PULSE ) < + }else if (abs64 (pulse_time -SYNC_PULSE -BIN0_PULSE ) <RESERVE +BIN1_PULSE -BIN0_PULSE )/* frame sync .. */ w->counter =0 ;
Signature · 5 lines
2.5.0.457.gab17608 -- Dmitry