Skip to contentSkip to conversation

Fix elf2flt build when LTO is enabled

PATCH Superseded Douglas RAILLARD 3 participants 5 messages Sep 5, 2015 – Sep 20, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 2/3 Fix elf2flt build when LTO is enabled

---
 package/elf2flt/elf2flt.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/elf2flt/elf2flt.mk +6 -0
index 3fcada4..d028259 100644
@@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
 	--with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
 	--target=$(GNU_TARGET_NAME)
 
+
 HOST_ELF2FLT_CONF_ENV = LIBS=-lz
 
+ifeq ($(BR2_GCC_ENABLE_LTO),y)
+	HOST_ELF2FLT_CONF_ENV = LIBS="-lz -ldl"
+endif
+
+
 $(eval $(host-autotools-package))
Signature · 1 line
2.5.1
#1 lore raw

PATCH 2/3 Fix elf2flt build when LTO is enabled

Dear Douglas RAILLARD,

package/elf2flt/elf2flt.mk HOST_ELF2FLT_CONF_OPTS = \ · line 24

Quoted 9 lines · Douglas RAILLARD
package/elf2flt/elf2flt.mk +1 -0
index 3fcada4..d028259 100644
@@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
 	--with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
 	--target=$(GNU_TARGET_NAME)
 
+

Unnecessary new line addition.

package/elf2flt/elf2flt.mk HOST_ELF2FLT_CONF_OPTS = \ · line 28

Quoted 4 lines
package/elf2flt/elf2flt.mk +2 -0
 HOST_ELF2FLT_CONF_ENV = LIBS=-lz
 
+ifeq ($(BR2_GCC_ENABLE_LTO),y)
+	HOST_ELF2FLT_CONF_ENV = LIBS="-lz -ldl"

Don't intend variables.

Also, please change this to:

HOST_ELF2FLT_LIBS = -lz

ifeq ($(BR2_GCC_ENABLE_LTO),y)
HOST_ELF2FLT_LIBS += -ldl
endif

HOST_ELF2FLT_CONF_ENV = LIBS="$(HOST_ELF2FLT_LIBS)"

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 2/3 elf2flt: fix build when LTO is enabled

---
 package/elf2flt/elf2flt.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
package/elf2flt/elf2flt.mk +7 -1
index 3fcada4..bec270b 100644
@@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
 	--with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
 	--target=$(GNU_TARGET_NAME)
 
-HOST_ELF2FLT_CONF_ENV = LIBS=-lz
+HOST_ELF2FLT_LIBS = -lz
+
+ifeq ($(BR2_GCC_ENABLE_LTO),y)
+HOST_ELF2FLT_LIBS += -ldl
+endif
+
+HOST_ELF2FLT_CONF_ENV = LIBS="$(HOST_ELF2FLT_LIBS)"
 
 $(eval $(host-autotools-package))
Signature · 1 line
2.5.1
#3 lore raw

PATCH v2 2/3 elf2flt: fix build when LTO is enabled

Douglas, All,

On 2015-09-06 17:48 +0200, Douglas RAILLARD spake thusly:

Quoted 1 line

Regards,
Yann E. MORIN.

Quoted 29 lines
---
 package/elf2flt/elf2flt.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
package/elf2flt/elf2flt.mk +7 -1
index 3fcada4..bec270b 100644
@@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
 	--with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
 	--target=$(GNU_TARGET_NAME)
 
-HOST_ELF2FLT_CONF_ENV = LIBS=-lz
+HOST_ELF2FLT_LIBS = -lz
+
+ifeq ($(BR2_GCC_ENABLE_LTO),y)
+HOST_ELF2FLT_LIBS += -ldl
+endif
+
+HOST_ELF2FLT_CONF_ENV = LIBS="$(HOST_ELF2FLT_LIBS)"
 
 $(eval $(host-autotools-package))
Signature · 6 lines
2.5.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH v2 2/3 elf2flt: fix build when LTO is enabled

In reply to Douglas RAILLARD

Dear Douglas RAILLARD,

Quoted 4 lines · Douglas RAILLARD
---
 package/elf2flt/elf2flt.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com