Skip to contentSkip to conversation

configure: Require Python 2.6

PATCH In review Markus Armbruster 6 participants 10 messages Sep 4, 2015 – Oct 1, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Require Python 2.6

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

---
 configure | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
configure +4 -8
index 21c4089..bce1769 100755
@@ -1157,18 +1157,14 @@ fi
 
 # Note that if the Python conditional here evaluates True we will exit
 # with status 1 which is a shell 'false' value.
-if ! $python -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_info >= (3,))'; then
-  error_exit "Cannot use '$python', Python 2.4 or later is required." \
+if ! $python -c 'import sys; sys.exit(sys.version_info < (2,6) or sys.version_info >= (3,))'; then
+  error_exit "Cannot use '$python', Python 2.6 or later is required." \
       "Note that Python 3 or later is not yet supported." \
       "Use --python=/path/to/python to specify a supported Python."
 fi
 
-# The -B switch was added in Python 2.6.
-# If it is supplied, compiled files are not written.
-# Use it for Python versions which support it.
-if $python -B -c 'import sys; sys.exit(0)' 2>/dev/null; then
-  python="$python -B"
-fi
+# Suppress writing compiled files
+python="$python -B"
 
 case "$cpu" in
     ppc)
Signature · 1 line
2.4.3
#2 lore raw
Quoted 10 lines · Peter Maydell
Quoted 4 lines · Markus Armbruster

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

I wonder if we're ever going to need to add that Python 3 support the error message alludes to :-)

Possibly, but for that to be practical, we'd really need to make Python 2.7 be the min version, so Py3 is probably a good way off in the future yet. There's no risk of Py2 dieing out any time soon so no rush :-)

Regards,
Daniel

Signature · 4 lines
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
#3 lore raw
Quoted 4 lines · Daniel P. Berrange
Quoted 3 lines · Peter Maydell
Quoted 2 lines · Markus Armbruster

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

I am actually building qemu on CentOS 5.11 with Python 2.4.3. I can probably install Python 2.6 on the system if necessary to build. Is the Python requirement just a build requirement or is it (libraries?) also needed on the machine where Qemu is run?

We actually ran into this already with libgmodule where the CentOS 5.11 version was too old. We installed archive only libgmodule libraries so that we could build qemu on CentOS 5.11 using the archive libgmodule library and then users could run Qemu on different Centos 5.11 systems without having to install a newer libgmodule on their system.

Steve Ellcey
[email protected]

#4 lore raw
Quoted 4 lines · Steve Ellcey
Quoted 1 line · Daniel P. Berrange

On Fri, Sep 04, 2015 at 11:44:17PM +0100, Peter Maydell wrote:

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines · Markus Armbruster
Quoted 2 lines

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

I am actually building qemu on CentOS 5.11 with Python 2.4.3. I can probably install Python 2.6 on the system if necessary to build. Is the Python requirement just a build requirement or is it (libraries?) also needed on the machine where Qemu is run?

Python should just be a build-time requirement.

Quoted 5 lines

We actually ran into this already with libgmodule where the CentOS 5.11 version was too old. We installed archive only libgmodule libraries so that we could build qemu on CentOS 5.11 using the archive libgmodule library and then users could run Qemu on different Centos 5.11 systems without having to install a newer libgmodule on their system.

Yes, I'm afraid that Centos 5 and RHEL 5 are no longer on our list of supported host OSes (support was dropped for QEMU 2.4). So you're likely to find that you need to provide updated local versions of various libraries/tools/etc.

thanks
-- PMM

#5 lore raw
In reply to Peter Maydell

ping

Quoted 10 lines · Peter Maydell
Quoted 4 lines · Markus Armbruster

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

I wonder if we're ever going to need to add that Python 3 support the error message alludes to :-)

Which tree will this be going through? I found myself interested in using python's:

first_expr if cond else second_expr

ternary, until I realized it requires python 2.5 or greater and we haven't yet flipped the switch.

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
#6 lore raw
Quoted 7 lines · Eric Blake

ping

Quoted 4 lines · Peter Maydell
Quoted 3 lines · Markus Armbruster

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

I wonder if we're ever going to need to add that Python 3 support the error message alludes to :-)

Which tree will this be going through?

Random buildsystem stuff usually gets picked up by Paolo.

-- PMM

#7 lore raw
Quoted 10 lines · Peter Maydell
Quoted 9 lines · Eric Blake

ping

Quoted 6 lines · Peter Maydell
Quoted 4 lines · Markus Armbruster

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

I wonder if we're ever going to need to add that Python 3 support the error message alludes to :-)

Which tree will this be going through?

Random buildsystem stuff usually gets picked up by Paolo.

I've queued it but I'm a bit busy, so I'm not going to send the next pull request until I've managed to test the record-replay stuff. Anyone can feel free to pick up this patch or others.

Paolo

#8 lore raw
In reply to Eric Blake
Quoted 14 lines · Eric Blake

ping

Quoted 10 lines · Peter Maydell
Quoted 4 lines · Markus Armbruster

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

I wonder if we're ever going to need to add that Python 3 support the error message alludes to :-)

Quoted 7 lines

Which tree will this be going through? I found myself interested in using python's:

first_expr if cond else second_expr

ternary, until I realized it requires python 2.5 or greater and we haven't yet flipped the switch.

Go ahead and depend on it in your QAPI work, just mention it in the cover letter. If it isn't in master by the time I request a pull, I'll stick it in before your series.

Reviewed-by on v1 1/1
#9 lore raw
In reply to Markus Armbruster
Quoted 4 lines · Markus Armbruster

RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6.

Regards,
Daniel

Signature · 4 lines
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|