Skip to contentSkip to conversation

iproute: print more verbose error on route cache flush

PATCH In review Denis Kirjanov 2 participants 2 messages Sep 5, 2015 – Sep 7, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iproute: print more verbose error on route cache flush

Before:
kda@vfirst ~/devel/iproute2 $ ./ip/ip route flush cache Cannot open "/proc/sys/net/ipv4/route/flush"

After:
kda@vfirst ~/devel/iproute2/ip $ ./ip route flush cache Cannot open "/proc/sys/net/ipv4/route/flush": Permission denied

---
 ip/iproute.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
ip/iproute.c +2 -1
index 8f49e62..abe4180 100644
@@ -1213,7 +1213,8 @@ static int iproute_flush_cache(void)
 	char *buffer = "-1";
 
 	if (flush_fd < 0) {
-		fprintf (stderr, "Cannot open \"%s\"\n", ROUTE_FLUSH_PATH);
+		fprintf (stderr, "Cannot open \"%s\": %s\n",
+				ROUTE_FLUSH_PATH, strerror(errno));
 		return -1;
 	}
 
Signature · 1 line
2.4.0
#1 lore raw
Quoted 18 lines · On Sat, 5 Sep 2015 10:40:50 +0300 Denis Kirjanov <[email protected]> wrote:

Before:
kda@vfirst ~/devel/iproute2 $ ./ip/ip route flush cache Cannot open "/proc/sys/net/ipv4/route/flush"

After:
kda@vfirst ~/devel/iproute2/ip $ ./ip route flush cache Cannot open "/proc/sys/net/ipv4/route/flush": Permission denied

---
 ip/iproute.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
ip/iproute.c +0 -0
index 8f49e62..abe4180 100644

ip/iproute.c static int iproute_flush_cache(void) · line 1220

Quoted 9 lines
ip/iproute.c +2 -1
@@ -1213,7 +1213,8 @@ static int iproute_flush_cache(void)
 	char *buffer = "-1";
 
 	if (flush_fd < 0) {
-		fprintf (stderr, "Cannot open \"%s\"\n", ROUTE_FLUSH_PATH);
+		fprintf (stderr, "Cannot open \"%s\": %s\n",
+				ROUTE_FLUSH_PATH, strerror(errno));
 		return -1;
 	}
 

Sure why not, applied