Skip to contentSkip to conversation

>=linux-4.1: build fails w/_PAGE_GLOBAL_SHIFT redefined errors in pgtable-bits.h

DISCUSSION Mike Frysinger 1 participant 2 messages Sep 11, 2015 – Sep 25, 2015 MIPS

lore
Share & tools
lore
#0 lore raw

this works in linux-4.0, but starting with 4.1, i'm seeing:
CC arch/mips/kernel/cpu-probe.o
In file included from ./arch/mips/include/asm/io.h:27:0,

                 from ./arch/mips/include/asm/page.h:176,
                 from include/linux/mm_types.h:15,
                 from include/linux/sched.h:27,
                 from include/linux/ptrace.h:5,
                 from arch/mips/kernel/cpu-probe.c:16:

./arch/mips/include/asm/pgtable-bits.h:164:0: error: "_PAGE_GLOBAL_SHIFT" redefined [-Werror] ./arch/mips/include/asm/pgtable-bits.h:141:0: note: this is the location of the previous definition
cc1: all warnings being treated as errors
make[2]: *** [arch/mips/kernel/cpu-probe.o] Error 1
make[1]: *** [arch/mips/kernel] Error 2
make: *** [arch/mips] Error 2

this warning hits many times, but this one is actually fatal

looks like it's due to:

	be0c37c985eddc46d0d67543898c086f60460e2e MIPS: Rearrange PTE bits into fixed positions.

my config is attached
-mike

#1 lore raw
Quoted 15 lines · Mike Frysinger

this works in linux-4.0, but starting with 4.1, i'm seeing:
CC arch/mips/kernel/cpu-probe.o
In file included from ./arch/mips/include/asm/io.h:27:0,

                 from ./arch/mips/include/asm/page.h:176,
                 from include/linux/mm_types.h:15,
                 from include/linux/sched.h:27,
                 from include/linux/ptrace.h:5,
                 from arch/mips/kernel/cpu-probe.c:16:

./arch/mips/include/asm/pgtable-bits.h:164:0: error: "_PAGE_GLOBAL_SHIFT" redefined [-Werror] ./arch/mips/include/asm/pgtable-bits.h:141:0: note: this is the location of the previous definition
cc1: all warnings being treated as errors
make[2]: *** [arch/mips/kernel/cpu-probe.o] Error 1
make[1]: *** [arch/mips/kernel] Error 2
make: *** [arch/mips] Error 2

Quoted 6 lines

this warning hits many times, but this one is actually fatal

looks like it's due to:

	be0c37c985eddc46d0d67543898c086f60460e2e MIPS: Rearrange PTE bits into fixed positions.

my config is attached

looks like this is fixed for linux-4.3 with:

commit 1cfa8de2880e5512f9037c7804ea47a79cc8232c

Author:     Maciej W. Rozycki <[email protected]>
AuthorDate: Sun May 3 10:36:19 2015 +0100
Commit:     Ralf Baechle <[email protected]>
CommitDate: Sun Aug 30 13:16:40 2015 +0200

MIPS: pgtable-bits.h: Correct _PAGE_GLOBAL_SHIFT build failure

can that get included in linux-4.1 and linux-4.2 stable ? -mike