omap3: cm-t3517: series of non critical fixes
cover omap3: cm-t3517: series of non critical fixes
These patches fix non critical issues, required to sync CM-T3517 mainline U-Boot with the that, shipped with the boards.
Dmitry Lifshitz (3):
omap3: cm-t3517: enable 'netretry' and setup timeout
omap3: cm-t3517: fix MMC1 pinmux
omap3: cm-t3517: change environment size
board/compulab/cm_t3517/mux.c | 12 ++++++------ include/configs/cm_t3517.h | 7 +++++-- 2 files changed, 11 insertions(+), 8 deletions(-)
Signature · 1 line
1.7.5.4
PATCH 1/3 omap3: cm-t3517: enable 'netretry' and setup timeout
SBC-T3517 evaluation board has two Eth interfaces. Enable network retry of another interface if the default if failed or disconnected.
Add 'netretry=yes' in the default env. Setup relevant timeout values in the board config file.
--- include/configs/cm_t3517.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
include/configs/cm_t3517.h +3 -0
@@ -170,6 +170,7 @@"loadaddr=0x82000000\0" \"baudrate=115200\0" \"console=ttyO2,115200n8\0" \ +"netretry=yes\0" \"mpurate=auto\0" \"vram=12M\0" \"dvimode=1024x768MR-16 at 60\0" \
@@ -275,6 +276,8 @@#define CONFIG_SMC911X #define CONFIG_SMC911X_32_BIT #define CONFIG_SMC911X_BASE (0x2C000000 + (16 << 20)) +#define CONFIG_ARP_TIMEOUT 200UL +#define CONFIG_NET_RETRY_COUNT 5#endif /* CONFIG_CMD_NET */ /* additions for new relocation code, must be added to all boards */
Signature · 1 line
1.7.5.4
PATCH 1/3 omap3: cm-t3517: enable 'netretry' and setup timeout
Quoted 8 lines · Dmitry Lifshitz
SBC-T3517 evaluation board has two Eth interfaces. Enable network retry of another interface if the default if failed or disconnected.
Add 'netretry=yes' in the default env. Setup relevant timeout values in the board config file.
Signed-off-by Dmitry Lifshitz <[email protected]>
Quoted 26 lines
--- include/configs/cm_t3517.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)include/configs/cm_t3517.h +3
-0@@ -170,6 +170,7 @@"loadaddr=0x82000000\0" \"baudrate=115200\0" \"console=ttyO2,115200n8\0" \ +"netretry=yes\0" \"mpurate=auto\0" \"vram=12M\0" \"dvimode=1024x768MR-16 at 60\0" \@@ -275,6 +276,8 @@#define CONFIG_SMC911X #define CONFIG_SMC911X_32_BIT #define CONFIG_SMC911X_BASE (0x2C000000 + (16 << 20)) +#define CONFIG_ARP_TIMEOUT 200UL +#define CONFIG_NET_RETRY_COUNT 5#endif /* CONFIG_CMD_NET */ /* additions for new relocation code, must be added to all boards */
Signature · 2 lines
Regards, Igor.
PATCH 1/3 omap3: cm-t3517: enable 'netretry' and setup timeout
In reply to Dmitry LifshitzQuoted 9 lines · Dmitry Lifshitz
SBC-T3517 evaluation board has two Eth interfaces. Enable network retry of another interface if the default if failed or disconnected.
Add 'netretry=yes' in the default env. Setup relevant timeout values in the board config file.
Signed-off-by Dmitry Lifshitz <[email protected]>Acked-by Igor Grinberg <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150912/3e315277/attachment.sig>
PATCH 2/3 omap3: cm-t3517: fix MMC1 pinmux
In reply to Dmitry LifshitzFix MMC1 pinmux setup, thus enable SD/MMC card support with CM-T3517.
--- board/compulab/cm_t3517/mux.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
board/compulab/cm_t3517/mux.c +6 -6
@@ -121,12 +121,12 @@ void set_muxconf_regs(void)MUX_VAL (CP (UART2_RX ), (IEN |PTD |EN |M4 ));/*GPIO_147*/ /* MMC1 */ -MUX_VAL (CP (MMC1_CLK ), (IDIS |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_CMD ), (IEN |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_DAT0 ), (IEN |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_DAT1 ), (IEN |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_DAT2 ), (IEN |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_DAT3 ), (IEN |PTU |EN |M0 )); +MUX_VAL (CP (MMC1_CLK ), (IEN |PTU |EN |M0 )); +MUX_VAL (CP (MMC1_CMD ), (IEN |PTU |DIS |M0 )); +MUX_VAL (CP (MMC1_DAT0 ), (IEN |PTU |DIS |M0 )); +MUX_VAL (CP (MMC1_DAT1 ), (IEN |PTU |DIS |M0 )); +MUX_VAL (CP (MMC1_DAT2 ), (IEN |PTU |DIS |M0 )); +MUX_VAL (CP (MMC1_DAT3 ), (IEN |PTU |DIS |M0 ));/* DSS */ MUX_VAL (CP (DSS_PCLK ), (IDIS |PTD |DIS |M0 ));
Signature · 1 line
1.7.5.4
PATCH 2/3 omap3: cm-t3517: fix MMC1 pinmux
Quoted 3 lines · Dmitry Lifshitz
Fix MMC1 pinmux setup, thus enable SD/MMC card support with CM-T3517.
Signed-off-by Dmitry Lifshitz <[email protected]>
Quoted 28 lines
--- board/compulab/cm_t3517/mux.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)board/compulab/cm_t3517/mux.c +6
-6@@ -121,12 +121,12 @@ void set_muxconf_regs(void)MUX_VAL (CP (UART2_RX ), (IEN |PTD |EN |M4 ));/*GPIO_147*/ /* MMC1 */ -MUX_VAL (CP (MMC1_CLK ), (IDIS |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_CMD ), (IEN |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_DAT0 ), (IEN |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_DAT1 ), (IEN |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_DAT2 ), (IEN |PTU |EN |M0 )); -MUX_VAL (CP (MMC1_DAT3 ), (IEN |PTU |EN |M0 )); +MUX_VAL (CP (MMC1_CLK ), (IEN |PTU |EN |M0 )); +MUX_VAL (CP (MMC1_CMD ), (IEN |PTU |DIS |M0 )); +MUX_VAL (CP (MMC1_DAT0 ), (IEN |PTU |DIS |M0 )); +MUX_VAL (CP (MMC1_DAT1 ), (IEN |PTU |DIS |M0 )); +MUX_VAL (CP (MMC1_DAT2 ), (IEN |PTU |DIS |M0 )); +MUX_VAL (CP (MMC1_DAT3 ), (IEN |PTU |DIS |M0 ));/* DSS */ MUX_VAL (CP (DSS_PCLK ), (IDIS |PTD |DIS |M0 ));
Signature · 2 lines
Regards, Igor.
PATCH 2/3 omap3: cm-t3517: fix MMC1 pinmux
In reply to Dmitry LifshitzQuoted 4 lines · Dmitry Lifshitz
Fix MMC1 pinmux setup, thus enable SD/MMC card support with CM-T3517.
Signed-off-by Dmitry Lifshitz <[email protected]>Acked-by Igor Grinberg <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150912/389ca45c/attachment.sig>
PATCH 3/3 omap3: cm-t3517: change environment size
In reply to Dmitry LifshitzMainline CM-T3517 U-Boot environment size differs from the that one shipped with CM-T3517 boards.
Update environment size, to avoid backward compatability issues.
--- include/configs/cm_t3517.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/cm_t3517.h +2 -2
@@ -66,8 +66,8 @@/* * Size of malloc() pool */ -#define CONFIG_ENV_SIZE (16 << 10)/* 16 KiB */ -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10)) +#define CONFIG_ENV_SIZE (128 << 10)/* 128 KiB */ +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (512 << 10))/* * Hardware drivers
Signature · 1 line
1.7.5.4
PATCH 3/3 omap3: cm-t3517: change environment size
Hi Dima,
Quoted 2 lines · Dmitry Lifshitz
Mainline CM-T3517 U-Boot environment size differs from the that one shipped with CM-T3517 boards.
There is some strangeness in the above sentence...
Quoted 2 lines
Update environment size, to avoid backward compatability issues.
s/compatability/compatibility/
Quoted 11 lines
Signed-off-by Dmitry Lifshitz <[email protected]>--- include/configs/cm_t3517.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)include/configs/cm_t3517.h +0
-0
include/configs/cm_t3517.h line 70
Quoted 7 lines
include/configs/cm_t3517.h +2
-2@@ -66,8 +66,8 @@/* * Size of malloc() pool */ -#define CONFIG_ENV_SIZE (16 << 10)/* 16 KiB */ -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10)) +#define CONFIG_ENV_SIZE (128 << 10)/* 128 KiB */ +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (512 << 10))
Why do you change CONFIG_SYS_MALLOC_LEN?
Isn't it not enough?
If so, I would expect to see some explanation in the commit message.
Signature · 2 lines
Regards, Igor.
PATCH v2 3/3 omap3: cm-t3517: change environment size
In reply to Dmitry LifshitzMainline CM-T3517 U-Boot environment size differs from that one shipped with CM-T3517 boards.
Update environment size, to avoid backward compatibility issues.
---
Changes in v2:
* Removed unjustified CONFIG_SYS_MALLOC_LEN change.
include/configs/cm_t3517.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/cm_t3517.h +1 -1
@@ -66,7 +66,7 @@/* * Size of malloc() pool */ -#define CONFIG_ENV_SIZE (16 << 10)/* 16 KiB */ +#define CONFIG_ENV_SIZE (128 << 10)/* 128 KiB */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10))/*
Signature · 1 line
1.7.5.4
PATCH v2 3/3 omap3: cm-t3517: change environment size
Quoted 6 lines · Dmitry Lifshitz
Mainline CM-T3517 U-Boot environment size differs from that one shipped with CM-T3517 boards.
Update environment size, to avoid backward compatibility issues.
Signed-off-by Dmitry Lifshitz <[email protected]>
Quoted 23 lines
---
Changes in v2:
* Removed unjustified
CONFIG_SYS_MALLOC_LENchange.include/configs/cm_t3517.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/configs/cm_t3517.h +1
-1@@ -66,7 +66,7 @@/* * Size of malloc() pool */ -#define CONFIG_ENV_SIZE (16 << 10)/* 16 KiB */ +#define CONFIG_ENV_SIZE (128 << 10)/* 128 KiB */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10))/*
Signature · 2 lines
Regards, Igor.
PATCH v2 3/3 omap3: cm-t3517: change environment size
In reply to Dmitry LifshitzQuoted 7 lines · Dmitry Lifshitz
Mainline CM-T3517 U-Boot environment size differs from that one shipped with CM-T3517 boards.
Update environment size, to avoid backward compatibility issues.
Signed-off-by Dmitry Lifshitz <[email protected]>Acked-by Igor Grinberg <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150912/21b68018/attachment.sig>