ata: pata_macio: Fix module autoload for OF platform driver
PATCH v2 1/1 ata: pata_macio: Fix module autoload for OF platform driver
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.
This patch adds the missing MODULE_DEVICE_TABLE() for OF to export that information so modules have the correct aliases built-in and autoloading works correctly.
--- drivers/ata/pata_macio.c | 1 + 1 file changed, 1 insertion(+)
drivers/ata/pata_macio.c +1 -0
@@ -1344,6 +1344,7 @@ static struct of_device_id pata_macio_match[] = }, {}, }; +MODULE_DEVICE_TABLE (of, pata_macio_patch);static struct macio_driver pata_macio_driver = {
Signature · 1 line
2.4.6
Quoted 9 lines · Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.
This patch adds the missing
MODULE_DEVICE_TABLE()for OF to export that information so modules have the correct aliases built-in and autoloading works correctly.Signed-off-by Luis de Bethencourt <[email protected]>
Where should this patch be applied? for-4.4? for-4.3-fixes w/ or w/o stable cc'd?
Thanks.
Signature · 1 line
tejun
Quoted 8 lines · Tejun Heo
Quoted 7 lines · Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.
This patch adds the missing
MODULE_DEVICE_TABLE()for OF to export that information so modules have the correct aliases built-in and autoloading works correctly.
Quoted 10 lines
Quoted 2 lines
Signed-off-by Luis de Bethencourt <[email protected]>Where should this patch be applied? for-4.4? for-4.3-fixes w/ or w/o stable cc'd?
Thanks.
Signature · 1 line
tejun
Hi Tejun,
Other drivers with the same problem are applying this in 4.3-fixes.
I don't think it is critical enough to deserve a cc: Stable.
Thanks for review,
Luis
Tejun Heo
AppliedQuoted 9 lines · Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.
This patch adds the missing
MODULE_DEVICE_TABLE()for OF to export that information so modules have the correct aliases built-in and autoloading works correctly.Signed-off-by Luis de Bethencourt <[email protected]>
Applied to libata/for-4.3-fixes.
Thanks!
Signature · 1 line
tejun