Skip to contentSkip to conversation

Buildroot' patch to add support for aarch64 in mplayer configure script

PATCH Superseded jpinto 3 participants 5 messages Sep 15, 2015 – Sep 16, 2015

lore
Share & tools
lore

jpinto

author
#0 lore raw

PATCH v2 1/1 Buildroot' patch to add support for aarch64 in mplayer configure script

---
 package/mplayer/0007-enable-aarch64.patch | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 package/mplayer/0007-enable-aarch64.patch
package/mplayer/0007-enable-aarch64.patch new file +13 -0
new file mode 100644
index 0000000..7f75756
@@ -0,0 +1,13 @@
+--- b/configure	2015-09-15 17:30:46.187307557 +0100
++++ a/configure	2015-09-15 17:31:11.729307537 +0100
+@@ -2496,6 +2496,10 @@
+     arch='arc'
+     iproc='arc'
+     ;;
++  aarch64)
++    arch='arm64'
++    iproc='arm64'
++    ;;
+ 
+   *)
+     echo "The architecture of your CPU ($host_arch) is not supported by this configure script"
---
 package/mplayer/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mplayer/Config.in +1 -1
index 79ff3b1..7a8b03f 100644
@@ -3,7 +3,7 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
 	default y
 	# Those architectures are not supported by MPlayer
 	depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
-		|| BR2_microblaze || BR2_aarch64 || BR2_nios2)
+		|| BR2_microblaze || BR2_nios2)
 	# Broken support for <ARMv5
 	depends on !BR2_ARM_CPU_ARMV4
 
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v3 1/1 Buildroot' patch to add support for aarch64 in mplayer configure script

Hello Joao,

Your e-mail is two patches concataned to each other. Can you make that a single patch instead?

Also, the title should be adjusted, as I explained in a previous message. See some more comments below.

package/mplayer/0007-enable-aarch64.patch

Quoted 14 lines · jpinto
---
 package/mplayer/0007-enable-aarch64.patch | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 package/mplayer/0007-enable-aarch64.patch
package/mplayer/0007-enable-aarch64.patch new file +0 -0
new file mode 100644
index 0000000..7f75756
@@ -0,0 +1,13 @@

All patches in Buildroot should have a description and a Signed-off-by line. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for details.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v3 1/1 Buildroot' patch to add support for aarch64 in mplayer configure script

Quoted 17 lines · Thomas Petazzoni

Hello Joao,

Your e-mail is two patches concataned to each other. Can you make that a single patch instead?

Also, the title should be adjusted, as I explained in a previous message. See some more comments below.

Quoted 8 lines · jpinto
---
 package/mplayer/0007-enable-aarch64.patch | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 package/mplayer/0007-enable-aarch64.patch
Quoted 11 lines

package/mplayer/0007-enable-aarch64.patch

Quoted 6 lines
package/mplayer/0007-enable-aarch64.patch new file +0 -0
new file mode 100644
index 0000000..7f75756
@@ -0,0 +1,13 @@

All patches in Buildroot should have a description and a Signed-off-by line. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for details.

Once that is done, could you also send the patch upstream?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#3 lore raw

PATCH v3 1/1 Buildroot' patch to add support for aarch64 in mplayer configure script

Hi Arnout!

Quoted 30 lines · Arnout Vandecappelle
Quoted 17 lines · Thomas Petazzoni

Hello Joao,

Your e-mail is two patches concataned to each other. Can you make that a single patch instead?

Also, the title should be adjusted, as I explained in a previous message. See some more comments below.

Quoted 8 lines · jpinto
---
 package/mplayer/0007-enable-aarch64.patch | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 package/mplayer/0007-enable-aarch64.patch
Quoted 11 lines

package/mplayer/0007-enable-aarch64.patch

Quoted 6 lines
package/mplayer/0007-enable-aarch64.patch new file +0 -0
new file mode 100644
index 0000000..7f75756
@@ -0,0 +1,13 @@

All patches in Buildroot should have a description and a Signed-off-by line. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for details.

Quoted 1 line

Once that is done, could you also send the patch upstream?

When you say upstream, you mean send it to mplayer authors?

Quoted 5 lines

Regards,
Arnout

Regards,
Joao

#4 lore raw

PATCH v3 1/1 Buildroot' patch to add support for aarch64 in mplayer configure script

Dear Joao Pinto,

Quoted 8 lines · Joao Pinto
Quoted 6 lines
Quoted 4 lines

All patches in Buildroot should have a description and a Signed-off-by line. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for details.

Once that is done, could you also send the patch upstream?

When you say upstream, you mean send it to mplayer authors?

Yes, exactly. We don't really like to keep patches on packages forever, so when they can be sent upstream, it's better.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com