Skip to contentSkip to conversation

IB/hfi1: add driver files

DISCUSSION Dan Carpenter 1 participant 1 message Sep 16, 2015 InfiniBand

lore
Share & tools
lore
#0 lore raw

Hello Mike Marciniszyn,

The patch 7724105686e7: "IB/hfi1: add driver files" from Jul 30, 2015, leads to the following static checker warning:

	drivers/staging/rdma/hfi1/user_sdma.c:1349 set_txreq_header_ahg()
	warn: mask and shift to zero

drivers/staging/rdma/hfi1/user_sdma.c
1347 /* Clear KDETH.SH on last packet */
1348 if (unlikely(tx->flags & USER_SDMA_TXREQ_FLAGS_LAST_PKT)) {
1349 val |= cpu_to_le16(KDETH_GET(hdr->kdeth.ver_tid_offset,
1350 INTR) >> 16);

KDETH_GET(hdr->kdeth.ver_tid_offset, INTR) is zero or one. 1 >> 16 is zero. This line is a no-op.

  1351                          val &= cpu_to_le16(~(1U << 13));
  1352                          AHG_HEADER_SET(req->ahg, diff, 7, 16, 14, val);
  1353                  } else
  1354                          AHG_HEADER_SET(req->ahg, diff, 7, 16, 12, val);

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html